From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E33E0C433F5 for ; Mon, 31 Jan 2022 16:21:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D6F8E83097; Mon, 31 Jan 2022 17:21:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="U1cYj2cP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B5BF5837B5; Mon, 31 Jan 2022 17:21:44 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EB86A8141E for ; Mon, 31 Jan 2022 17:21:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id r14so11873256qtt.5 for ; Mon, 31 Jan 2022 08:21:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/eiuTMjrODH8ISecuJ0XTUoU0GO2kyfSXxdrcWLP2FU=; b=U1cYj2cPg+X5hdVLjEYFROesc75ZZNE6dfakYtQtzePipGgeNvG8qUZOap6251Eccg C39pjgzS6wGAjcbNjWDXWeDuVs3h8KyUET/K59en+h6ZQ52MUsd5U6eCiO6liy/Sndxq nsRSMJW1blMGegKbyh/onxTLdPzWHW/IHeO9c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/eiuTMjrODH8ISecuJ0XTUoU0GO2kyfSXxdrcWLP2FU=; b=8G1PSbA45hlciueN+la6z6xpqAbESq3fWRpjXTJVyavp/J3eO2fkLbNbUuMBCFCDeM qqRpKk7qKWkUPUz50M/fBw0PYx1B/rELp5yquNdtRS+Ipvyz3yHTRChqSoypJ3ooUO9g XgceEv11cSAvUqs6r3edxVBw4E/vSMJW78flSOxe/7MKI5+ahjx9pFEu79pMsmJ1NiBF 45KZ3DoN4sNIwWrFwl9wR2W2p/e9WRwsz1T2padZRRmpenG6VvQcK7XxSfm4zW93nbBy Yq0upKtaoDzs4B22Je6rv+VxqgYSbO1PArFX9/PdP6sdXOryhNJhshfTETAQ42cCkMYq uwvg== X-Gm-Message-State: AOAM532DX2udt2pOLksoVNXY+olmv4MykEIaSAt3IvUFNvuCePVMMBy3 HXR5oytx1J/u1POtFvko2w//bA== X-Google-Smtp-Source: ABdhPJzpgrvu7igYtkF4Uarcs+DnZWh/iMZJ+0xOpvvATAuXfcXf9a2mvRxcfY/8D47QGIiC6bTUtg== X-Received: by 2002:a05:622a:50e:: with SMTP id l14mr15426306qtx.555.1643646100831; Mon, 31 Jan 2022 08:21:40 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id y15sm9116815qko.95.2022.01.31.08.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 08:21:40 -0800 (PST) Date: Mon, 31 Jan 2022 11:21:38 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Masahiro Yamada , Wolfgang Denk Subject: Re: [PATCH v2 1/2] Makefile: Create a file to indicate the config Message-ID: <20220131162138.GA7515@bill-the-cat> References: <20220130155225.726890-1-sjg@chromium.org> <20220131142402.GG7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CHpW5YICyLt6224O" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --CHpW5YICyLt6224O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 09:13:07AM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > On Sun, Jan 30, 2022 at 08:52:24AM -0700, Simon Glass wrote: > > > > > At present it is not actually possible to discover the defconfig file= that > > > was used to build U-Boot, so far as I can tell. Write this out to a f= ile > > > in the build directory, so this is visible. > > > > > > Signed-off-by: Simon Glass > > > > I don't think we need this really normally, it's just for the follow-up > > patch. >=20 > I'd argue that it is helpful to have this somewhere. Is there anywhere > else in the build directory where it can be discovered? It's not a guarantee to exist is my first problem. My minor problems are this needs to be in .gitignore and also I think this wasn't ensuring output directory not source directory. But I don't see the use case this is filling. If you're in-tree, you should know what you configured and are working on. If you're out of tree and didn't do any sort of naming convention to your objdirs, did you also really care what defconfig exactly (I use a mix of named and garbage-named temp dirs)? And if you're a tool of some sort, you were told what to use at some point I would assume. Which all gets back to I don't see the use case exactly for it. --=20 Tom --CHpW5YICyLt6224O Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4DJIACgkQFHw5/5Y0 tyyeowv6AtDv2bFZ6D5SdG4j+JDA1tiT672gB4ZkFmmmK/0EOnBYuzVhTc75mHaB t0vMXcct3fhIzQf99eWQO1j4id1ch9//32gmZiftmgj7ujzxpx/PYsa8EHQo99Ys YYnbD7+X4OlVu4Nqi06R/PKzn0RIf5GD1k48Nn2wK0uh5MGTdaOdta9QDiePeFhp iIZivkfujJGjmw1xeFl68ua7/kO2USNd7H/JrblOrlNNLFRvhedAuB+Mj6CUZbqZ ryglqlDIyqsAtoltnunBcspasFesQ22bwl0h3ijgZkV1Jp/vu1EmDBdj2Yi5rcP4 aiKQ6AKDkBCXOaw/UiNmBGc7BtqLHKA/hqd7gO+leHt8pwb4UQnHEsAoJrJNnRsz bWhE0sUb9rRmdPU+aY3aOvUpx6QUXZVsZe09v8H5Xv2fjr7y9xafTHy6f2+YBL6u somWt18XgtK7irnX8BGOMu/oLoKVXmNDzfm7jpCZAiX5X3LfAnPkHeJz1NKaE83E oYvtrnDW =by08 -----END PGP SIGNATURE----- --CHpW5YICyLt6224O--