From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CEBC433FE for ; Mon, 31 Jan 2022 17:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380833AbiAaRTW (ORCPT ); Mon, 31 Jan 2022 12:19:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380829AbiAaRTQ (ORCPT ); Mon, 31 Jan 2022 12:19:16 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27CD8C06173D for ; Mon, 31 Jan 2022 09:19:16 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id s6so7440206plg.12 for ; Mon, 31 Jan 2022 09:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hx6TH2V2Xf2UjSWOsTZZ6odBJt3j58eeTOeYnmI2onk=; b=ZUoF9QrSJSC7VABDAeUcpREISLFdzZbzr815n8t1kCZvQh0UWJ7RqxHqAbectE6iSB Jav+47/50aomFac/w7dyQXaZ0jQZtb/e1Myea++ZMldgaLOymZLKbQeFXiPkePFEYD8f xlrf3gRNOhh1+xKV7dEUzHnLa2vJbNMyLwYad30cRE2B5ek+nUpXQo3wtpVpI3EAqlqY 4IeYEYZMVgt7eZkBcmG/jGRhOCOYLbGE7nvI5w4vl0Ad1s77Ez7v7PxioGjwkFzWtDFl lcGQbmywG6c8vyxPzR4dwygpm4N8HoGxaGuLV/NMnJlN/O15MaYSx+NOg5dVKQ538+O7 uOPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hx6TH2V2Xf2UjSWOsTZZ6odBJt3j58eeTOeYnmI2onk=; b=St1dooBypMMQQqNAQS8862VrNmysVnYWpNfE8PVRwxTvm+iJ8qSwQ3nbaAK4l06EjN MouT0/1KZyxpA0elccds/Yt5vL01YclO1tlfi2WMBtZiIRPaZW/4jMh/inPVTxXZVWDm mcEOV7piVjHkMptdMZsG/HMHXFOarkXVmAmzSUeBUOksBusgT6T5GhGEsZk9A81CgMpJ NjEyhMBnTDtSQiXEzN43L2in0De/lbHjxQ3+iy4MQRa6cMtAmf0Wz4hD8/LGWVt/2cFX JJm7x1iuevwildVdKwuwTZgNJ2YZ8yrogtcDYOMBbgzu/5VY4Em0vWNnAyOmqonax8Gd GkMw== X-Gm-Message-State: AOAM533J/BQQp0KjanduZWfP0KD+OsIymh4CrT9tdOiwMmTuD1H6jaVE rUyhi/hH/j/WTogPgf2u2htnVw== X-Google-Smtp-Source: ABdhPJyHcqvv4VH4GOQ/VKJzF0Psuj4eZMbZ1SQIRWaFtSjpT+JQaxOIKcHzXOJmYqgfwz4YGGH1tg== X-Received: by 2002:a17:902:6b4b:: with SMTP id g11mr21570386plt.109.1643649555570; Mon, 31 Jan 2022 09:19:15 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id h6sm19371067pfc.35.2022.01.31.09.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 09:19:14 -0800 (PST) Date: Mon, 31 Jan 2022 10:19:12 -0700 From: Mathieu Poirier To: Hari Nagalla Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: k3-m4f: Add bindings for K3 AM64x SoCs Message-ID: <20220131171912.GA2404841@p14s> References: <20220110040650.18186-1-hnagalla@ti.com> <20220110040650.18186-2-hnagalla@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220110040650.18186-2-hnagalla@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hello Hari, On top of Rob's comments about warning, please see below. On Sun, Jan 09, 2022 at 10:06:49PM -0600, Hari Nagalla wrote: > K3 AM64x SoC has a Cortex M4F subsystem in the MCU volatge domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Hari Nagalla > --- > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 121 ++++++++++++++++++ > 1 file changed, 121 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > new file mode 100644 > index 000000000000..8db9a3f6256e > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > @@ -0,0 +1,121 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI K3 M4F processor subsystems > + > +maintainers: > + - Hari Nagalla > + > +description: | > + Some K3 family SoCs have Arm Cortex M4F cores. AM64x is a SoC in K3 > + family with a M4F core. Typically safety oriented applications may use > + the M4F core in isolation with out an IPC. Where as some Industrial and s/"with out"/without s/Industrial/industrial > + home automation applications, may use the M4F core as a remote processor > + with IPC communications. > + > +properties: > + $nodename: > + pattern: "^m4fss(@.*)?" > + > + compatible: > + enum: > + - ti,am64-m4fss > + > + power-domains: > + description: | > + Should contain a phandle to a PM domain provider node and an args > + specifier containing the M4FSS device id value. > + maxItems: 1 > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + reg: > + items: > + - description: Address and Size of the IRAM internal memory region > + - description: Address and Size of the DRAM internal memory region > + > + reg-names: > + items: > + - const: iram > + - const: dram > + > + resets: > + description: | > + Should contain the phandle to the reset controller node managing the > + local resets for this device, and a reset specifier. > + maxItems: 1 > + > + firmware-name: > + description: | > + Should contain the name of the default firmware image > + file located on the firmware search path > + > + mboxes: > + description: | > + OMAP Mailbox specifier denoting the sub-mailbox, to be used for > + communication with the remote processor. This property should match > + with the sub-mailbox node used in the firmware image. > + maxItems: 1 > + > + memory-region: > + description: | > + phandle to the reserved memory nodes to be associated with the > + remoteproc device. There should be at least two reserved memory nodes > + defined. The reserved memory nodes should be carveout nodes, and > + should be defined with a "no-map" property as per the bindings in > + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > + minItems: 2 > + maxItems: 8 > +# items: > +# - description: region used for dynamic DMA allocations like vrings and > +# vring buffers > +# - description: region reserved for firmware image sections > + additionalItems: true > + > + unevaluatedProperties: false > + > + > +required: > + - compatible > + - power-domains There is no "power-domains" in the example below. > + - "#address-cells" > + - "#size-cells" > + - reg > + - reg-names > + - ti,sci > + - ti,sci-dev-id > + - ti,sci-proc-ids The above 3 are not described in this document. > + - resets > + - firmware-name > + > +additionalProperties: false > + > +examples: > + - | > + cbass_main: bus@f4000 { > + #address-cells = <2>; > + #size-cells = <2>; > + mcu_m4fss: m4fss@5000000 { > + compatible = "ti,am64-m4fss"; > + reg = <0x00 0x5000000 0x00 0x30000>, > + <0x00 0x5040000 0x00 0x10000>; > + reg-names = "iram", "dram"; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <9>; > + ti,sci-proc-ids = <0x18 0xff>; > + resets = <&k3_reset 9 1>; > + firmware-name = "am64-mcu-m4f0_0-fw"; > + mboxes = <&mailbox0_cluster6 &mbox_m4_0>; > + memory-region = <&mcu_m4fss_dma_memory_region>, > + <&mcu_m4fss_memory_region>; > + }; > + }; > + > +... > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 081C2C433EF for ; Mon, 31 Jan 2022 17:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U7qmninXQnsO0gCs8vfU8s2LWSkbAhF28sGeqF/hrMg=; b=vLS97cgmJq0TuE mG82U0fHHcuyQkwj3brqB5QzlloU7iKVSpf4+3znaXEhbB0Z9S/Pl8oy2EhWbn0b5WFKjgGU/6hMg Va6tdT38uhp1w5SLzADq5y43yV/9X/p52wFK+cPLgW0FUd278/Vz1m40rxO1E0nIJ60/okN+gp+aM 1AYNclIJiPGbK3BVstZptnmsdk2vAyqYKVNXyU28nLpL+NL825EcuFyvdcLYAYZ8ojtxMRoNTeQch Jnl+aGnrlRJZ+iW7YcIfRDaXISJknuQutB8MHjKGRa/aOP73CJiwys4k0SlD/iB5sGpqsAL+xAWKP XMzd8QCVj1GjSVHIoZYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEaa2-00A9jH-DU; Mon, 31 Jan 2022 17:35:07 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEaKj-00A3tw-KX for linux-arm-kernel@lists.infradead.org; Mon, 31 Jan 2022 17:19:19 +0000 Received: by mail-pl1-x634.google.com with SMTP id d1so12944430plh.10 for ; Mon, 31 Jan 2022 09:19:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Hx6TH2V2Xf2UjSWOsTZZ6odBJt3j58eeTOeYnmI2onk=; b=ZUoF9QrSJSC7VABDAeUcpREISLFdzZbzr815n8t1kCZvQh0UWJ7RqxHqAbectE6iSB Jav+47/50aomFac/w7dyQXaZ0jQZtb/e1Myea++ZMldgaLOymZLKbQeFXiPkePFEYD8f xlrf3gRNOhh1+xKV7dEUzHnLa2vJbNMyLwYad30cRE2B5ek+nUpXQo3wtpVpI3EAqlqY 4IeYEYZMVgt7eZkBcmG/jGRhOCOYLbGE7nvI5w4vl0Ad1s77Ez7v7PxioGjwkFzWtDFl lcGQbmywG6c8vyxPzR4dwygpm4N8HoGxaGuLV/NMnJlN/O15MaYSx+NOg5dVKQ538+O7 uOPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Hx6TH2V2Xf2UjSWOsTZZ6odBJt3j58eeTOeYnmI2onk=; b=0dcQG05KIWa3h6mrUaRmZiA3hvfFFHHgKoiWeFi/Dk+ET+kScjmINI0QkOL0O45pQ9 qyuvWPEi+AxBCcyguUgfZnDhSYnHvijm8AYXS9XlT6A33FaR5CVcIISROAmbich13cwS yF96YBU8HNMh0HRvHeKentR4VpknLoSdVRV8igilGRjcYeMFVBsjdZmH7i8J6ZloTaBy LzsTjZ/ShsnlGcBUYMCgXbAgNuEB3TuX7K5SuGylCct33QY3lJ/HCdjbLXRBJPPcfjgf AVIgfjBIw6ujv2DsGJ1u+6QKenxmsjJZ6DMuFiyqLyIN8AY1ifTe1rNsEOjI5qV1SZZq 8Xww== X-Gm-Message-State: AOAM533+Ylfntdoi1U+4p9Z2UToLl4PYGEuUXFEDw7OFjDI1OtUN4p0c 1T/3ulRBoWqYLMXSSjKAUBzpCw== X-Google-Smtp-Source: ABdhPJyHcqvv4VH4GOQ/VKJzF0Psuj4eZMbZ1SQIRWaFtSjpT+JQaxOIKcHzXOJmYqgfwz4YGGH1tg== X-Received: by 2002:a17:902:6b4b:: with SMTP id g11mr21570386plt.109.1643649555570; Mon, 31 Jan 2022 09:19:15 -0800 (PST) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id h6sm19371067pfc.35.2022.01.31.09.19.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 09:19:14 -0800 (PST) Date: Mon, 31 Jan 2022 10:19:12 -0700 From: Mathieu Poirier To: Hari Nagalla Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: k3-m4f: Add bindings for K3 AM64x SoCs Message-ID: <20220131171912.GA2404841@p14s> References: <20220110040650.18186-1-hnagalla@ti.com> <20220110040650.18186-2-hnagalla@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220110040650.18186-2-hnagalla@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_091917_730059_494811AB X-CRM114-Status: GOOD ( 27.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Hari, On top of Rob's comments about warning, please see below. On Sun, Jan 09, 2022 at 10:06:49PM -0600, Hari Nagalla wrote: > K3 AM64x SoC has a Cortex M4F subsystem in the MCU volatge domain. > The remote processor's life cycle management and IPC mechanisms are > similar across the R5F and M4F cores from remote processor driver > point of view. However, there are subtle differences in image loading > and starting the M4F subsystems. > > The YAML binding document provides the various node properties to be > configured by the consumers of the M4F subsystem. > > Signed-off-by: Hari Nagalla > --- > .../bindings/remoteproc/ti,k3-m4f-rproc.yaml | 121 ++++++++++++++++++ > 1 file changed, 121 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > new file mode 100644 > index 000000000000..8db9a3f6256e > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-m4f-rproc.yaml > @@ -0,0 +1,121 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/remoteproc/ti,k3-m4f-rproc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: TI K3 M4F processor subsystems > + > +maintainers: > + - Hari Nagalla > + > +description: | > + Some K3 family SoCs have Arm Cortex M4F cores. AM64x is a SoC in K3 > + family with a M4F core. Typically safety oriented applications may use > + the M4F core in isolation with out an IPC. Where as some Industrial and s/"with out"/without s/Industrial/industrial > + home automation applications, may use the M4F core as a remote processor > + with IPC communications. > + > +properties: > + $nodename: > + pattern: "^m4fss(@.*)?" > + > + compatible: > + enum: > + - ti,am64-m4fss > + > + power-domains: > + description: | > + Should contain a phandle to a PM domain provider node and an args > + specifier containing the M4FSS device id value. > + maxItems: 1 > + > + "#address-cells": > + const: 2 > + > + "#size-cells": > + const: 2 > + > + reg: > + items: > + - description: Address and Size of the IRAM internal memory region > + - description: Address and Size of the DRAM internal memory region > + > + reg-names: > + items: > + - const: iram > + - const: dram > + > + resets: > + description: | > + Should contain the phandle to the reset controller node managing the > + local resets for this device, and a reset specifier. > + maxItems: 1 > + > + firmware-name: > + description: | > + Should contain the name of the default firmware image > + file located on the firmware search path > + > + mboxes: > + description: | > + OMAP Mailbox specifier denoting the sub-mailbox, to be used for > + communication with the remote processor. This property should match > + with the sub-mailbox node used in the firmware image. > + maxItems: 1 > + > + memory-region: > + description: | > + phandle to the reserved memory nodes to be associated with the > + remoteproc device. There should be at least two reserved memory nodes > + defined. The reserved memory nodes should be carveout nodes, and > + should be defined with a "no-map" property as per the bindings in > + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > + minItems: 2 > + maxItems: 8 > +# items: > +# - description: region used for dynamic DMA allocations like vrings and > +# vring buffers > +# - description: region reserved for firmware image sections > + additionalItems: true > + > + unevaluatedProperties: false > + > + > +required: > + - compatible > + - power-domains There is no "power-domains" in the example below. > + - "#address-cells" > + - "#size-cells" > + - reg > + - reg-names > + - ti,sci > + - ti,sci-dev-id > + - ti,sci-proc-ids The above 3 are not described in this document. > + - resets > + - firmware-name > + > +additionalProperties: false > + > +examples: > + - | > + cbass_main: bus@f4000 { > + #address-cells = <2>; > + #size-cells = <2>; > + mcu_m4fss: m4fss@5000000 { > + compatible = "ti,am64-m4fss"; > + reg = <0x00 0x5000000 0x00 0x30000>, > + <0x00 0x5040000 0x00 0x10000>; > + reg-names = "iram", "dram"; > + ti,sci = <&dmsc>; > + ti,sci-dev-id = <9>; > + ti,sci-proc-ids = <0x18 0xff>; > + resets = <&k3_reset 9 1>; > + firmware-name = "am64-mcu-m4f0_0-fw"; > + mboxes = <&mailbox0_cluster6 &mbox_m4_0>; > + memory-region = <&mcu_m4fss_dma_memory_region>, > + <&mcu_m4fss_memory_region>; > + }; > + }; > + > +... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel