From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47046C433F5 for ; Mon, 31 Jan 2022 18:00:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75CBD81F6B; Mon, 31 Jan 2022 19:00:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AYfwmAvA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7DC2B831F8; Mon, 31 Jan 2022 19:00:10 +0100 (CET) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1291A80FDE for ; Mon, 31 Jan 2022 19:00:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id 71so12798684qkf.4 for ; Mon, 31 Jan 2022 10:00:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=d+DpiEN6ZE5W5Qo0RBiqikGaLWlh8MdcWP9Od/Gw45Q=; b=AYfwmAvA2Z/Dm3R7CPmRkw3kKbX1RuYCiE8j0AED+1jYvPeklHQQAny/u+cwjrk4/L D9goKjk8gQaGu/gQw1WNAJdTGYJc0x71KNhbunBXcJ2bvSd0AhWHdKp4YjxXwd6Zfa5F KXtjQ3g+PUM7IW2TFSKZMb1FdAnQRtjS7V6z8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=d+DpiEN6ZE5W5Qo0RBiqikGaLWlh8MdcWP9Od/Gw45Q=; b=viyQIYG5HcSZhU/Fv/DnXBOhsb7hwvCzvkjWXKusAIearFHviqHz+hhtR4Z8nxAYCZ Ui7wwV34r1I4yZDvEdO+h772+CTK7AC6PliCflD42GhLB/me3TwG8niyjimGcF6zux4M lF4UWe7c91MVSfRyXdRAYk9Ju2kQeGoXbOIP+ZXFwmLBSewPeoSsuaJRZOME/ctBCESU 0KdoNdA8DYW/O1J0cCprglWT9uFwNIPhyKx8IxXNgKuF1q5A6Vtx05uiE6BdxJyusOEV FzxKACKFYWKbDGFWGVPqKrAw9u1KXJOKqkOH615GiyhQwekCopvw8dtxQD72EgHeHLK2 5IDA== X-Gm-Message-State: AOAM530eCSHRg+r//ZQ1L0FUXNPycIG3sMX4dO+4vkFjbHj79DElJhg7 7CuW5CoG23uqXt1a+Y+eFW1VlA== X-Google-Smtp-Source: ABdhPJx7S9INHS4w9kvYBZLC3WITIxgEd654egqaT9I+uNj5WM1Je3ROYLf9pmtewNlKLpDsW3CvJA== X-Received: by 2002:a37:2c87:: with SMTP id s129mr14300491qkh.661.1643652004452; Mon, 31 Jan 2022 10:00:04 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id v14sm9314692qtk.5.2022.01.31.10.00.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 10:00:03 -0800 (PST) Date: Mon, 31 Jan 2022 13:00:01 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Marek =?iso-8859-1?Q?Beh=FAn?= , Masahiro Yamada Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR Message-ID: <20220131180001.GC7515@bill-the-cat> References: <20220130155225.726890-1-sjg@chromium.org> <20220130155225.726890-2-sjg@chromium.org> <20220131142412.GH7515@bill-the-cat> <20220131161544.GZ7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1UHwWMNIfNKl+QsP" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --1UHwWMNIfNKl+QsP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 31 Jan 2022 at 09:15, Tom Rini wrote: > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass wrote: > > > > > > > > > More than a year after this migration message appeared, we still = have new > > > > > boards being added with this option. Add a check against this. > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > Please just make this an error in checkpatch.pl instead. > > > > > > I couldn't think of a way of doing that...do you have an idea? > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabling of fdt > > and initrd relocation") updates the check I had for fdt_high/initrd_high > > being in the file at all to only be for additions. And yes, I check > > every PR for new checkpatch ERROR lines and only ignore the ones for > > code imported from other projects. >=20 > Yes, I understand that, but SPL_FIT_GENERATOR defaults to on for > certain boards, so there is no need to mention it anywhere in the > patch. Also someone could adjust the condition in the Kconfig to add > other boards. Then you want something a bit more like the fdt|initrd_high check now, along with updating the help around SPL_FIT_GENERATOR to note that this option is deprecated, is the path forward then I think. --=20 Tom --1UHwWMNIfNKl+QsP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4I54ACgkQFHw5/5Y0 tyxjWAv+OnKztoSc1jwAD2eL3MCfERI0dUZikYuOpnvbbxuWmC5Ib12ePXToZ87g 7mpGFg088WYPmDgSLoZSUbh6DwqkTJDtSWH76XCpVjzf5GDaw4ORBfkjKT0663bG MnmlWawiERv9yVyXn+X2STCIUg1aLc6YAeXOF0FptSeYBl2XNbqDim0WtdEv3BS7 XZWodokFG2Fr3ssSiKCyTYatJinj6m24X8i/KSPAIkH/n9JmxGm/h/c66iK4qfxi IwXXbLChFt8GfBzf1gd/TxFF77GqfqWdfyEzGcDqAhZFXscJo9efbYNJbmSQ6WO5 q8nx4tw1wDUn9OBtR7xH+gzopwerswzwnXf2gmTKir1/vdgxqjmMOyZa5KBZKDkz 6SABMndmsA9E4yzjJKH3wY0b2tsu6aQzt+M3bGfRN7KEvR1XIALpBPZ1ZqXqnWWz +y60FfMuaaUJ/Dw0QbaTQcHMCRoTR6og9hdRyeYNRVl0+9pBDv+9qh8aH3iX0GLz fugxc6bi =FmXU -----END PGP SIGNATURE----- --1UHwWMNIfNKl+QsP--