From: Kelvin Zhang via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: linux-erofs mailing list <linux-erofs@lists.ozlabs.org>,
Miao Xie <miaoxie@huawei.com>, Fang Wei <fangwei1@huawei.com>
Cc: Kelvin Zhang <zhangkelvin@google.com>
Subject: [PATCH v1] erofs-utils: don't hard code constants
Date: Mon, 31 Jan 2022 10:43:27 -0800 [thread overview]
Message-ID: <20220131184327.30176-1-zhangkelvin@google.com> (raw)
Use sizeof(z_erofs_vle_decompressed_index) to compute legacy index count
Test: th
Signed-off-by: Kelvin Zhang <zhangkelvin@google.com>
---
lib/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/compress.c b/lib/compress.c
index 98be7a2..c520a1e 100644
--- a/lib/compress.c
+++ b/lib/compress.c
@@ -359,7 +359,7 @@ int z_erofs_convert_to_compacted_format(struct erofs_inode *inode,
inode->xattr_isize) +
sizeof(struct z_erofs_map_header);
const unsigned int totalidx = (legacymetasize -
- Z_EROFS_LEGACY_MAP_HEADER_SIZE) / 8;
+ Z_EROFS_LEGACY_MAP_HEADER_SIZE) / sizeof(struct z_erofs_vle_decompressed_index);
const unsigned int logical_clusterbits = inode->z_logical_clusterbits;
u8 *out, *in;
struct z_erofs_compressindex_vec cv[16];
--
2.35.0.rc2.247.g8bbb082509-goog
next reply other threads:[~2022-01-31 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 18:43 Kelvin Zhang via Linux-erofs [this message]
2022-02-01 2:51 ` [PATCH v1] erofs-utils: don't hard code constants Gao Xiang
2022-02-01 22:44 ` Kelvin Zhang via Linux-erofs
2022-02-02 2:19 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131184327.30176-1-zhangkelvin@google.com \
--to=linux-erofs@lists.ozlabs.org \
--cc=fangwei1@huawei.com \
--cc=miaoxie@huawei.com \
--cc=zhangkelvin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.