From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28A5EC433F5 for ; Mon, 31 Jan 2022 20:40:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E088E81DE9; Mon, 31 Jan 2022 21:40:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RvuIiIuU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E7E681DE9; Mon, 31 Jan 2022 21:40:46 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9B00680FDE for ; Mon, 31 Jan 2022 21:40:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id g13so14014427qvw.4 for ; Mon, 31 Jan 2022 12:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oRAKPtH59JrGq/F58HFwKm9aMdhQryLZ9BqHuJs7U48=; b=RvuIiIuUJdCpNtAJqLMztE5QEdYRu5tVIdGHUJc/gTxjq16g6JpBcA6fRrG1fWmCI1 6nT1M+qK6vfH0LnNK4jJBCaQIcBh6/X9MAK8KuleiSjGEBtaBJo0lt3ww3cdNPBexacU 4qlCogeYiosrFaHPmxU7LgMyRKJH6KP8N5Kxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oRAKPtH59JrGq/F58HFwKm9aMdhQryLZ9BqHuJs7U48=; b=WSZ8k97yrKMPsV41V2bUewJpgWJ9DjyUf85Rsg5reDPoekuhcK4XaoraxVVfrlf/EC H9/E7bn7z+bxMmgYtu99FwzKWqZHtvXyqdOk0ljYbvtQcpDLKZfoOS5KN1wuzodd4ikf FTo5+nClgaGuruRfzTX3CYAANy0Jmqo3xFGkaLGCh1IVxlDnuTsztAch0bl5mYcV/URZ Fp5AFHkrAoj1W38ZAPKjzAtoInK1kjRYHF9ysCrYkhN44iAxABRyazKQjKIPooF0XHQ6 gyxwWbAG3dS1hTbMGwaUHn97QwV6zPX6qI/fiSePqoj7LFRF8KAIPpi1Pqb08DJ97E8L xtZA== X-Gm-Message-State: AOAM532OYnMywj06pja2JWN0YvvcmlbMk3xZOCjHluRlKJAtP5S0TbQk nmnMZ1zmdAc7uNTkM2u96dkSFQ== X-Google-Smtp-Source: ABdhPJwWyNGC28DwE34ZipjbXB7ayJowxx1zkBv5gPbvMuEKnaAspk5EpaJe5YOZmQBxiFzfcn2sEA== X-Received: by 2002:ad4:4ee7:: with SMTP id dv7mr19485218qvb.65.1643661642287; Mon, 31 Jan 2022 12:40:42 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id p9sm5121587qtw.43.2022.01.31.12.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 12:40:41 -0800 (PST) Date: Mon, 31 Jan 2022 15:40:39 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Michal Simek , huang lin , Jeffy Chen , Kever Yang , Philipp Tomsich , "NXP i . MX U-Boot Team" , Marek =?iso-8859-1?Q?Beh=FAn?= , Masahiro Yamada Subject: Re: [PATCH v2 2/2] Makefile: Don't allow new boards with SPL_FIT_GENERATOR Message-ID: <20220131204039.GG7515@bill-the-cat> References: <20220130155225.726890-1-sjg@chromium.org> <20220130155225.726890-2-sjg@chromium.org> <20220131142412.GH7515@bill-the-cat> <20220131161544.GZ7515@bill-the-cat> <20220131180001.GC7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="y/C4Z0ZQWa14ewtO" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --y/C4Z0ZQWa14ewtO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 31, 2022 at 12:57:57PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 31 Jan 2022 at 11:00, Tom Rini wrote: > > > > On Mon, Jan 31, 2022 at 10:27:41AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jan 2022 at 09:15, Tom Rini wrote: > > > > > > > > On Mon, Jan 31, 2022 at 09:13:02AM -0700, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Mon, 31 Jan 2022 at 07:24, Tom Rini wrote: > > > > > > > > > > > > On Sun, Jan 30, 2022 at 08:52:25AM -0700, Simon Glass wrote: > > > > > > > > > > > > > More than a year after this migration message appeared, we st= ill have new > > > > > > > boards being added with this option. Add a check against this. > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > > > > > > > Please just make this an error in checkpatch.pl instead. > > > > > > > > > > I couldn't think of a way of doing that...do you have an idea? > > > > > > > > Yes, 2f3e8d6a86cb ("checkpatch: report ERROR only on disabling of f= dt > > > > and initrd relocation") updates the check I had for fdt_high/initrd= _high > > > > being in the file at all to only be for additions. And yes, I check > > > > every PR for new checkpatch ERROR lines and only ignore the ones for > > > > code imported from other projects. > > > > > > Yes, I understand that, but SPL_FIT_GENERATOR defaults to on for > > > certain boards, so there is no need to mention it anywhere in the > > > patch. Also someone could adjust the condition in the Kconfig to add > > > other boards. > > > > Then you want something a bit more like the fdt|initrd_high check now, > > along with updating the help around SPL_FIT_GENERATOR to note that this > > option is deprecated, is the path forward then I think. >=20 > I'm still a bit lost. >=20 > What I want: break the build if someone adds a new board that uses > SPL_FIT_GENERATOR >=20 > What you are offering: checkpatch check for people adding that option >=20 > But the patch doesn't generally include that option. >=20 > I can certainly mention in the Kconfig help that the option is > deprecated, but without checking if it is defined for a NEW board, I > cannot prevent it from growing. >=20 > What am I missing? Can you be more specific? How do you add a new board that enables SPL_FIT_GENERATOR without "SPL_FIT_GENERATOR" being in the resulting patch, other than being ARCH_ZYNQMP/ARCH_ROCKCHIP ? --=20 Tom --y/C4Z0ZQWa14ewtO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmH4SUQACgkQFHw5/5Y0 tyzrnAv7BoRsUIsZmTm0f3ATtQcuS+F8DH3I9fjbliESwTTQacArFtHZhD9INzO4 jpVK3i41DjywbXyWUEjmrZzAGtlQYWNen6RGfDl0OnHAhXhoFCKZoZcXF6QIKO9I fgP1OqpEdA4sib1ZXJHBGjm4qKVwvNVOWIxHhVOyHMEfSj+v1sOVAmNYlUXJcaHg wp/f/7FxPf/lwBte8DL/KoY2x98Ei/qYeH8ey8cv/gjtf2WT3krjo/Pf/HxfVItW haeLzL6c4QfPNELBnR6pZ0VV4qeXorioYJiyuR7XhD2u4PKYtHAvvKblEAc2gYdO 5e8P7Sip4VWkra3GJc5Kz0C5aaeYCZGMXtPDWLCrcIzRpGIpaauGXoDR6dZF6n7e SbGp2bW1rUeAW1w50mhDE0jEHeeDHMzTu4hhdrL1wogNRn4D53zBG+5PgLLOlcW6 MohZ+qMimjSmmkxgl3txqJP4aYKGVG1MirmWKCcOgfS9Tqz6J+CaIKpCa0+wHibW 5Ar5uamo =5pOk -----END PGP SIGNATURE----- --y/C4Z0ZQWa14ewtO--