From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8866411895626732230==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Tue, 01 Feb 2022 05:54:19 +0800 Message-ID: <20220131215419.GA87685@a436543d8a13> In-Reply-To: <202202010548.Fq56IWo0-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============8866411895626732230== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Felipe Balbi CC: "Greg Kroah-Hartman" CC: linux-usb(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/usb/phy/phy-generic.c:300:8-33: WARNING: Threaded IRQ with no prima= ry handler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 26291c54e111ff6ba87a164d85d4a4e134b7315c commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 32 hours ago :::::: commit date: 9 months ago Please take the patch only if it's a positive warning. Thanks! phy-generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/usb/phy/phy-generic.c +++ b/drivers/usb/phy/phy-generic.c @@ -300,7 +300,8 @@ static int usb_phy_generic_probe(struct err =3D devm_request_threaded_irq(&pdev->dev, gpiod_to_irq(nop->gpiod_vbus), NULL, nop_gpio_vbus_thread, - VBUS_IRQ_FLAGS, "vbus_detect", + VBUS_IRQ_FLAGS | IRQF_ONESHOT, + "vbus_detect", nop); if (err) { dev_err(&pdev->dev, "can't request irq %i, err: %d\n", --===============8866411895626732230==--