From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings
Date: Tue, 01 Feb 2022 05:54:45 +0800 [thread overview]
Message-ID: <20220131215445.GA750@a436543d8a13> (raw)
In-Reply-To: <202202010548.Fq56IWo0-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1744 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Krzysztof Kozlowski <krzk@kernel.org>
CC: Julia Lawall <Julia.Lawall@inria.fr>
CC: Lee Jones <lee.jones@linaro.org>
CC: patches(a)opensource.cirrus.com
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/mfd/wm8994-irq.c:232:8-28: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ)
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
CC: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 26291c54e111ff6ba87a164d85d4a4e134b7315c
commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: reduce the severity due to false positives
:::::: branch date: 32 hours ago
:::::: commit date: 9 months ago
Please take the patch only if it's a positive warning. Thanks!
wm8994-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mfd/wm8994-irq.c
+++ b/drivers/mfd/wm8994-irq.c
@@ -231,7 +231,7 @@ int wm8994_irq_init(struct wm8994 *wm899
ret = request_threaded_irq(wm8994->irq,
NULL, wm8994_edge_irq,
- irqflags,
+ irqflags | IRQF_ONESHOT,
"WM8994 edge", wm8994);
} else {
ret = regmap_add_irq_chip(wm8994->regmap, wm8994->irq,
next prev parent reply other threads:[~2022-01-31 21:54 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 23:31 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-31 21:54 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-31 21:54 ` kernel test robot
2022-01-31 21:54 ` kernel test robot
2022-01-31 21:54 ` kernel test robot
2022-01-31 21:54 ` kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-26 4:16 drivers/usb/phy/phy-generic.c:300:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-04-26 4:12 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-04-23 15:37 drivers/mfd/arizona-irq.c:374:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-04-23 15:31 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-04-23 15:31 ` kernel test robot
2022-04-23 15:31 ` kernel test robot
2022-04-23 15:31 ` kernel test robot
2022-03-15 4:59 drivers/gpu/drm/i2c/tda998x_drv.c:1916:8-28: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-03-15 4:51 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-02-04 11:52 drivers/mfd/arizona-irq.c:374:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-02-04 11:48 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-02-04 11:48 ` kernel test robot
2022-02-02 10:26 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-02-02 10:18 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-02-02 10:18 ` kernel test robot
2022-02-02 10:18 ` kernel test robot
2022-02-02 10:19 ` kernel test robot
2022-02-02 10:19 ` kernel test robot
2022-01-28 21:55 drivers/input/misc/ad714x.c:1153:9-34: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-28 21:51 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-28 21:51 ` kernel test robot
2022-01-28 21:51 ` kernel test robot
2022-01-28 21:03 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-28 19:28 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-28 19:28 ` kernel test robot
2022-01-28 19:28 ` kernel test robot
2022-01-28 19:28 ` kernel test robot
2022-01-28 19:28 ` kernel test robot
2022-01-28 21:03 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-28 17:59 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-28 17:59 ` kernel test robot
2022-01-28 17:59 ` kernel test robot
2022-01-28 17:59 ` kernel test robot
2022-01-28 17:59 ` kernel test robot
2022-01-26 12:45 drivers/rtc/rtc-lp8788.c:277:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-26 12:42 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-25 13:10 drivers/staging/wfx/bus_sdio.c:133:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-25 13:03 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-25 13:03 ` kernel test robot
2022-01-25 13:03 ` kernel test robot
2022-01-23 8:51 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-23 8:48 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-23 8:48 ` kernel test robot
2022-01-23 8:48 ` kernel test robot
2022-01-23 8:48 ` kernel test robot
2022-01-23 8:48 ` kernel test robot
2022-01-23 0:55 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-23 0:54 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-23 0:54 ` kernel test robot
2022-01-23 0:54 ` kernel test robot
2022-01-23 0:54 ` kernel test robot
2022-01-23 0:55 ` kernel test robot
2022-01-19 21:24 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-19 21:16 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-19 21:16 ` kernel test robot
2022-01-19 21:16 ` kernel test robot
2022-01-19 21:16 ` kernel test robot
2022-01-19 21:16 ` kernel test robot
2022-01-16 11:42 drivers/mfd/arizona-irq.c:374:7-27: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2022-01-16 11:34 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2022-01-16 11:34 ` kernel test robot
2022-01-16 11:34 ` kernel test robot
2022-01-16 11:35 ` kernel test robot
2022-01-16 11:35 ` kernel test robot
2022-01-16 11:35 ` kernel test robot
2021-12-17 4:00 kernel test robot
2021-12-12 6:06 kernel test robot
2021-12-12 6:05 kernel test robot
2021-12-12 6:05 kernel test robot
2021-12-12 5:34 kernel test robot
2021-12-12 5:34 kernel test robot
2021-12-12 5:34 kernel test robot
2021-12-12 5:14 kernel test robot
2021-12-12 5:13 kernel test robot
2021-12-11 18:17 kernel test robot
2021-12-11 18:17 kernel test robot
2021-12-11 18:16 kernel test robot
2021-12-11 18:16 kernel test robot
2021-12-11 0:18 kernel test robot
2021-11-12 13:26 drivers/extcon/extcon-max8997.c:665:8-28: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-11-12 13:26 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2021-11-12 13:26 ` kernel test robot
2021-11-12 13:27 ` kernel test robot
2021-11-08 17:44 drivers/extcon/extcon-max77693.c:1143:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-11-08 17:44 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2021-09-04 13:22 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-09-04 13:22 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2021-09-04 13:22 ` kernel test robot
2021-09-04 13:22 ` kernel test robot
2021-09-04 13:22 ` kernel test robot
2021-09-03 18:54 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-09-03 18:54 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2021-09-03 18:54 ` kernel test robot
2021-09-03 18:54 ` kernel test robot
2021-09-03 18:54 ` kernel test robot
2021-09-03 1:30 drivers/input/touchscreen/cyttsp4_core.c:2093:6-26: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-09-03 1:30 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2021-09-03 1:30 ` kernel test robot
2021-09-03 1:31 ` kernel test robot
2021-09-03 1:31 ` kernel test robot
2021-08-21 10:22 drivers/mfd/htc-i2cpld.c:546:8-28: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-08-21 10:22 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
2021-08-14 15:46 drivers/power/supply/max17042_battery.c:1116:8-33: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) kernel test robot
2021-08-14 15:46 ` [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131215445.GA750@a436543d8a13 \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.