All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Adam Borowski <kilobyte@angband.pl>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: subv del: hide a bogus warning on an unprivileged delete
Date: Tue, 1 Feb 2022 18:19:38 +0100	[thread overview]
Message-ID: <20220201171938.GW14046@twin.jikos.cz> (raw)
In-Reply-To: <20220124133632.62597-1-kilobyte@angband.pl>

On Mon, Jan 24, 2022 at 02:36:32PM +0100, Adam Borowski wrote:
> Checking the default subvolume uses TREE_SEARCH which is a CAP_SYS_ADMIN
> only operation, and thus will fail when unprivileged, even if we have
> permissions to actually delete the subvolume.
> 
> This produces a warning even if all is ok.  Let's hide it if we're not
> root (root but !CAP is odd enough to warn).
> 
> Fixes 87804a3f0663a4d1891395bd97b8e81e6f183e66
> Ref: https://bugs.debian.org/998840
> Signed-off-by: Adam Borowski <kilobyte@angband.pl>

Thanks, added to devel, that covers the part when the search fails. It
could also fail when the default subvolume is not set so I might add a
separate check for that.

      reply	other threads:[~2022-02-01 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 13:36 [PATCH] btrfs-progs: subv del: hide a bogus warning on an unprivileged delete Adam Borowski
2022-02-01 17:19 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201171938.GW14046@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=kilobyte@angband.pl \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.