From: Steven Rostedt <rostedt@goodmis.org>
To: Linux Trace Devel <linux-trace-devel@vger.kernel.org>
Subject: [PATCH] libtracefs: Have echo command concatenate
Date: Tue, 1 Feb 2022 17:29:17 -0500 [thread overview]
Message-ID: <20220201172917.580b9a4f@gandalf.local.home> (raw)
From: "Steven Rostedt (Google)" <rostedt@goodmis.org>
Currently, tracefs_synth_echo_cmd() does a truncate of the file with the
'>'. This can cause issues if the current files have something already in
it, and could even error with EBUSY if the items can not be deleted.
Use the safer concatenate '>>' instead.
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
src/tracefs-hist.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/tracefs-hist.c b/src/tracefs-hist.c
index e7dd279ae3f9..aec61ad52e72 100644
--- a/src/tracefs-hist.c
+++ b/src/tracefs-hist.c
@@ -2196,7 +2196,7 @@ int tracefs_synth_echo_cmd(struct trace_seq *seq,
if (!path)
goto out_free;
- trace_seq_printf(seq, "echo '%s%s%s %s' > %s/%s\n",
+ trace_seq_printf(seq, "echo '%s%s%s %s' >> %s/%s\n",
synth->dyn_event->prefix,
strlen(synth->dyn_event->prefix) ? ":" : "",
synth->dyn_event->event,
@@ -2211,7 +2211,7 @@ int tracefs_synth_echo_cmd(struct trace_seq *seq,
if (!hist)
goto out_free;
- trace_seq_printf(seq, "echo '%s' > %s/events/%s/%s/trigger\n",
+ trace_seq_printf(seq, "echo '%s' >> %s/events/%s/%s/trigger\n",
hist, path, synth->start_event->system,
synth->start_event->name);
free(hist);
@@ -2221,7 +2221,7 @@ int tracefs_synth_echo_cmd(struct trace_seq *seq,
if (!hist)
goto out_free;
- trace_seq_printf(seq, "echo '%s' > %s/events/%s/%s/trigger\n",
+ trace_seq_printf(seq, "echo '%s' >> %s/events/%s/%s/trigger\n",
hist, path, synth->end_event->system,
synth->end_event->name);
--
2.33.0
reply other threads:[~2022-02-01 22:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220201172917.580b9a4f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-trace-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.