From: Antoine Tenart <atenart@kernel.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: Antoine Tenart <atenart@kernel.org>,
netdev@vger.kernel.org, vladbu@nvidia.com, pabeni@redhat.com,
pshelar@ovn.org
Subject: [PATCH net 0/2] net: fix issues when uncloning an skb dst+metadata
Date: Wed, 2 Feb 2022 12:01:35 +0100 [thread overview]
Message-ID: <20220202110137.470850-1-atenart@kernel.org> (raw)
Hi,
This fixes two issues when uncloning an skb dst+metadata in
tun_dst_unclone; this was initially reported by Vlad Buslov[1]. Because
of the memory leak fixed by patch 2, the issue in patch 1 never happened
in practice.
tun_dst_unclone is called from two different places, one in geneve/vxlan
to handle PMTU and one in net/openvswitch/actions.c where it is used to
retrieve tunnel information. While both Vlad and I tested the former, we
could not for the latter. I did spend quite some time trying to, but
that code path is not easy to trigger. Code inspection shows this should
be fine, the tunnel information (dst+metadata) is uncloned and the skb
it is referenced from is only consumed after all accesses to the tunnel
information are done:
do_execute_actions
output_userspace
dev_fill_metadata_dst <- dst+metadata is uncloned
ovs_dp_upcall
queue_userspace_packet
ovs_nla_put_tunnel_info <- metadata (tunnel info) is accessed
consume_skb <- dst+metadata is freed
Thanks!
Antoine
[1] https://lore.kernel.org/all/ygnhh79yluw2.fsf@nvidia.com/T/#m2f814614a4f5424cea66bbff7297f692b59b69a0
Antoine Tenart (2):
net: do not keep the dst cache when uncloning an skb dst and its
metadata
net: fix a memleak when uncloning an skb dst and its metadata
include/net/dst_metadata.h | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
--
2.34.1
next reply other threads:[~2022-02-02 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 11:01 Antoine Tenart [this message]
2022-02-02 11:01 ` [PATCH net 1/2] net: do not keep the dst cache when uncloning an skb dst and its metadata Antoine Tenart
2022-02-02 11:17 ` Antoine Tenart
2022-02-02 12:13 ` Daniel Borkmann
2022-02-02 13:44 ` Antoine Tenart
2022-02-04 12:33 ` Daniel Borkmann
2022-02-04 16:19 ` Antoine Tenart
2022-02-02 14:24 ` Paolo Abeni
2022-02-02 14:29 ` Antoine Tenart
2022-02-02 11:01 ` [PATCH net 2/2] net: fix a memleak " Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220202110137.470850-1-atenart@kernel.org \
--to=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.