Re: [PATCH RFC bpf-next v2 4/5] bpf: Pin cgroup_view

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4249 bytes --]

Hi Hao,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Hao-Luo/Extend-cgroup-interface-with-bpf/20220202-045743
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20220202/202202021257.qiKh7nky-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5ecb726d4b2336b6c49a58f013fe270f2c3dfdd1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Hao-Luo/Extend-cgroup-interface-with-bpf/20220202-045743
        git checkout 5ecb726d4b2336b6c49a58f013fe270f2c3dfdd1
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/bpf/inode.c: In function 'bpf_inherit_object':
>> kernel/bpf/inode.c:638:32: error: 'cgrp_dfl_root' undeclared (first use in this function)
     638 |                 tag->private = cgrp_dfl_root.kf_root->kn;
         |                                ^~~~~~~~~~~~~
   kernel/bpf/inode.c:638:32: note: each undeclared identifier is reported only once for each function it appears in


vim +/cgrp_dfl_root +638 kernel/bpf/inode.c

   600	
   601	/* bpf_inherit_object - register an object in a diretory tag's inherit list
   602	 * @dentry: dentry of the location to pin
   603	 * @mode: mode of created file entry
   604	 * @obj: bpf object
   605	 * @type: type of bpf object
   606	 *
   607	 * Could be called from bpf_obj_do_pin() or from mkdir().
   608	 */
   609	static int bpf_inherit_object(struct dentry *dentry, umode_t mode,
   610				      void *obj, enum bpf_type type)
   611	{
   612		struct inode *dir = d_inode(dentry->d_parent);
   613		struct obj_list *inherits;
   614		struct bpf_inherit_entry *e;
   615		struct bpf_dir_tag *tag;
   616		const char *name;
   617		bool queued = false, new_tag = false;
   618	
   619		/* allocate bpf_dir_tag */
   620		tag = inode_tag(dir);
   621		if (!tag) {
   622			new_tag = true;
   623			tag = kzalloc(sizeof(struct bpf_dir_tag), GFP_KERNEL);
   624			if (unlikely(!tag))
   625				return -ENOMEM;
   626	
   627			tag->type = BPF_DIR_KERNFS_REP;
   628			inherits = kzalloc(sizeof(struct obj_list), GFP_KERNEL);
   629			if (unlikely(!inherits)) {
   630				kfree(tag);
   631				return -ENOMEM;
   632			}
   633	
   634			kref_init(&inherits->refcnt);
   635			INIT_LIST_HEAD(&inherits->list);
   636			tag->inherit_objects = inherits;
   637			/* initial tag points to the default root cgroup. */
 > 638			tag->private = cgrp_dfl_root.kf_root->kn;
   639			dir->i_private = tag;
   640		} else {
   641			inherits = tag->inherit_objects;
   642		}
   643	
   644		list_for_each_entry_rcu(e, &inherits->list, list) {
   645			if (!strcmp(dentry->d_name.name, e->name.name)) {
   646				queued = true;
   647				break;
   648			}
   649		}
   650	
   651		/* queue in tag's inherit_list. */
   652		if (!queued) {
   653			e = kzalloc(sizeof(struct bpf_inherit_entry), GFP_KERNEL);
   654			if (!e) {
   655				if (new_tag) {
   656					kfree(tag);
   657					kfree(inherits);
   658				}
   659				return -ENOMEM;
   660			}
   661	
   662			INIT_LIST_HEAD(&e->list);
   663			e->mode = mode;
   664			e->obj = obj;
   665			e->type = type;
   666			name = kstrdup(dentry->d_name.name, GFP_USER | __GFP_NOWARN);
   667			e->name = (struct qstr)QSTR_INIT(name, strlen(name));
   668			list_add_rcu(&e->list, &inherits->list);
   669		}
   670		return 0;
   671	}
   672	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org