From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B721C4332F for ; Thu, 3 Feb 2022 20:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238078AbiBCULQ (ORCPT ); Thu, 3 Feb 2022 15:11:16 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:54350 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231693AbiBCULQ (ORCPT ); Thu, 3 Feb 2022 15:11:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC127619EB; Thu, 3 Feb 2022 20:11:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F600C340E8; Thu, 3 Feb 2022 20:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643919075; bh=4BSXxY3IonSFV0/jTnsSKEp9cBSpVvVKAZx5Z73OKBs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a1sA23OOTGBzQUsW0WgiQ1AgpsibE0HLS/PRC17y19bQAlaqYDCzSp8gHd/CCb/D6 nX0UBLUb9gsYhH7R/b5IMiCzWNsapQCa2rVGJtWNVtojtGetuRJo/PHomVV1S8tV2K h+aOdjUh9/3aprBno5KlhAn9F0HYgBxtCjPFP9vVllDAesYm+asCe4WhOq1YPDRzkW HD1GNrEQ5qlNdJUlNdQc4KVj4wDO2d0+g5rbQQC3TURttI83Z5bTUIDGO99lQEog/9 8dPLuF5/MxdZhpFyDKG3uqSlCmSm1WEblCRut/gyqaLZdp8t63tzKxnmubDgkc01yv REvLg1kFMBKiA== Date: Thu, 3 Feb 2022 12:11:12 -0800 From: Keith Busch To: Mikulas Patocka Cc: Bart Van Assche , "linux-block@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "dm-devel@redhat.com" , "linux-nvme@lists.infradead.org" , linux-fsdevel Subject: Re: [RFC PATCH 1/3] block: add copy offload support Message-ID: <20220203201112.GC142129@dhcp-10-100-145-180.wdc.com> References: <20220201102122.4okwj2gipjbvuyux@mpHalley-2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Feb 03, 2022 at 01:50:06PM -0500, Mikulas Patocka wrote: > On Tue, 1 Feb 2022, Bart Van Assche wrote: > > Only supporting copying between contiguous LBA ranges seems restrictive to me. > > I expect garbage collection by filesystems for UFS devices to perform better > > if multiple LBA ranges are submitted as a single SCSI XCOPY command. > > NVMe has a possibility to copy multiple source ranges into one destination > range. But I think that leveraging this capability would just make the > code excessively complex. The point is to defrag discontiguous blocks into a single range. The capability loses a major value proposition without multiple sources. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E84EC433F5 for ; Fri, 4 Feb 2022 09:42:10 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-475-s55x7U_bMLaQDNdTPwAJAg-1; Fri, 04 Feb 2022 04:42:06 -0500 X-MC-Unique: s55x7U_bMLaQDNdTPwAJAg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 22D9E1091DA3; Fri, 4 Feb 2022 09:42:02 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 04F411F30C; Fri, 4 Feb 2022 09:42:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D0E621802E34; Fri, 4 Feb 2022 09:42:01 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 213KICUk012290 for ; Thu, 3 Feb 2022 15:18:12 -0500 Received: by smtp.corp.redhat.com (Postfix) id 0D95D2024CB9; Thu, 3 Feb 2022 20:18:12 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05F0B2024CB8 for ; Thu, 3 Feb 2022 20:18:08 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB0241044564 for ; Thu, 3 Feb 2022 20:18:08 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171-LxIYMaocM5qsMc7xmnPOXw-1; Thu, 03 Feb 2022 15:18:07 -0500 X-MC-Unique: LxIYMaocM5qsMc7xmnPOXw-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id AF81ECE2114; Thu, 3 Feb 2022 20:11:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F600C340E8; Thu, 3 Feb 2022 20:11:14 +0000 (UTC) Date: Thu, 3 Feb 2022 12:11:12 -0800 From: Keith Busch To: Mikulas Patocka Message-ID: <20220203201112.GC142129@dhcp-10-100-145-180.wdc.com> References: <20220201102122.4okwj2gipjbvuyux@mpHalley-2> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Fri, 04 Feb 2022 04:41:43 -0500 Cc: Bart Van Assche , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , linux-fsdevel Subject: Re: [dm-devel] [RFC PATCH 1/3] block: add copy offload support X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Feb 03, 2022 at 01:50:06PM -0500, Mikulas Patocka wrote: > On Tue, 1 Feb 2022, Bart Van Assche wrote: > > Only supporting copying between contiguous LBA ranges seems restrictive to me. > > I expect garbage collection by filesystems for UFS devices to perform better > > if multiple LBA ranges are submitted as a single SCSI XCOPY command. > > NVMe has a possibility to copy multiple source ranges into one destination > range. But I think that leveraging this capability would just make the > code excessively complex. The point is to defrag discontiguous blocks into a single range. The capability loses a major value proposition without multiple sources. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel