From: Tom Rini <trini@konsulko.com>
To: "Pali Rohár" <pali@kernel.org>, "Simon Glass" <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD
Date: Thu, 3 Feb 2022 16:53:07 -0500 [thread overview]
Message-ID: <20220203215307.GB7515@bill-the-cat> (raw)
In-Reply-To: <20220203214544.GA7515@bill-the-cat>
[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]
On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote:
> On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote:
> > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Rohár wrote:
> >
> > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > ---
> > >
> > > I would really appreciate if U-Boot test framework starts printing
> > > deprecation warnings, instead of sending patches which directly drop
> > > support for some boards.
> > >
> > > There is absolutely no warning during building U-Boot for RX-51 board
> > > that this board has not been converted to DM_KEYBOARD yet.
> >
> > Please send some patch that implements what you're wanting to see for
> > how to make the warnings more visible. I do agree the warning for
> > v2022.10 only showed up after the merge to -next once v2022.01 came out,
> > but it's still a fairly long time to clean up the few unconverted
> > boards.
>
> Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't
> triggering for any boards. I'll look more.
And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD, so
didn't trigger the warning about migration. Every platform that sets
CONFIG_KEYBOARD is migrated. I don't know how many other platforms are
in the situation nokia_rx51 is in. Yanking out the legacy code and
seeing what fails to build, and going from there is probably the next
option.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-02-03 21:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 18:38 [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD Pali Rohár
2022-02-03 21:16 ` Tom Rini
2022-02-03 21:45 ` Tom Rini
2022-02-03 21:53 ` Tom Rini [this message]
2022-02-03 22:02 ` Simon Glass
2022-02-03 22:03 ` Simon Glass
2022-02-03 22:09 ` Tom Rini
2022-02-03 22:10 ` Simon Glass
2022-02-04 10:59 ` Pali Rohár
2022-02-04 10:56 ` Pali Rohár
2022-02-04 13:41 ` Tom Rini
2022-02-04 13:55 ` Pali Rohár
2022-02-04 14:00 ` Tom Rini
2022-02-04 14:13 ` Pali Rohár
2022-02-04 15:24 ` Simon Glass
2022-02-04 15:30 ` Pali Rohár
2022-02-04 15:37 ` Tom Rini
2022-02-04 15:41 ` Simon Glass
2022-02-04 15:46 ` Pali Rohár
2022-02-04 15:54 ` Simon Glass
2022-02-04 16:00 ` Pali Rohár
2022-02-04 10:51 ` Pali Rohár
2022-02-08 17:36 ` Tom Rini
2022-02-09 0:07 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203215307.GB7515@bill-the-cat \
--to=trini@konsulko.com \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.