From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tong Zhang <ztong0001@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Paul Bolle <pebolle@tiscali.nl>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
insop.song@gainspeed.com, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code
Date: Fri, 4 Feb 2022 11:51:45 +0300 [thread overview]
Message-ID: <20220204085145.GX1951@kadam> (raw)
In-Reply-To: <20220204054028.3123858-1-ztong0001@gmail.com>
On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote:
> gs_fpgaboot is currently useless since the board specific code is
> removed in 06a3fab941da. Loading the driver will always fail since
> xl_init_io() always returns -1. This driver is broken since 2014 and I
> doubt anyone is actually using it, we could either remove it or revert
> to the previous working version.
>
> $ modprobe gs_fpga
> GPIO INIT FAIL!!
>
> This patch reverts previously removed code and adds a Kconfig to make
> this board selectable for PPC_85xx processors.
>
> Fixes: 06a3fab941da ("staging: gs_fpgaboot: remove checks for CONFIG_B4860G100")
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
The Fixes tag is not really accurate. The code has never worked. It
should be:
Fixes: e7185c6958ee ("staging: fpgaboot: Xilinx FPGA firmware download driver")
I assume you don't really have this hardware and you're just modprobing
drivers to as part of testing? If you have this hardware then we can
preserve it. Otherwise we should just delete the whole driver. It's
been 8 years and no one has noticed that it doesn't probe.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-04 9:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 5:40 [PATCH] staging: gs_fpgaboot: revert removed board specific code Tong Zhang
2022-02-04 8:51 ` Dan Carpenter [this message]
2022-02-04 14:23 ` Greg Kroah-Hartman
2022-02-04 18:36 ` Tong Zhang
2022-02-04 19:08 ` [PATCH] staging: drop fpgaboot driver Tong Zhang
2022-02-08 9:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220204085145.GX1951@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=insop.song@gainspeed.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=pebolle@tiscali.nl \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.