From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BCF3C433F5 for ; Fri, 4 Feb 2022 11:00:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1BA2283A5E; Fri, 4 Feb 2022 12:00:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="emoq1Gdm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3E52183A57; Fri, 4 Feb 2022 12:00:10 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1850583A5E for ; Fri, 4 Feb 2022 12:00:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 875C6B8370C; Fri, 4 Feb 2022 11:00:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DECFCC004E1; Fri, 4 Feb 2022 10:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643972400; bh=4eF+FZR8wT+FVkHZjABdFilRAfJ1GLO+M2i4S2Lwau4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=emoq1Gdm7BBFBeJe90HntjRrLmn/85D+TN+x8J7Tx7BVDhvninzRaqZLlGRqghAKR w1dLcfu5QrR00IMnvrUsCsB+tlSur1gZLGeD9qV7hH2HW2vfQ/ZS965kuQVQ6j2HT6 pi4BubAHayBa2lIOirOOykQynjxelh/xJl7CRz0ZRd7DT0h0ICLnzzQlPi1qa8vkrF b582A5meJbJuRbOSaygMaYFxB//SIDshX6G/e6C+nL23vgtA8CM9q/UekfK45X6JW+ hlQ7YVpqlQ7k7D8/wsk1OtTGZGgby6crN9hufxUKfSJCrpAIUUVppfnqnfMhfL74Kg cUb9QNj8BVR7g== Received: by pali.im (Postfix) id 9BE07A80; Fri, 4 Feb 2022 11:59:57 +0100 (CET) Date: Fri, 4 Feb 2022 11:59:57 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Tom Rini , U-Boot Mailing List Subject: Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD Message-ID: <20220204105957.t4rygmnoztasvf7q@pali> References: <20220203183850.10186-1-pali@kernel.org> <20220203211623.GY7515@bill-the-cat> <20220203214544.GA7515@bill-the-cat> <20220203215307.GB7515@bill-the-cat> <20220203220918.GC7515@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thursday 03 February 2022 15:10:58 Simon Glass wrote: > Hi Tom, > > On Thu, 3 Feb 2022 at 15:09, Tom Rini wrote: > > > > On Thu, Feb 03, 2022 at 03:03:21PM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Thu, 3 Feb 2022 at 15:02, Simon Glass wrote: > > > > > > > > Hi, > > > > > > > > On Thu, 3 Feb 2022 at 14:53, Tom Rini wrote: > > > > > > > > > > On Thu, Feb 03, 2022 at 04:45:44PM -0500, Tom Rini wrote: > > > > > > On Thu, Feb 03, 2022 at 04:16:23PM -0500, Tom Rini wrote: > > > > > > > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Rohár wrote: > > > > > > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > > > > --- > > > > > > > > > > > > > > > > I would really appreciate if U-Boot test framework starts printing > > > > > > > > deprecation warnings, instead of sending patches which directly drop > > > > > > > > support for some boards. > > > > > > > > > > > > > > > > There is absolutely no warning during building U-Boot for RX-51 board > > > > > > > > that this board has not been converted to DM_KEYBOARD yet. > > > > > > > > > > > > > > Please send some patch that implements what you're wanting to see for > > > > > > > how to make the warnings more visible. I do agree the warning for > > > > > > > v2022.10 only showed up after the merge to -next once v2022.01 came out, > > > > > > > but it's still a fairly long time to clean up the few unconverted > > > > > > > boards. > > > > > > > > > > > > Oh, I see what's going on. Simon, the DM_KEYBOARD check isn't > > > > > > triggering for any boards. I'll look more. > > > > > > > > > > And here's where we're at. nokia_rx51 doesn't set CONFIG_KEYBOARD, so > > > > > didn't trigger the warning about migration. Every platform that sets > > > > > CONFIG_KEYBOARD is migrated. I don't know how many other platforms are > > > > > in the situation nokia_rx51 is in. Yanking out the legacy code and > > > > > seeing what fails to build, and going from there is probably the next > > > > > option. > > > > > > > > Yes. > > > > > > > > As to your questoin, none that I know of. I sent a series to drop > > > > cfb_console which was how this used to work, although in fact it > > > > hasn't worked for a while. The problem here seems to be that this > > > > board was multiple migrations behind and so was not caught. > > > > > > > > We should be able to remove the migration check. > > > > > > > > Pali, just to explain from the other POV, I am finding it increasingly > > > > frustrating dealing with ad-hoc CONFIG options, old drivers, etc. We > > > > really need to complete some of the migrations we started 6 years ago. > > > > > > BTW the keyboard driver should go in drivers/input and should use > > > device tree, not platdata. > > > > This is likely one of the cases where we end up saying a platform is > > only platdata, given size concerns? That's my quick recollection from > > talking about the USB stuff a few months back, and some other related > > size questions. > > OK, I see. Yes, device tree would add a lot (in fact it doesn't even > use OF_CONTROL). > > Regards, > Simon Yes, there is no OF_CONTROL, no device tree, just plat data, because all those options eats too many space... There was already discussion about it in past and it is not possible to do anything with it. As keyboard support was in board code before, I let it in board code as I do not see any value to move this code into drivers/input as it is board specific.