[PATCH v3 1/2] Documentation: dt: extcon: add optional input-debounce attribute

[PATCH v3 1/2] Documentation: dt: extcon: add optional input-debounce attribute

[Raveendra Padasalagi]

Add documentation on optional dt attribute "input-debounce"
in extcon node to capture user specified timeout value for id
and vbus gpio detection.

Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
---

Changes in v3:
 - Modified commit log to name debounce-timeout-ms to input-debounce
 - Added Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Changes in v2:
 Rename debounce-timeout-ms to input-debounce

 Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
index dfc14f7..d115900 100644
--- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
+++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
@@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
 - id-gpio: gpio for USB ID pin. See gpio binding.
 - vbus-gpio: gpio for USB VBUS pin.
 
+Optional properties:
+- input-debounce: debounce timeout value for id and vbus gpio in microseconds.
+
 Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
 	extcon_usb1 {
 		compatible = "linux,extcon-usb-gpio";
-- 
1.9.1

[PATCH v3 2/2] extcon: add optional input-debounce attribute

[Raveendra Padasalagi]

Add changes to capture optional dt attribute "input-debounce"
provided in extcon node and used the same value if provided otherwise
default value of 20000 usecs is used for id and vbus gpios debounce time.

Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
---

Changes in v3:
 - Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC
 - Changed msecs_to_jiffies() to usecs_to_jiffies()

Changes in v2:
 Rename gpio_debounce_timeout_ms to debounce_usecs

 drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index 9c925b0..69149e2 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -28,7 +28,7 @@
 #include <linux/workqueue.h>
 #include <linux/pinctrl/consumer.h>
 
-#define USB_GPIO_DEBOUNCE_MS	20	/* ms */
+#define USB_GPIO_DEBOUNCE_USEC	20000	/* us */
 
 struct usb_extcon_info {
 	struct device *dev;
@@ -41,6 +41,7 @@ struct usb_extcon_info {
 
 	unsigned long debounce_jiffies;
 	struct delayed_work wq_detcable;
+	unsigned int debounce_usecs;
 };
 
 static const unsigned int usb_extcon_cable[] = {
@@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	if (IS_ERR(info->vbus_gpiod))
 		return PTR_ERR(info->vbus_gpiod);
 
+	ret = of_property_read_u32(np, "input-debounce",
+			     &info->debounce_usecs);
+	if (ret)
+		info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC;
+
 	info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
 	if (IS_ERR(info->edev)) {
 		dev_err(dev, "failed to allocate extcon device\n");
@@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev)
 
 	if (info->id_gpiod)
 		ret = gpiod_set_debounce(info->id_gpiod,
-					 USB_GPIO_DEBOUNCE_MS * 1000);
+					 info->debounce_usecs);
 	if (!ret && info->vbus_gpiod)
 		ret = gpiod_set_debounce(info->vbus_gpiod,
-					 USB_GPIO_DEBOUNCE_MS * 1000);
+					 info->debounce_usecs);
 
 	if (ret < 0)
-		info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
+		info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs);
 
 	INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
 
-- 
1.9.1

[PATCH v3 2/2] extcon: add optional input-debounce attribute

[Raveendra Padasalagi]

Add changes to capture optional dt attribute "input-debounce"
provided in extcon node and used the same value if provided otherwise
default value of 20000 usecs is used for id and vbus gpios debounce time.

Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Reviewed-by: Ray Jui <ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Reviewed-by: Srinath Mannam <srinath.mannam-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
---

Changes in v3:
 - Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC
 - Changed msecs_to_jiffies() to usecs_to_jiffies()

Changes in v2:
 Rename gpio_debounce_timeout_ms to debounce_usecs

 drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index 9c925b0..69149e2 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -28,7 +28,7 @@
 #include <linux/workqueue.h>
 #include <linux/pinctrl/consumer.h>
 
-#define USB_GPIO_DEBOUNCE_MS	20	/* ms */
+#define USB_GPIO_DEBOUNCE_USEC	20000	/* us */
 
 struct usb_extcon_info {
 	struct device *dev;
@@ -41,6 +41,7 @@ struct usb_extcon_info {
 
 	unsigned long debounce_jiffies;
 	struct delayed_work wq_detcable;
+	unsigned int debounce_usecs;
 };
 
 static const unsigned int usb_extcon_cable[] = {
@@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	if (IS_ERR(info->vbus_gpiod))
 		return PTR_ERR(info->vbus_gpiod);
 
+	ret = of_property_read_u32(np, "input-debounce",
+			     &info->debounce_usecs);
+	if (ret)
+		info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC;
+
 	info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
 	if (IS_ERR(info->edev)) {
 		dev_err(dev, "failed to allocate extcon device\n");
@@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev)
 
 	if (info->id_gpiod)
 		ret = gpiod_set_debounce(info->id_gpiod,
-					 USB_GPIO_DEBOUNCE_MS * 1000);
+					 info->debounce_usecs);
 	if (!ret && info->vbus_gpiod)
 		ret = gpiod_set_debounce(info->vbus_gpiod,
-					 USB_GPIO_DEBOUNCE_MS * 1000);
+					 info->debounce_usecs);
 
 	if (ret < 0)
-		info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
+		info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs);
 
 	INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] extcon: add optional input-debounce attribute

[Chanwoo Choi]

Hi,

On 2017년 10월 19일 18:52, Raveendra Padasalagi wrote:
> Add changes to capture optional dt attribute "input-debounce"
> provided in extcon node and used the same value if provided otherwise
> default value of 20000 usecs is used for id and vbus gpios debounce time.
> 
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> 
> Changes in v3:
>  - Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC
>  - Changed msecs_to_jiffies() to usecs_to_jiffies()
> 
> Changes in v2:
>  Rename gpio_debounce_timeout_ms to debounce_usecs
> 
>  drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

After completing the review of patch1 from DT maintainer,
I'll merge these patch sets.

> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index 9c925b0..69149e2 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -28,7 +28,7 @@
>  #include <linux/workqueue.h>
>  #include <linux/pinctrl/consumer.h>
>  
> -#define USB_GPIO_DEBOUNCE_MS	20	/* ms */
> +#define USB_GPIO_DEBOUNCE_USEC	20000	/* us */
>  
>  struct usb_extcon_info {
>  	struct device *dev;
> @@ -41,6 +41,7 @@ struct usb_extcon_info {
>  
>  	unsigned long debounce_jiffies;
>  	struct delayed_work wq_detcable;
> +	unsigned int debounce_usecs;
>  };
>  
>  static const unsigned int usb_extcon_cable[] = {
> @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
>  	if (IS_ERR(info->vbus_gpiod))
>  		return PTR_ERR(info->vbus_gpiod);
>  
> +	ret = of_property_read_u32(np, "input-debounce",
> +			     &info->debounce_usecs);
> +	if (ret)
> +		info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC;
> +
>  	info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
>  	if (IS_ERR(info->edev)) {
>  		dev_err(dev, "failed to allocate extcon device\n");
> @@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev)
>  
>  	if (info->id_gpiod)
>  		ret = gpiod_set_debounce(info->id_gpiod,
> -					 USB_GPIO_DEBOUNCE_MS * 1000);
> +					 info->debounce_usecs);
>  	if (!ret && info->vbus_gpiod)
>  		ret = gpiod_set_debounce(info->vbus_gpiod,
> -					 USB_GPIO_DEBOUNCE_MS * 1000);
> +					 info->debounce_usecs);
>  
>  	if (ret < 0)
> -		info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
> +		info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs);
>  
>  	INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
>  
> 

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH v3 2/2] extcon: add optional input-debounce attribute

[Chanwoo Choi]

Hi,

On 2017년 10월 19일 18:52, Raveendra Padasalagi wrote:
> Add changes to capture optional dt attribute "input-debounce"
> provided in extcon node and used the same value if provided otherwise
> default value of 20000 usecs is used for id and vbus gpios debounce time.
> 
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Ray Jui <ray.jui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Srinath Mannam <srinath.mannam-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
> 
> Changes in v3:
>  - Changed USB_GPIO_DEBOUNCE_MS to USB_GPIO_DEBOUNCE_USEC
>  - Changed msecs_to_jiffies() to usecs_to_jiffies()
> 
> Changes in v2:
>  Rename gpio_debounce_timeout_ms to debounce_usecs
> 
>  drivers/extcon/extcon-usb-gpio.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

After completing the review of patch1 from DT maintainer,
I'll merge these patch sets.

> 
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index 9c925b0..69149e2 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -28,7 +28,7 @@
>  #include <linux/workqueue.h>
>  #include <linux/pinctrl/consumer.h>
>  
> -#define USB_GPIO_DEBOUNCE_MS	20	/* ms */
> +#define USB_GPIO_DEBOUNCE_USEC	20000	/* us */
>  
>  struct usb_extcon_info {
>  	struct device *dev;
> @@ -41,6 +41,7 @@ struct usb_extcon_info {
>  
>  	unsigned long debounce_jiffies;
>  	struct delayed_work wq_detcable;
> +	unsigned int debounce_usecs;
>  };
>  
>  static const unsigned int usb_extcon_cable[] = {
> @@ -133,6 +134,11 @@ static int usb_extcon_probe(struct platform_device *pdev)
>  	if (IS_ERR(info->vbus_gpiod))
>  		return PTR_ERR(info->vbus_gpiod);
>  
> +	ret = of_property_read_u32(np, "input-debounce",
> +			     &info->debounce_usecs);
> +	if (ret)
> +		info->debounce_usecs = USB_GPIO_DEBOUNCE_USEC;
> +
>  	info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
>  	if (IS_ERR(info->edev)) {
>  		dev_err(dev, "failed to allocate extcon device\n");
> @@ -147,13 +153,13 @@ static int usb_extcon_probe(struct platform_device *pdev)
>  
>  	if (info->id_gpiod)
>  		ret = gpiod_set_debounce(info->id_gpiod,
> -					 USB_GPIO_DEBOUNCE_MS * 1000);
> +					 info->debounce_usecs);
>  	if (!ret && info->vbus_gpiod)
>  		ret = gpiod_set_debounce(info->vbus_gpiod,
> -					 USB_GPIO_DEBOUNCE_MS * 1000);
> +					 info->debounce_usecs);
>  
>  	if (ret < 0)
> -		info->debounce_jiffies = msecs_to_jiffies(USB_GPIO_DEBOUNCE_MS);
> +		info->debounce_jiffies = usecs_to_jiffies(info->debounce_usecs);
>  
>  	INIT_DELAYED_WORK(&info->wq_detcable, usb_extcon_detect_cable);
>  
> 

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/2] extcon: add optional input-debounce attribute

[Francesco Dolcini]

Hello Raveendra, Chanwoo et all

On Thu, Oct 19, 2017 at 07:18:03PM +0900, Chanwoo Choi wrote:
> On 2017년 10월 19일 18:52, Raveendra Padasalagi wrote:
> > Add changes to capture optional dt attribute "input-debounce"
> > provided in extcon node and used the same value if provided otherwise
> > default value of 20000 usecs is used for id and vbus gpios debounce time.
> Looks good to me.
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> 
> After completing the review of patch1 from DT maintainer,
> I'll merge these patch sets.

I noticed that this series [1] was never merged in the end, anything I
can do to help?
It is solving a real issue and I would be glad to understand what's the
reason this was not merged in 2017 to get it done now.

Francesco

[1] https://lore.kernel.org/all/1508406773-887-1-git-send-email-raveendra.padasalagi@broadcom.com/

Re: [PATCH v3 2/2] extcon: add optional input-debounce attribute

[Chanwoo Choi]

Hi Francesco,

On 2/4/22 10:59 PM, Francesco Dolcini wrote:
> Hello Raveendra, Chanwoo et all
> 
> On Thu, Oct 19, 2017 at 07:18:03PM +0900, Chanwoo Choi wrote:
>> On 2017년 10월 19일 18:52, Raveendra Padasalagi wrote:
>>> Add changes to capture optional dt attribute "input-debounce"
>>> provided in extcon node and used the same value if provided otherwise
>>> default value of 20000 usecs is used for id and vbus gpios debounce time.
>> Looks good to me.
>> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> After completing the review of patch1 from DT maintainer,
>> I'll merge these patch sets.
> 
> I noticed that this series [1] was never merged in the end, anything I
> can do to help?
> It is solving a real issue and I would be glad to understand what's the
> reason this was not merged in 2017 to get it done now.
> 
> Francesco
> 
> [1] https://lore.kernel.org/all/1508406773-887-1-git-send-email-raveendra.padasalagi@broadcom.com/
> 
> 

Need to receive the review from dt maintainer.
If possible, resend this patchset.


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Re: [PATCH v3 1/2] Documentation: dt: extcon: add optional input-debounce attribute

[Krzysztof Kozlowski]

On 19/10/2017 11:52, Raveendra Padasalagi wrote:
> Add documentation on optional dt attribute "input-debounce"
> in extcon node to capture user specified timeout value for id
> and vbus gpio detection.
> 
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
> 
> Changes in v3:
>  - Modified commit log to name debounce-timeout-ms to input-debounce
>  - Added Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> 
> Changes in v2:
>  Rename debounce-timeout-ms to input-debounce
> 
>  Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> index dfc14f7..d115900 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
>  - id-gpio: gpio for USB ID pin. See gpio binding.
>  - vbus-gpio: gpio for USB VBUS pin.
>  
> +Optional properties:
> +- input-debounce: debounce timeout value for id and vbus gpio in microseconds.
> +

Use standard unit suffix. See schemas/property-units.yaml in dtschema
sources/repo.


Best regards,
Krzysztof

Re: [PATCH v3 1/2] Documentation: dt: extcon: add optional input-debounce attribute

[Krzysztof Kozlowski]

On 18/02/2022 12:32, Krzysztof Kozlowski wrote:
> On 19/10/2017 11:52, Raveendra Padasalagi wrote:
>> Add documentation on optional dt attribute "input-debounce"
>> in extcon node to capture user specified timeout value for id
>> and vbus gpio detection.
>>
>> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
>> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
>> Reviewed-by: Srinath Mannam <srinath.mannam@broadcom.com>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>> ---
>>
>> Changes in v3:
>>  - Modified commit log to name debounce-timeout-ms to input-debounce
>>  - Added Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>> Changes in v2:
>>  Rename debounce-timeout-ms to input-debounce
>>
>>  Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> index dfc14f7..d115900 100644
>> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
>> @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
>>  - id-gpio: gpio for USB ID pin. See gpio binding.
>>  - vbus-gpio: gpio for USB VBUS pin.
>>  
>> +Optional properties:
>> +- input-debounce: debounce timeout value for id and vbus gpio in microseconds.
>> +
> 
> Use standard unit suffix. See schemas/property-units.yaml in dtschema
> sources/repo.

Although different topic is what Rob expressed here:
https://lore.kernel.org/all/20171025145337.kubcbkxrhbsy6o4a@rob-hp-laptop/

It's a no go and sending new versions is not the way to deal with it.

Best regards,
Krzysztof