From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nFzfV-0004Jk-CY for mharc-grub-devel@gnu.org; Fri, 04 Feb 2022 09:34:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFzfS-0004Fy-QJ for grub-devel@gnu.org; Fri, 04 Feb 2022 09:34:31 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:15656) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFzfP-00026K-FL for grub-devel@gnu.org; Fri, 04 Feb 2022 09:34:29 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 214D5K1L032163 for ; Fri, 4 Feb 2022 14:34:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=sO65+fiTsahE8X4ye5YER9xvUJ4JkLODe9e+mZNjSvM=; b=EMYdMUQCE7ATTBuHUckJTxZeKHg+P/wj1YdsL0sl76mT+pK1TwPbVkAqUUAOUgaJKVzN TIbVjKk+LH2zrs0zSdb1TJPxBMD/MZYkgap53FiJ2SJoAP960THhv0IFfY8PBtjm9O+E ifi34zvZsKOnXAIcHVtcL6yQauNFPD9B75xoxI9RTkwK+dPGQOzYj+QvVlMFhxolpATj 7Y6O8gBMmMe2oEke6hUqaLBNtTP3m4uiFm4bK0HXlJr1oaVqJ3Avf0m/8fr1EhWwRA9f rBO6UtH4mgh1sl3PN82UiEs6opsElgX8i1dbURnv/7zam1mdCEJuz37idiB/eRjR0DZs WQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3e0hfwas8b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 04 Feb 2022 14:34:23 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 214EFKxH030928 for ; Fri, 4 Feb 2022 14:34:22 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by aserp3020.oracle.com with ESMTP id 3dvwdcdk91-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 04 Feb 2022 14:34:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGNbAUeMRAyoIqUOfhhB/a/t7bkAAvD5P/PHfto38rWChLu6HWLJbqDmu+hUoycItjqxi88y8vBQZj6LSaqHQrN9nGwYXVwsKwciu0+r7oPd+aSKJTl3n3WuBJNSpPyxzk5ZAubafr9zhpHkht78DyahyHwC45DtOjGzwc9LyTuSL8Nk9utpSkYgMjgqC/oawm469tzLVo+RorRex3ANIh6VzJ0AOovdf0k5afmH0RAeJ6VDryN8oEPjpjrW7y7kiTV5cNaCToR4Axu1hZ6l+TBBdLPZHwxgPr+VBVKihjXRquFXGp5raDLBwssDc/z6k4hhp9Wgly0hGMr7jnWV5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sO65+fiTsahE8X4ye5YER9xvUJ4JkLODe9e+mZNjSvM=; b=eY3gkOqU5Iqx7NXWkWYMEODFRRDzEW79C11HZH0GzrSOgPhEUyufyRK11zXVrDxZaleCXabZK/YM7AZVK7syNU+o1QHk9DEV/KtljfWCkPFq8mOx9xssNhA2GzOX5Ij+RzdYszsHot5eJMGUABIJo59B4UTpJsR0ystzMg0aQ7ZJJlNdYRT5Z0T+EJRJPj/JMX6JWdh5TBYYim19OVIyzwFDVKnjU9+l3iKVIPwXAB9DAAcNUvQ3haaYBpIezrlVK6jVvrkwQS6jLItFb0J8FThtMkz5pV0fAuPJvTi3jfS02eYLeoCBgX1GQPOoSEk55YN5U76Ao9ikZoPjnm7HRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sO65+fiTsahE8X4ye5YER9xvUJ4JkLODe9e+mZNjSvM=; b=XUjIz8eiBYr8b3ZuMBAFQrj8oiV1iscEv1Z94u+onkRgPqeD8L0yI7Wf4HjFTutGjN11ECQAADMV7VU1ToEKvMwdVJcA8bqoY0DMCtsdrWEzxc+Vzm88Rx5v+94mtKpT2UAukNrFb9ehneRiWy5ZTh97S4u5v5GJOzNxTWnB9qA= Received: from PH0PR10MB5705.namprd10.prod.outlook.com (2603:10b6:510:146::20) by BN0PR10MB5255.namprd10.prod.outlook.com (2603:10b6:408:12f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.10; Fri, 4 Feb 2022 14:34:20 +0000 Received: from PH0PR10MB5705.namprd10.prod.outlook.com ([fe80::e4d6:c689:51ac:9883]) by PH0PR10MB5705.namprd10.prod.outlook.com ([fe80::e4d6:c689:51ac:9883%5]) with mapi id 15.20.4930.023; Fri, 4 Feb 2022 14:34:20 +0000 Date: Fri, 4 Feb 2022 15:34:11 +0100 From: Daniel Kiper To: Darren Kenny Cc: Alec Brown , grub-devel@gnu.org Subject: Re: [PATCH] affs: Fix resource leaks Message-ID: <20220204143411.mqwibpqxtfabnval@tomti.i.net-space.pl> References: <1643846901-7889-1-git-send-email-alec.r.brown@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: AM6PR0202CA0042.eurprd02.prod.outlook.com (2603:10a6:20b:3a::19) To PH0PR10MB5705.namprd10.prod.outlook.com (2603:10b6:510:146::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4cabdff0-752c-4e6e-07f3-08d9e7eb6e55 X-MS-TrafficTypeDiagnostic: BN0PR10MB5255:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1332; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GuTqIwSUJ/hR1VDMI6u3G9+zObxZE+GA76G4qwz4IKoRA5BRxJb0ltGv+Saf6Ck3qYP+jF+J2dMYubZFlHv44IlWSRVqLQ2hu+/Co85V6gUQJYp4QMV6Yy0tmvL+A6ijm0/3R3bHyKbCz77YsXiC5Yd4pZ6bVTI1jTKzWpLZYe18JoPldVwC+fEg8x3GWPk+LGDVwJM7VUFYNhJzLLnVQx9WOxYL7+z6/2nd0F9G98zNl3Q3G0m8viCLp8iDJlnTVglMnaV5TA6jDvVT6AvC+JEN954LYEGGoL6suMtNHbes20kbGwfXn1bsk8OEvB6JpJyJJ6hTtUj5s187JiVI0FPcHyHpb+FIRCnjYSRzV+k1NxulAG12Sl3Z3QfJhBbmu5P/8TtPjmCQnceDRP7tOrqlNVgUsimVyzHB3I2zNSyGE/VBcw2hsnF3QrZSTcBzDEGBza1uGAPfA9mUHPtB+E2D4Ie6BNTtPG3PSX/Qfu4pizy/qNwzkC3tZtcK1n1DaaNNa2CHtDLslDwR+cAH1rFX5vR0rXlvWEm+LRxkpx1/CNsAMOh3ZdL9v/RFDfjApz169C9p5bDUgoNEcXKn6/phIivdCr2YEJb0Fnc2sHvA7mBm5JtCLDD+r90Glnaqgj460hjgoRV2bT2ROgV5cYsA529w6Wqt6MKHdV1uYL+z6W7ZBpykOHW0QZkBOIGwKlGRyhIilKBdLkqqywMygw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR10MB5705.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(44832011)(38100700002)(38350700002)(4326008)(26005)(6486002)(2906002)(186003)(558084003)(316002)(3716004)(9686003)(1076003)(5660300002)(66946007)(8936002)(6666004)(8676002)(6506007)(52116002)(6862004)(508600001)(6512007)(66556008)(6636002)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3lSkUVUr8KoGm5cCK+hpSl+NC9MW8EmM6+2du+VrPPe4J5/RNBFAtGD+qrFD?= =?us-ascii?Q?q0kjtAfHO5TmBrokhbiL6NCziLZeloeffdm2B3K/MeHgfTeSeh2d3fYDBwQe?= =?us-ascii?Q?aUprKGn5l7wyKhVJY0tlIAgGdcwfevyHPwF13gi78z+E7b43IZy/gDlzJXQk?= =?us-ascii?Q?VOlsR1AneLpD+k1WV864TTu1iqsotMa5gcLsoim9+xNTfP1sx1Kc4+YCNEpD?= =?us-ascii?Q?V70c5tw7FeJn4dD/vdmLx7Gpwd42U/IiFJgyX7vKCKz/xwGvH3YmepMGjAvu?= =?us-ascii?Q?7t8xGSf7EWAF9YKm0d+O7nJTEMB9ag3KCvo26tYe9y46GnWQKUtcUPVERgX1?= =?us-ascii?Q?0D7aHKLd1nCOxcntRHkbxGuq+Nn08GvVnEBrjLMtoytWtSiYm5nJqih8khWF?= =?us-ascii?Q?Q7ukNQ6pVWc48A/ZPewJEY9reN6ZgZz9qR4TlCHwFrkQaBpknsc1KcKhF9Ap?= =?us-ascii?Q?2cTJHCa2v4HTQOOB/AwNZyxlePbgdBrj6bTrv52p43OrTupKI/+47PzkHZvv?= =?us-ascii?Q?bc48j9pK6EIaIKOmWHpt9YrLVz1MCzU2P/IgtZbNnGg+enAe7PrlN57ywaZa?= =?us-ascii?Q?IGJ3k1JOOabPYUuCFOkkktxus3zYdwg+AmVbOaG6/143lihZhiZ8dXKToSJx?= =?us-ascii?Q?gvNFVlk2JOP9CeWTDW+IxKbFnbXOsQtiWYp5aSJvqrW0th1hjwTq5tPq/lQq?= =?us-ascii?Q?a7axw7xfZRtCA9UWEZwCTIdePSSMIIC7qbFSlFvM4RzwgDQ4sEfgPMyXOTSd?= =?us-ascii?Q?BkmOW7/Llovo4AZJnAOaqs62yq2+G4K6xBRE3BAmBk7lxUPNXBCTrH37LYVD?= =?us-ascii?Q?sHWtdrElponpH4jO27vv+WBkqlj24chp2qA5XukJK+kpB5KSF7ZBwDv0vSUw?= =?us-ascii?Q?VMDZczgiOEQ2xWvbIK6crCid2RJLtAbxFNQLPL69VvqI/Mm4QMxd42umhSGS?= =?us-ascii?Q?fufeN8vruQFIsC8PGldBftF85+LAlk8Sie0EnylQwY6QxPYqsaT0NJGCp6JE?= =?us-ascii?Q?j/zkb0ENC8dIEt0FBh5LCzuRTxsgh/rvCsfAif0ewfoywVgugS6DhKvYrkfn?= =?us-ascii?Q?SCRpMBZE4E4XdZx+4p+3+u9xpqxXP96YFcBIj6VzyCLzPFWcl5A255rHhoBX?= =?us-ascii?Q?79Suugs1Y5OcCq1kRHuobbKJV+YWgVkUSR05hao3TATezWJjLd26SQZk72uB?= =?us-ascii?Q?yGoHVIQeadSpd0uz7o3aH02xSs7N7GVLUNtlXAkKrcNMkDJ/NW1VUOZx649w?= =?us-ascii?Q?/VpBvOGF6T6rVvMPmDN2YIWZ2y7dQ/jGccnH3LCkmrFu4MgJ/Xl0aniV+N1f?= =?us-ascii?Q?qpK9K1Lz4Y7R+Pd8iHl1t6ebRENUhSjhisYLXUzBaP+gwZY7nVYWDrJNgo3x?= =?us-ascii?Q?bBteZHTKkcR3xwaM19yf864B9VqgdaqGCc+4gWnNQWS2OkUXzViOdbMtDsIO?= =?us-ascii?Q?LQ5RjUr3hJ2KZbeUVn7I/+Gt6qfS/AKO8lhbQXeTk6zccSjvZvxMEGC/MeMI?= =?us-ascii?Q?QgXVpUWwKK56SViswS54FU7hdb33ivSkczNlyhprhi6+TBfUlWZvx4X0RNSc?= =?us-ascii?Q?5ynrFKTI2g5wU+3Z2pubtMnnf7JyvMW+V5QiDa4mvusL4BLR+1JZSfIYWzIX?= =?us-ascii?Q?JEj7/8at3rXAVTCCrdc9Q3w=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4cabdff0-752c-4e6e-07f3-08d9e7eb6e55 X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5705.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:34:20.6220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f7kX2EdOdbcHuaHDg6tQ44RkSfSwpyWzwSA3eJzmB2Zx6GlANHkdjJH/9qkf3ILxCt9v0G4Nq1QHVnGdR0A/hA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5255 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10247 signatures=673430 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202040081 X-Proofpoint-ORIG-GUID: uX7SR1NVKunjdc3pOcKK-I-tt8vzl5As X-Proofpoint-GUID: uX7SR1NVKunjdc3pOcKK-I-tt8vzl5As Received-SPF: pass client-ip=205.220.165.32; envelope-from=daniel.kiper@oracle.com; helo=mx0a-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 14:34:31 -0000 On Thu, Feb 03, 2022 at 11:58:42AM +0000, Darren Kenny wrote: > Hi Alec, > > Don't know how I ended up missing this originally, but thanks for fixing > it, so: > > Reviewed-by: Darren Kenny Reviewed-by: Daniel Kiper Daniel