From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nFzhX-0006Av-Ib for mharc-grub-devel@gnu.org; Fri, 04 Feb 2022 09:36:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44020) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFzhV-00068h-8h for grub-devel@gnu.org; Fri, 04 Feb 2022 09:36:37 -0500 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:3696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFzhS-0002eb-0I for grub-devel@gnu.org; Fri, 04 Feb 2022 09:36:36 -0500 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 214D59bc019812 for ; Fri, 4 Feb 2022 14:36:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=i0creJWohOhFkv6x/o/T+dKXMlRh69OrSHZl7Vv/674=; b=nYjfhwFjj8l79Xz6JCH+GCK7PIVzCrDGSiXo+ZxHUDSr2ydl6Y1qm8Ih3x23CqHz13Hj 89IyCm3nxi6wPRDg8Wm89TY85c5e37hT30eo5aA0nms4vGqD22UYe04qAAJbtkAd5A2r yMtt2VBGEBaCLYTqyONYIqw78y/NNNPPUPnmolHmKVUXSXFiTqjI1MJHDwI6NguozRfn M2S0dWHCN6wWdiSetCGclyGajvWyQechm0ON2dcsVe2FY1gGcuAKKvdMN9Oz/0MHWHsh wGIK/DaynpxxicRPdL4Jp6nP9yxOH4WcdpVu3beFKQa6DxElROzwOE0iR10VYAu8MVe2 lw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3e0hetawaj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 04 Feb 2022 14:36:16 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 214EZp48034658 for ; Fri, 4 Feb 2022 14:36:15 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2044.outbound.protection.outlook.com [104.47.56.44]) by userp3030.oracle.com with ESMTP id 3dvtq7mu0m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 04 Feb 2022 14:36:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TwbOdzzufHvRSUKGlGyPEHvu4ByOqC8XbgaDAcilvZlVRCWrjB3dVX3WkmaBkGwlJCbumYVzE+UmirBMDMz/Ozs6+KkOT1T4HQJlDN7kdv6ysbpPfpEo5tjSopxCYG6/9A2NWoJiF8M+Uo5lQLkUc0bks0Bq2q0QPTaCJ3fO+zYuHEkPJ2/7xNDGNy3zo4YeM4QDNPQ4FAUW/tzPCbF6dJk7/idWOqXDwSGnSXUVx6hTeHprieKW6cngdnBzG2Bn3DoaHzA3DVLWsH/9XvPaJvLgXYh//xCZrMB7qdVDovQsKbpKkiL4U+Z8Cf7t1pq6r2mnCPusjOgygSAyaDYSCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i0creJWohOhFkv6x/o/T+dKXMlRh69OrSHZl7Vv/674=; b=D1ZuaKzYKtL7MVEXP3KSqGMzw8uXZdPe3tkowO+FQyY1Ef2PknnIJoK0PZhqQ8qjuV0fl44EsxCcr3YAgU/dw8qBbUToiCJyZu9aMPUjV0NZ6PsXYZ56mw4NpUFEU8bvPpk0iNvpmuwxMQNMyeqxtC0UwPmQdlPCYx93piI/bMdiiyUwZxhaMhbvCGdiddCj0pViqlTR6XJ6/SIMJwY1vvuO1Mw/TvBJvM/m/PaM4P0cybP5tVTXUN3bjQ10De9uhPVG5AV85PEU8cy5+MgAkqmh83844DmSEtbfjn3aGzyT2h5L2mUfy2ZaLdCOZOHbrxfuqgT/5t3DTTRYhjkJOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i0creJWohOhFkv6x/o/T+dKXMlRh69OrSHZl7Vv/674=; b=MhAXIcDzLIkFNCEvx0s7Jme8LLmAB8alu1p+tu8uKd5sg4fMIlOWDfdY7/i3Xz8MN35Jfdg9T1XORWkY4cAcO9DwDr2nBuPMeZAeHUH7o3cJMciPZuxaWggsMKeWWS4yOeRIZnAyCtdSATyr97bderZnei6rKnaTRRKIyA0s/q0= Received: from PH0PR10MB5705.namprd10.prod.outlook.com (2603:10b6:510:146::20) by DM6PR10MB2778.namprd10.prod.outlook.com (2603:10b6:5:6a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Fri, 4 Feb 2022 14:36:13 +0000 Received: from PH0PR10MB5705.namprd10.prod.outlook.com ([fe80::e4d6:c689:51ac:9883]) by PH0PR10MB5705.namprd10.prod.outlook.com ([fe80::e4d6:c689:51ac:9883%5]) with mapi id 15.20.4930.023; Fri, 4 Feb 2022 14:36:13 +0000 Date: Fri, 4 Feb 2022 15:36:05 +0100 From: Daniel Kiper To: Darren Kenny Cc: Alec Brown , grub-devel@gnu.org Subject: Re: [PATCH 0/4] Clean up code and fix coverity bugs in util/grub-module-verifierXX.c Message-ID: <20220204143605.ahcu4bo5vmeaebdd@tomti.i.net-space.pl> References: <1643848020-8197-1-git-send-email-alec.r.brown@oracle.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: AM6PR02CA0020.eurprd02.prod.outlook.com (2603:10a6:20b:6e::33) To PH0PR10MB5705.namprd10.prod.outlook.com (2603:10b6:510:146::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10c099c4-ab26-4d19-e075-08d9e7ebb1ae X-MS-TrafficTypeDiagnostic: DM6PR10MB2778:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cm/+G2LsBJeolwFDMmsPvSQ06gzU3dTyLxvRGsZNLRX1WIuQzWdMLll+NmHDC6UPJuPZ5wHpzOvny9WwQs0kV/Nay/KPJITQ44gUvKOcgsq34AqHMTHCXMXgmjQ/zRTBHWupRJJ13dLwjzHgkdwythDFYJO/9iCBjOkkQt/2GBnWO2mzyUDDctDEya2+ffpJ/E+vWOGe2Vq34iNyrQMowaI4XHBktP69+w88PztO/rKMFiUNtpeq4uf1iG/LC8rKhvsxLZm+povc0DAfUivq+xrGPuRhUcoDh4jagYHEpvbeMAEEaGl0H20UW5TPSbV0q/p9M6pGJW02bwbRNvslV0xTMsM6KV5mr0CkASe8MGlm1NaXxR0VZrKRVjnsZ+BTQlKj1Z3utoSxdnE11n+By30ipYK1Gs6S2Qcp46Tyj43z2mHdrxYm+8XtGc5d4tyhflpP4Y/ILUgMo+AM/ZtHDabYd47EH0WNGLHVwjf6NLzVejyrMuhmmYIi7OIycxIX1RukxGEbyBnO/MpkXYr1cooTEhI8UqKCvwuoOjW597tJuwXqz8OZSiH0zBjFn8G2bS3XaP8k563rZFtl6lvGutd5KtCgQTAAaVL549OxgMA8wJ7KJpEqDo4WhIbcVAd9YL7Sg7pjoUeju9tJowQK2YYeTh/Na1lflIUlbJ64TO6qnl9fAsnCU64pFg7w2rSd8lCnM41jYGOla3iNuCi84A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR10MB5705.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(6506007)(316002)(9686003)(8936002)(38350700002)(38100700002)(52116002)(44832011)(8676002)(66946007)(4326008)(6862004)(6666004)(6636002)(86362001)(26005)(6512007)(66556008)(558084003)(1076003)(66476007)(508600001)(5660300002)(2906002)(6486002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vbV04Gdi1r1NnKnqb6QdgEBaoMK+kynOuBAmQCv96uhvyZ9SvlnWspxsp9Cd?= =?us-ascii?Q?UYNxF+P8pzo7SmD9nlyegU3cCJPbhdkbFW50YJBBKeK564o7sNn7Wo+F9+mr?= =?us-ascii?Q?oasL9ycm13u+FAcQziCwcVDcHcdnkCfUJZb2NldLAx8/e+65cP9SSmJKHLef?= =?us-ascii?Q?uhgoE9k/gSQei2KGLSxjj2kC0gbY3u5Nw/8dch+JdddRESIpJiQJN1VZQQS3?= =?us-ascii?Q?XwC+70kKWlcL1jn54u2txKCEkg1TXAxm4Ipwr+4WY4F6o+/qBuh5vQ5zu4yi?= =?us-ascii?Q?AV7OWqG0nibhWNTl410+gEbjMFO5Zn5JnpdrYjBUOYLBTDTYU/XhMmkoHBeB?= =?us-ascii?Q?VVrku/4Pt0ueu9GLvQ7vyhe15vDgVCqR4cCZCu08FaMjO8DPt9Txtce186BO?= =?us-ascii?Q?5JYqIvVnOPP5UUVTc1dlHCyR5uqWgtdOxBBHH/tN5gr2aT6yvIFOUlxf7MYQ?= =?us-ascii?Q?dFrcwTAG5OQcI06/TPd5WjDYeHNF2AyNKUrCVBy93TECQKYJbnVVkhjSQLwO?= =?us-ascii?Q?edN5Sg0mCaaPclKJK30WZ2Rvjj5U+IlmBkwMlcrskgZxmuMLpX+SSCn6psuz?= =?us-ascii?Q?E6bp4l5Dro8QYRqEt9OwA/Q/4zrwv+TACVxCnEwUjqPmI8XOgjwuxKtMExVT?= =?us-ascii?Q?CvqC2f33cKUFQWznUz73qUjSaJeABshGUX2yS6AZH8DrejZWNe/t/q5s24Ba?= =?us-ascii?Q?u4NVND2hKB3RtEwLoV9YuF+/vCuK+AjnbAJ1bNt5VWCcrQEMQ0eLMbufDx87?= =?us-ascii?Q?J6G91bDROMM2kKCzVRgzt32An3UlCtoGCEYkYetsI6J0wWkxNxHZ49Rdc44B?= =?us-ascii?Q?/dBWnnX96nBqf/lYKnXWVbGjQ/PDduPoQo9+FL5NFThCXGJMKwo97kwQAx8X?= =?us-ascii?Q?FH4py5VuIbeCZEeC5A3u5YiEm6LvbiSdY7GsfPgolu4KlFwH74gjW2ojaPuU?= =?us-ascii?Q?6DMxorErlgEVXv36ac1ZKiMWQMBMX9K5K5gdjcxp7cJfFsanFGa3gMolLcd1?= =?us-ascii?Q?KabtZ8/vLH42cxT6nyoxiIJJ3+2EoNHbz41G6JQ7/Lgr/N6tFfwVumbc8UTa?= =?us-ascii?Q?jlEhrDJ01Um5QKN+GRefSdpwvFMadRcBmUuFk61vN7SHKUuApuVJSgF8cFOk?= =?us-ascii?Q?NGZ1Or73HfXAsrXxYKOtEFoECMPg/BEZGvQ9xaYMc86Bw5q1QFJaHCcw9N1n?= =?us-ascii?Q?JDJ/JMyxcI6RjEgKOr8v087v9xVcmRM8fZU0NSK0MB0xd1keNx4eCqtPQDj9?= =?us-ascii?Q?xhdwDXlvjVASvUTTpr7vjcV1pUeN57ww0TWD+lAC+r+Bc+6AR4+PcbLz041Q?= =?us-ascii?Q?R0A34FKmuPaPl6djvSyrDUPYjFf2Nutiew4pHLLBZK1jCTKx9jGFFTdkZw3d?= =?us-ascii?Q?qSO7LxmgVx52u9n8k7U+FmZ0tJt7Af6F/5TlYZfRBaVFsH7Kzi3QX9jXuISj?= =?us-ascii?Q?Vj++1+XqpIr0d3gGU+/kextTu8CwYdDFqB6/NULsmpM8bza5YhUs3LyPwv5U?= =?us-ascii?Q?5F01e/JiH7BTaj+3dQNUxsiUB35GQyfagmSsK4+XbYFuSNsprggRzokmxs4i?= =?us-ascii?Q?7NF8FAapV1AUyGk2zwsGOgE+Mt1RFfqsOBJiwu0JBxkfbGU4EwyFjcN/nbBU?= =?us-ascii?Q?1KGh92PO8L02imASGwMoYnA=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10c099c4-ab26-4d19-e075-08d9e7ebb1ae X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5705.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2022 14:36:13.4931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OaJArVnGoVSNOwYesqi6riz2rhYnUNuPAnEGwbH7ClBxzc6w/7ZSvHmdfasbDR9w6D8BxVC7Gt4W6TkOl9ffqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB2778 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10247 signatures=673430 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=942 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2202040082 X-Proofpoint-ORIG-GUID: kAbQccIcNugS_lJWNmdGfbonOCLKtX_3 X-Proofpoint-GUID: kAbQccIcNugS_lJWNmdGfbonOCLKtX_3 Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 14:36:37 -0000 On Thu, Feb 03, 2022 at 11:56:49AM +0000, Darren Kenny wrote: > Hi Alec, > > These look good to me, thanks for handling the Coverity issues here. > > For the series: > > Reviewed-by: Darren Kenny Reviewed-by: Daniel Kiper Daniel