Re: [PATCH v3 17/30] KVM: s390: pci: enable host forwarding of Adapter Event Notifications

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3296 bytes --]

Hi Matthew,

I love your patch! Perhaps something to improve:

[auto build test WARNING on s390/features]
[also build test WARNING on v5.17-rc2 next-20220204]
[cannot apply to kvms390/next awilliam-vfio/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20220205-052233
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-randconfig-s032-20220131 (https://download.01.org/0day-ci/archive/20220205/202202052152.V6WfEnsb-lkp(a)intel.com/config)
compiler: s390-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/5889fc3e91862ce82ec0ce5f9491d6048c72d3e6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Rosato/KVM-s390-enable-zPCI-for-interpretive-execution/20220205-052233
        git checkout 5889fc3e91862ce82ec0ce5f9491d6048c72d3e6
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=s390 SHELL=/bin/bash arch/s390/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> arch/s390/kvm/interrupt.c:3288:20: sparse: sparse: Using plain integer as NULL pointer
   arch/s390/kvm/interrupt.c: note: in included file:
>> arch/s390/kvm/pci.h:41:65: sparse: sparse: Using plain integer as NULL pointer
   arch/s390/kvm/pci.h:42:32: sparse: sparse: Using plain integer as NULL pointer
   arch/s390/kvm/pci.h:43:24: sparse: sparse: Using plain integer as NULL pointer

vim +3288 arch/s390/kvm/interrupt.c

  3273	
  3274	static void aen_host_forward(unsigned long si)
  3275	{
  3276		struct kvm_s390_gisa_interrupt *gi;
  3277		struct zpci_gaite *gaite;
  3278		struct kvm *kvm;
  3279	
  3280		gaite = (struct zpci_gaite *)aift->gait +
  3281			(si * sizeof(struct zpci_gaite));
  3282		if (gaite->count == 0)
  3283			return;
  3284		if (gaite->aisb != 0)
  3285			set_bit_inv(gaite->aisbo, (unsigned long *)gaite->aisb);
  3286	
  3287		kvm = kvm_s390_pci_si_to_kvm(aift, si);
> 3288		if (kvm == 0)
  3289			return;
  3290		gi = &kvm->arch.gisa_int;
  3291	
  3292		if (!(gi->origin->g1.simm & AIS_MODE_MASK(gaite->gisc)) ||
  3293		    !(gi->origin->g1.nimm & AIS_MODE_MASK(gaite->gisc))) {
  3294			gisa_set_ipm_gisc(gi->origin, gaite->gisc);
  3295			if (hrtimer_active(&gi->timer))
  3296				hrtimer_cancel(&gi->timer);
  3297			hrtimer_start(&gi->timer, 0, HRTIMER_MODE_REL);
  3298			kvm->stat.aen_forward++;
  3299		}
  3300	}
  3301	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org