From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3DFB29CA for ; Mon, 7 Feb 2022 14:01:30 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id j24so10901483qkk.10 for ; Mon, 07 Feb 2022 06:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+VH5Yzc0FArtBDlyVciKdTaJzlAuXtplA0CDhVkYZVw=; b=TUJuhAgjjswNVQ7JzTkg9iKkOgM430mBd5iaZFyVB8juiwGMelroxSVc/tEeoVjS03 SBBJAs6XyaJLOH0zNh1fMB11MocmBy0vZW3lQVqwc7nmLVkUib5NLDfgXeW1egoLcrUl 0zJ1M9G8GricJAi2JHxOQgJzIsENPf4oXdSlLGMn1ou/GSiwitfE+Re74s2OC3cGYiXS WAB6PyKR8iNz2aNJcgzl/Jv2b00SlxQrNVuEW+ZJ8pyVvgvQpU41dl5hiuO86kWk7vjX 6XluH9RnX42crAJsdacFsF/M+gN0YxPG9aqIQm6tHe1mZG9Uo38/MZ0gAIlPcqFBC8jG 7hCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+VH5Yzc0FArtBDlyVciKdTaJzlAuXtplA0CDhVkYZVw=; b=bofMcDH2C1dP1TLvEUu2MFcIDEJbKVr4WDs2425ga8NN80HA4NvjKF8zWCZnVSlaWu oBo350AnDcKnuEuTahzunDZ10zGCjZrkQOWKEbr6IzR8tKoJ2KlnREc5rmpG6NTPhGWw RHBtw8gvDtCmjAAubh4nvvx3nN9JmfVBOxG2B9c/JzPxORvaeEtoriOB/jNNXgUcQ027 2bDSy4vUE+IjyCzmwwb31G0CG6qXxkN+hVbYNSLzYwyMQqFzTBLxTy9cFmJdkzVoGs9c BdAe76YH7miD9giZ8e37i5ufD+NWfhiNepcXihd5MRx9KXdeKOeuD2tm/XIHTLsc7yZh Ed2g== X-Gm-Message-State: AOAM5329dlp4o+KoB1UnI0LgONjTiJiElYR6i5dtbj15jcXxbfy8T/+9 5NWdYsVPARpBacDIBF7hQSDjag== X-Google-Smtp-Source: ABdhPJxewUAI8RDxJecgMQqK84dnZDRSuWWALhikOi914YekMnNecZIoiX1AIBCzbrtZ6bBwZBwWpw== X-Received: by 2002:a37:2c02:: with SMTP id s2mr6217893qkh.76.1644242489492; Mon, 07 Feb 2022 06:01:29 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id f4sm5480989qko.72.2022.02.07.06.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 06:01:28 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH4a7-000CyH-Do; Mon, 07 Feb 2022 10:01:27 -0400 Date: Mon, 7 Feb 2022 10:01:27 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Andrew Morton , Dan Williams , Felix Kuehling , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, nvdimm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 3/8] mm: remove pointless includes from Message-ID: <20220207140127.GA49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-4-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-4-hch@lst.de> On Mon, Feb 07, 2022 at 07:32:44AM +0100, Christoph Hellwig wrote: > hmm.h pulls in the world for no good reason at all. Remove the > includes and push a few ones into the users instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 1 + > drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 + > include/linux/hmm.h | 9 ++------- > lib/test_hmm.c | 2 ++ > 4 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 747A6C433F5 for ; Mon, 7 Feb 2022 14:01:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F328C10E5DC; Mon, 7 Feb 2022 14:01:31 +0000 (UTC) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C47B10E5A8 for ; Mon, 7 Feb 2022 14:01:30 +0000 (UTC) Received: by mail-qk1-x733.google.com with SMTP id bs32so10955341qkb.1 for ; Mon, 07 Feb 2022 06:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+VH5Yzc0FArtBDlyVciKdTaJzlAuXtplA0CDhVkYZVw=; b=TUJuhAgjjswNVQ7JzTkg9iKkOgM430mBd5iaZFyVB8juiwGMelroxSVc/tEeoVjS03 SBBJAs6XyaJLOH0zNh1fMB11MocmBy0vZW3lQVqwc7nmLVkUib5NLDfgXeW1egoLcrUl 0zJ1M9G8GricJAi2JHxOQgJzIsENPf4oXdSlLGMn1ou/GSiwitfE+Re74s2OC3cGYiXS WAB6PyKR8iNz2aNJcgzl/Jv2b00SlxQrNVuEW+ZJ8pyVvgvQpU41dl5hiuO86kWk7vjX 6XluH9RnX42crAJsdacFsF/M+gN0YxPG9aqIQm6tHe1mZG9Uo38/MZ0gAIlPcqFBC8jG 7hCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+VH5Yzc0FArtBDlyVciKdTaJzlAuXtplA0CDhVkYZVw=; b=lP7UXprTt1su5W58PgDZdAwYPlEKlJgQBRNh9CyH2dExwTGYTjSxpK6TF+/4emginR J/Kp8hCqvDU4b2CntLTPVSqSsc4/IaWmu4TsZ+ArbO5bikGpYHlesAY65U7UpEeagqgt y2CbodCQVsvw4hZ715OCKJFN63xf2S5aqKkTVI7TcKUexOHzawgBqFncH/W1ztcUxMOO NPgQlDERVpmisBdjmKJa+LvKC5sFdgCBAwNyzwWHeKE8Vd2CliPLG+M3yi+Nn9CqAGKm PGtBfgbe+qib8mU9AMCGg8ASkjaTaUpOEBAEBXWuOwVF3igtyW6uHeTj0a5ZO881/yMP 10cg== X-Gm-Message-State: AOAM532iCJLIPsbqu5TtRyL7P2qkc/J1RJjOPIIT/ljpSYREnqtMExZr /ythxr1ZNvLzIRqflosrcakYMQ== X-Google-Smtp-Source: ABdhPJxewUAI8RDxJecgMQqK84dnZDRSuWWALhikOi914YekMnNecZIoiX1AIBCzbrtZ6bBwZBwWpw== X-Received: by 2002:a37:2c02:: with SMTP id s2mr6217893qkh.76.1644242489492; Mon, 07 Feb 2022 06:01:29 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id f4sm5480989qko.72.2022.02.07.06.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 06:01:28 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH4a7-000CyH-Do; Mon, 07 Feb 2022 10:01:27 -0400 Date: Mon, 7 Feb 2022 10:01:27 -0400 From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20220207140127.GA49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-4-hch@lst.de> Subject: Re: [Nouveau] [PATCH 3/8] mm: remove pointless includes from X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Mon, Feb 07, 2022 at 07:32:44AM +0100, Christoph Hellwig wrote: > hmm.h pulls in the world for no good reason at all. Remove the > includes and push a few ones into the users instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 1 + > drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 + > include/linux/hmm.h | 9 ++------- > lib/test_hmm.c | 2 ++ > 4 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3D2FC433EF for ; Mon, 7 Feb 2022 14:01:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 482EB10E4AF; Mon, 7 Feb 2022 14:01:31 +0000 (UTC) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78A1910E4AF for ; Mon, 7 Feb 2022 14:01:30 +0000 (UTC) Received: by mail-qk1-x731.google.com with SMTP id b35so10919186qkp.6 for ; Mon, 07 Feb 2022 06:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+VH5Yzc0FArtBDlyVciKdTaJzlAuXtplA0CDhVkYZVw=; b=TUJuhAgjjswNVQ7JzTkg9iKkOgM430mBd5iaZFyVB8juiwGMelroxSVc/tEeoVjS03 SBBJAs6XyaJLOH0zNh1fMB11MocmBy0vZW3lQVqwc7nmLVkUib5NLDfgXeW1egoLcrUl 0zJ1M9G8GricJAi2JHxOQgJzIsENPf4oXdSlLGMn1ou/GSiwitfE+Re74s2OC3cGYiXS WAB6PyKR8iNz2aNJcgzl/Jv2b00SlxQrNVuEW+ZJ8pyVvgvQpU41dl5hiuO86kWk7vjX 6XluH9RnX42crAJsdacFsF/M+gN0YxPG9aqIQm6tHe1mZG9Uo38/MZ0gAIlPcqFBC8jG 7hCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+VH5Yzc0FArtBDlyVciKdTaJzlAuXtplA0CDhVkYZVw=; b=BYOwM9rlwa56XYIJs0//QdHKShhQ0UMfPQpd1NnkFcHY3D2jJsymaeaj1icHq0mmwh d7kyzZ8oRolP0wqsdU4v42DTVEQiiawRZxLwEzzipUhHjeNO2sbahjW++WACuZ7w+IAX 0HZuqf3RS771vhU+TvVmAfgm9QTzu78q/izsTIIA6X2EIh0wM/16M8fvG9cyRF6I0VJZ EMhmkLROpt3SrnH9MfxzygIsh9thMM8FnX26pbjQlDP+7A7Rhq0NzD6MDjQ2wkirygHZ XNUYH1rdxQsJLgqqZtxoAlMd5uXP0s2Ktq0HsaQ1abJ2KMVqR2dZdBjxHIEmey3qIO5T bHMw== X-Gm-Message-State: AOAM533ldYUQEUGyvxSSjvzgWPKisH+W3DQVntE/Ln7s9pICzOsl+8Ha tfYXGxBCjGIGsCd9MNRmhbKsOQ== X-Google-Smtp-Source: ABdhPJxewUAI8RDxJecgMQqK84dnZDRSuWWALhikOi914YekMnNecZIoiX1AIBCzbrtZ6bBwZBwWpw== X-Received: by 2002:a37:2c02:: with SMTP id s2mr6217893qkh.76.1644242489492; Mon, 07 Feb 2022 06:01:29 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id f4sm5480989qko.72.2022.02.07.06.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 06:01:28 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH4a7-000CyH-Do; Mon, 07 Feb 2022 10:01:27 -0400 Date: Mon, 7 Feb 2022 10:01:27 -0400 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH 3/8] mm: remove pointless includes from Message-ID: <20220207140127.GA49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-4-hch@lst.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, Karol Herbst , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 07, 2022 at 07:32:44AM +0100, Christoph Hellwig wrote: > hmm.h pulls in the world for no good reason at all. Remove the > includes and push a few ones into the users instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 1 + > drivers/gpu/drm/nouveau/nouveau_dmem.c | 1 + > include/linux/hmm.h | 9 ++------- > lib/test_hmm.c | 2 ++ > 4 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Jason Gunthorpe Jason