From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 382302C9C for ; Mon, 7 Feb 2022 19:22:44 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id l14so542569qtp.7 for ; Mon, 07 Feb 2022 11:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yHQiDHxA3qZlcWTxLN1MgZypNnbjTwUZO2QoeiWP/cI=; b=WalR+vjdCg+8zPlO5aZ1ywuN+woRsi3gerM9e8um5R75M05o/0A4tTPV0sDoS0iLf7 MI5Ayh/aUjA3lzGk4knlGcpvrjJkTAzgzCaIVUlu2cLGGSbDhpJ/GrhJhUdc2HnXtmRK stuNg7sUYxLt5HQjP/PwyCP9ZRninXNxW8lX4+8vi6VkUSLgg5BY3Jxg39rH3WH2BDNx g9rpWqR/RtcR0wf2poNmSVgkhRnSCPEG3oCgynxbJlts+OBBSOpC9atYeDDQCpJbBHmV OdyYF8TiYTFFifPNOFO5hE7XJgkPbqKroSw//vj0hDKtL6BLQKT8a9/Jd8uxBZMUHGVb 3Hgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yHQiDHxA3qZlcWTxLN1MgZypNnbjTwUZO2QoeiWP/cI=; b=tO8MTD8yBrvlBpYmSZtAPFvbfUbqhZpcCBQxIB0IYm00CtKENynhhjtcYiiOy07gQN GVb/FMIIHz/We/R0SHdz8+C/znQx3XCIll1dZggIyg4GDT8k93W0YvG7M4optD9QQ4u2 KAWH3PREbPZwgwlAfvPlau+dEi3toDw1h482+AyAgHj5DMMu3MaPDrMdSRS8RgmWW326 fDK2AcypkW7Lk3GhRWqhelFYw+IXpn93aftKOkLtKtY9CNW60P1Z60rYCr1f6bI1lOgS Rf01b12bsMbqrqJtMYEq4D23ikTxeSawRo3PevsvBhJnt2KMQkqEbEPya0pFHdj9O4Ie LPpA== X-Gm-Message-State: AOAM531u9VQ4JDEIyFYo4b4xcqoe5PHpAaMFz/Zl5dj3xvKMmFhQX+ck buzagfJ2jV5irKO7Y4rBB7XAwg== X-Google-Smtp-Source: ABdhPJyusc4Y6UBxGsOMvrtpT2MH3zTc6ABg/OaP0sDSZntIjW01XzJV/gLuVV8p/6/141fWu3yUUA== X-Received: by 2002:a05:622a:1303:: with SMTP id v3mr740294qtk.294.1644261763197; Mon, 07 Feb 2022 11:22:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id y5sm5930001qkp.37.2022.02.07.11.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:22:42 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9b0-000HrC-2F; Mon, 07 Feb 2022 15:22:42 -0400 Date: Mon, 7 Feb 2022 15:22:42 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Andrew Morton , Dan Williams , Felix Kuehling , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, nvdimm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages Message-ID: <20220207192242.GC49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-2-hch@lst.de> On Mon, Feb 07, 2022 at 07:32:42AM +0100, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF3AAC433F5 for ; Mon, 7 Feb 2022 19:22:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AE6810F817; Mon, 7 Feb 2022 19:22:45 +0000 (UTC) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3099E10F80D for ; Mon, 7 Feb 2022 19:22:44 +0000 (UTC) Received: by mail-qt1-x835.google.com with SMTP id b5so12787975qtq.11 for ; Mon, 07 Feb 2022 11:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yHQiDHxA3qZlcWTxLN1MgZypNnbjTwUZO2QoeiWP/cI=; b=WalR+vjdCg+8zPlO5aZ1ywuN+woRsi3gerM9e8um5R75M05o/0A4tTPV0sDoS0iLf7 MI5Ayh/aUjA3lzGk4knlGcpvrjJkTAzgzCaIVUlu2cLGGSbDhpJ/GrhJhUdc2HnXtmRK stuNg7sUYxLt5HQjP/PwyCP9ZRninXNxW8lX4+8vi6VkUSLgg5BY3Jxg39rH3WH2BDNx g9rpWqR/RtcR0wf2poNmSVgkhRnSCPEG3oCgynxbJlts+OBBSOpC9atYeDDQCpJbBHmV OdyYF8TiYTFFifPNOFO5hE7XJgkPbqKroSw//vj0hDKtL6BLQKT8a9/Jd8uxBZMUHGVb 3Hgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yHQiDHxA3qZlcWTxLN1MgZypNnbjTwUZO2QoeiWP/cI=; b=GIUFPorcprtBm4e26Dg7GZbCLzcH8Y1Iu9o7sEzldLu33Opih6K2iWOyKHGJJ8YB8o VvnTHLsxon7OwOAHNV+CFOEWwvsODlK58R2CFakFwjhj9YGQgqtCXvxKbxIe12EiZSIo 2UEMNAlM9XZSxgeqEIk0fmAAS6Y7nf/U8K6qRwL26E1wh1GxyfHhNehUNBOeBsqhgzia ffYtSLKsylB/apruVM47t3glEvd5hB6ltCnLpL4LmOLUNRHI1wif0YSBdk3j+ZOyr1tP 1OgscxIW2EptjXtxqwNcJcXcnO6HuF4LZgIl8tIDt2vHL9VvNzFdeFro1IFUw7J4fDST rCgg== X-Gm-Message-State: AOAM533Vw5LoABZdx+DHZ0DcB3hnxUdQ2QVDPMUERGD5H7WkXqiyY4QQ e2ZgHXyMOHqK1jBGdgsjtotA2Q== X-Google-Smtp-Source: ABdhPJyusc4Y6UBxGsOMvrtpT2MH3zTc6ABg/OaP0sDSZntIjW01XzJV/gLuVV8p/6/141fWu3yUUA== X-Received: by 2002:a05:622a:1303:: with SMTP id v3mr740294qtk.294.1644261763197; Mon, 07 Feb 2022 11:22:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id y5sm5930001qkp.37.2022.02.07.11.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:22:42 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9b0-000HrC-2F; Mon, 07 Feb 2022 15:22:42 -0400 Date: Mon, 7 Feb 2022 15:22:42 -0400 From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20220207192242.GC49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-2-hch@lst.de> Subject: Re: [Nouveau] [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Mon, Feb 07, 2022 at 07:32:42AM +0100, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80AC7C433FE for ; Mon, 7 Feb 2022 19:22:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9119910F848; Mon, 7 Feb 2022 19:22:45 +0000 (UTC) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50C6E10F848 for ; Mon, 7 Feb 2022 19:22:44 +0000 (UTC) Received: by mail-qt1-x82b.google.com with SMTP id l14so542573qtp.7 for ; Mon, 07 Feb 2022 11:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yHQiDHxA3qZlcWTxLN1MgZypNnbjTwUZO2QoeiWP/cI=; b=WalR+vjdCg+8zPlO5aZ1ywuN+woRsi3gerM9e8um5R75M05o/0A4tTPV0sDoS0iLf7 MI5Ayh/aUjA3lzGk4knlGcpvrjJkTAzgzCaIVUlu2cLGGSbDhpJ/GrhJhUdc2HnXtmRK stuNg7sUYxLt5HQjP/PwyCP9ZRninXNxW8lX4+8vi6VkUSLgg5BY3Jxg39rH3WH2BDNx g9rpWqR/RtcR0wf2poNmSVgkhRnSCPEG3oCgynxbJlts+OBBSOpC9atYeDDQCpJbBHmV OdyYF8TiYTFFifPNOFO5hE7XJgkPbqKroSw//vj0hDKtL6BLQKT8a9/Jd8uxBZMUHGVb 3Hgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yHQiDHxA3qZlcWTxLN1MgZypNnbjTwUZO2QoeiWP/cI=; b=hI2r4EIUbmu41s86hiEPsLapQDwgqGqHlh6OuXEW6O928/1PEm8VZRIFT0NNT3E2V6 rm/FDXVAzHFuRC4kkfsOdLCg4m0SkquY6Xcfk7ph4hwNGBcSoERwXiKSIYmgywtfP/0i eR2tJ1w1I/135D4SLdfIaqSPxdz9stm/aV9jJMZsttpoX6ogAG2fNNCN0rF/FrUbBijC xGr3nGDGOOOFCS2BIOAIviEeGrb4m3czBg7Z6u/5m9SNoeGcpCbNCkQPOsSCDMEf4wjm 2f3S9po+KQ9/OESKit7iy+ezLvu+4Z9luXxx0YqJyJVFxTDuOOziBGSNVIWA352iha28 z4+w== X-Gm-Message-State: AOAM532ntdc9VHebQH+2JLfnNYCqInklJnUnoBE24CjOpfob+fEEr+JB OpS/oycCTGSH9/EiTM11uJINrg== X-Google-Smtp-Source: ABdhPJyusc4Y6UBxGsOMvrtpT2MH3zTc6ABg/OaP0sDSZntIjW01XzJV/gLuVV8p/6/141fWu3yUUA== X-Received: by 2002:a05:622a:1303:: with SMTP id v3mr740294qtk.294.1644261763197; Mon, 07 Feb 2022 11:22:43 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id y5sm5930001qkp.37.2022.02.07.11.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:22:42 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9b0-000HrC-2F; Mon, 07 Feb 2022 15:22:42 -0400 Date: Mon, 7 Feb 2022 15:22:42 -0400 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages Message-ID: <20220207192242.GC49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-2-hch@lst.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, Karol Herbst , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 07, 2022 at 07:32:42AM +0100, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason