From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EAF62C9C for ; Mon, 7 Feb 2022 19:34:59 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id j12so12862719qtr.2 for ; Mon, 07 Feb 2022 11:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9c7vpxYS+6RnfIRFWhHgAcQnmpWWsCXDoIZ8HfcxKVk=; b=eyrwc8BMMdOVC7JxxbPkKv0E+7XYg1mWVnxya1gkeBbn+6FIIKA4h5dIP4xxQ6Lyue PP3XS1TlpffXxqvfwJvChxVJKrRaJ4INlob/J3j8V4nhPl1/nALzUS4bebpDgN+o/Aus QQg2zEZcdkmCLgeogf4eYK3AO+nmond0PimC6gBZEbdgCdCPZ88/G1CIEJ9vhbSZK4os tk4KtyYHQy6WXksXzSrn8f5eOqxd/45+LU03LL1E7V5s7Z/zSb/UfyVa4YpBFVPoHCin OF1OweCzorEMyWiZQI+JHPsC+t/W26GR57RXRrAWC89poKcjeNO3WJ+VmGSwbNpLPdn4 ljZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9c7vpxYS+6RnfIRFWhHgAcQnmpWWsCXDoIZ8HfcxKVk=; b=BIOkCCq5iraD94mr6AEWP1k5O239GJQ9gVu1PMsU162Hwj2u7CflhLDgoUeVB08Nto NH8L5ibxnvaAhcfFqL9jxBuJD4X899vBY/qoiqjLw1x1nXaNs5e+cLBN2KbXfnFOlVPu yOrZh56ThDhx6pqY/DfvEB14AnkYx0dpe5h7KRwFIm00eOXar/yv9hc4kMmIOw+LS7Y6 pPoOOGafzk0UQlvit+xUnLNdkwWpPSGdVAImN4T1cOCr8OQl4inHdE7ojx+q6IVb85pj E9au0LiPevffL2pfBA9xdL6imgBUiWpTYON1nGyS/aFLWKuhpN6ARKMzTP4ulULsH6QL ZXWA== X-Gm-Message-State: AOAM532GuovTTCk0ibxt2sCIJU0XWckDP+z9WTutObrl8gyQwdolTNXT tnyDHKLDVddMu3CXFrpYzTuNTg== X-Google-Smtp-Source: ABdhPJyvD659xk5KRCKkhy7N4LjGPrkEHjwUHp/EZt//+nT6eRHPcHoug24DbpSsFF9r7utyh5WJCw== X-Received: by 2002:ac8:7507:: with SMTP id u7mr761226qtq.518.1644262498222; Mon, 07 Feb 2022 11:34:58 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id o18sm6033304qkp.26.2022.02.07.11.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:34:57 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9mq-000I5O-UX; Mon, 07 Feb 2022 15:34:56 -0400 Date: Mon, 7 Feb 2022 15:34:56 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Andrew Morton , Dan Williams , Felix Kuehling , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, nvdimm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages Message-ID: <20220207193456.GF49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-6-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-6-hch@lst.de> On Mon, Feb 07, 2022 at 07:32:46AM +0100, Christoph Hellwig wrote: > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 34 ++++++++++------------------------ > mm/memremap.c | 20 +++++++++----------- > mm/swap.c | 10 +--------- > 3 files changed, 20 insertions(+), 44 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3EA5C433F5 for ; Mon, 7 Feb 2022 19:35:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0CBBE10E48E; Mon, 7 Feb 2022 19:35:00 +0000 (UTC) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0130D10E48E for ; Mon, 7 Feb 2022 19:34:58 +0000 (UTC) Received: by mail-qt1-x835.google.com with SMTP id z1so12874439qto.3 for ; Mon, 07 Feb 2022 11:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9c7vpxYS+6RnfIRFWhHgAcQnmpWWsCXDoIZ8HfcxKVk=; b=eyrwc8BMMdOVC7JxxbPkKv0E+7XYg1mWVnxya1gkeBbn+6FIIKA4h5dIP4xxQ6Lyue PP3XS1TlpffXxqvfwJvChxVJKrRaJ4INlob/J3j8V4nhPl1/nALzUS4bebpDgN+o/Aus QQg2zEZcdkmCLgeogf4eYK3AO+nmond0PimC6gBZEbdgCdCPZ88/G1CIEJ9vhbSZK4os tk4KtyYHQy6WXksXzSrn8f5eOqxd/45+LU03LL1E7V5s7Z/zSb/UfyVa4YpBFVPoHCin OF1OweCzorEMyWiZQI+JHPsC+t/W26GR57RXRrAWC89poKcjeNO3WJ+VmGSwbNpLPdn4 ljZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9c7vpxYS+6RnfIRFWhHgAcQnmpWWsCXDoIZ8HfcxKVk=; b=rQAYu/BlM7AR3V5d4Hwf0J4Bpka/Mw0BwMYgpuZE1jTia8Ci1hoViKzTzalpcb9OYP XftCO3tLovdNMiVEv2XOxGdW32qCKsWjdCSrMMIdT1CXyzd8rxyyK2zmsafTYvE8HfQv wB2pTTCZaM9HXiTs5tvMAgGdNEjozbIx/bras5rG/gdvysaYegPbU0rQZ13myxXGaHg5 WSPRcn/kPPtUAPDTpYra1OveoHxJvNbllGpR+/lPBl7SSr8TkhHJgt5J/sDDNj/2KF5Q akKXlMdz6L24ju3WPy9LNTXEThonw2hJlEXM8/9e4Xo9A85CyV+lv7RE4Rs3NKBIEMh8 cBSQ== X-Gm-Message-State: AOAM5316ynTDvzBiv1vKOPBxZJCVRqOLlhMcPSqp8oyDUAXw822gcaPm x/WezJdUIyQMVTVCIT2d7DCv5w== X-Google-Smtp-Source: ABdhPJyvD659xk5KRCKkhy7N4LjGPrkEHjwUHp/EZt//+nT6eRHPcHoug24DbpSsFF9r7utyh5WJCw== X-Received: by 2002:ac8:7507:: with SMTP id u7mr761226qtq.518.1644262498222; Mon, 07 Feb 2022 11:34:58 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id o18sm6033304qkp.26.2022.02.07.11.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:34:57 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9mq-000I5O-UX; Mon, 07 Feb 2022 15:34:56 -0400 Date: Mon, 7 Feb 2022 15:34:56 -0400 From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20220207193456.GF49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-6-hch@lst.de> Subject: Re: [Nouveau] [PATCH 5/8] mm: simplify freeing of devmap managed pages X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Mon, Feb 07, 2022 at 07:32:46AM +0100, Christoph Hellwig wrote: > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 34 ++++++++++------------------------ > mm/memremap.c | 20 +++++++++----------- > mm/swap.c | 10 +--------- > 3 files changed, 20 insertions(+), 44 deletions(-) Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76D55C433FE for ; Mon, 7 Feb 2022 19:35:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B39410F4DA; Mon, 7 Feb 2022 19:35:00 +0000 (UTC) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ED8310F4DA for ; Mon, 7 Feb 2022 19:34:59 +0000 (UTC) Received: by mail-qt1-x829.google.com with SMTP id o3so12823079qtm.12 for ; Mon, 07 Feb 2022 11:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9c7vpxYS+6RnfIRFWhHgAcQnmpWWsCXDoIZ8HfcxKVk=; b=eyrwc8BMMdOVC7JxxbPkKv0E+7XYg1mWVnxya1gkeBbn+6FIIKA4h5dIP4xxQ6Lyue PP3XS1TlpffXxqvfwJvChxVJKrRaJ4INlob/J3j8V4nhPl1/nALzUS4bebpDgN+o/Aus QQg2zEZcdkmCLgeogf4eYK3AO+nmond0PimC6gBZEbdgCdCPZ88/G1CIEJ9vhbSZK4os tk4KtyYHQy6WXksXzSrn8f5eOqxd/45+LU03LL1E7V5s7Z/zSb/UfyVa4YpBFVPoHCin OF1OweCzorEMyWiZQI+JHPsC+t/W26GR57RXRrAWC89poKcjeNO3WJ+VmGSwbNpLPdn4 ljZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9c7vpxYS+6RnfIRFWhHgAcQnmpWWsCXDoIZ8HfcxKVk=; b=RZHkiXiF9X6ylww2pQooeRm+zbrmN1Pq9YGuR3edu8sIgyV8/CMuO43jqkjvV9Y31v Gq9SMRx6fyt6QHdOwLj0AaHl+E4XPb3Ro6xssYgDr9HXKWIKTX8ITFvx7viJH+U6OLWL AF4r/It31oibBvUZcKGdYhxLv20trbrseDi1Cck6jNeHSG+Q6cu0qHzEqq8PW9uE4NMV mQI6hThII5z2uUlo7B3mE2WLimWAW/ViVwWq+zVd58mOb0gSRoyHwkSNaNAWzXMsubSA ljUIhyoXpGjEnf6C+TdJmO+JUZJTs9gX0MStE6Eotscn4qsHiO/raWjgigXwihS5h/H9 TFvA== X-Gm-Message-State: AOAM532NMvgU0UKds2Tg0CNBOS9n5j7pRAdwXO3rpDjXAqNIbjOaYjLi QXvhjOj23Hyo7QFjAtufxf3i0A== X-Google-Smtp-Source: ABdhPJyvD659xk5KRCKkhy7N4LjGPrkEHjwUHp/EZt//+nT6eRHPcHoug24DbpSsFF9r7utyh5WJCw== X-Received: by 2002:ac8:7507:: with SMTP id u7mr761226qtq.518.1644262498222; Mon, 07 Feb 2022 11:34:58 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id o18sm6033304qkp.26.2022.02.07.11.34.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Feb 2022 11:34:57 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nH9mq-000I5O-UX; Mon, 07 Feb 2022 15:34:56 -0400 Date: Mon, 7 Feb 2022 15:34:56 -0400 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages Message-ID: <20220207193456.GF49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220207063249.1833066-6-hch@lst.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , Alistair Popple , dri-devel@lists.freedesktop.org, Karol Herbst , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Dan Williams Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 07, 2022 at 07:32:46AM +0100, Christoph Hellwig wrote: > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 34 ++++++++++------------------------ > mm/memremap.c | 20 +++++++++----------- > mm/swap.c | 10 +--------- > 3 files changed, 20 insertions(+), 44 deletions(-) Reviewed-by: Jason Gunthorpe Jason