All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Joe Perches" <joe@perches.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages
Date: Mon, 7 Feb 2022 20:44:21 +0000	[thread overview]
Message-ID: <20220207204421.7f905aa5@jic23-huawei> (raw)
In-Reply-To: <YgFVFceYQtWq4Hww@smile.fi.intel.com>

On Mon, 7 Feb 2022 19:21:25 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Feb 07, 2022 at 08:37:55AM -0800, Joe Perches wrote:
> > On Mon, 2022-02-07 at 12:48 +0200, Andy Shevchenko wrote:  
> > > In a couple of messages the constants, which have their definitions,
> > > are hard coded into the message text. Unhardcode them.  
> > 
> > Found by inspection or tool?  
> 
> Does it matter? No, a side effect of the following patch.
> 
> ...
> 
> > > +		dev_err(dev, "Steinhart sensors size(%zu) must be %d", new_custom->size,
> > > +			LTC2983_CUSTOM_STEINHART_SIZE);  
> > 
> > probably better using "%u" and not "%d"
> > 
> > and better with a \n termination too.  
> 
> I think it would be a separate change if we wish so. Let Jonathan to tell what
> to do here.
> 
Either way is fine by me.  I tend to be a little flexible of trivial fixes
in patches that are as simple as this one.

Thanks,

Jonathan



  parent reply	other threads:[~2022-02-07 20:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 10:48 [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Andy Shevchenko
2022-02-07 10:48 ` [PATCH v2 2/3] iio: temperature: ltc2983: Use single error path to put OF node Andy Shevchenko
2022-02-07 10:48 ` [PATCH v2 3/3] iio: temperature: ltc2983: Make use of device properties Andy Shevchenko
2022-02-07 16:37 ` [PATCH v2 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Joe Perches
2022-02-07 17:21   ` Andy Shevchenko
2022-02-07 17:29     ` Joe Perches
2022-02-07 20:44     ` Jonathan Cameron [this message]
2022-02-10 13:54       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220207204421.7f905aa5@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=joe@perches.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.