All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Terry Bowman <terry.bowman@amd.com>,
	linux@roeck-us.net, linux-watchdog@vger.kernel.org,
	linux-i2c@vger.kernel.org, andy.shevchenko@gmail.com,
	rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
	wim@linux-watchdog.org, rrichter@amd.com,
	thomas.lendacky@amd.com, sudheesh.mavila@amd.com,
	Nehal-bakulchandra.Shah@amd.com, Basavaraj.Natikar@amd.com,
	Shyam-sundar.S-k@amd.com, Mario.Limonciello@amd.com
Subject: Re: [PATCH v4 0/4] Watchdog: sp5100_tco: Replace cd6h/cd7h port I/O accesses with MMIO accesses
Date: Tue, 8 Feb 2022 15:20:25 +0100	[thread overview]
Message-ID: <20220208152025.00d8e7ec@endymion.delvare> (raw)
In-Reply-To: <YgI/P754rQyA9bpM@ninjato>

On Tue, 8 Feb 2022 11:00:31 +0100, Wolfram Sang wrote:
> > I'm still reviewing these, sorry. I only picked the first patch of the
> > series so that the sp5100_tco patches would build so I could test them.  
> 
> Ah, I see. I thought more than the first patch was needed for testing.

You need the full series to be on the safe side, otherwise there's a
risk that the two drivers will access the same registers using
different methods (legacy I/O vs MMIO) so there's no synchronization
and they could step on each other's toes.

However as I knew about this limitation, I was careful to not use the
SMBus driver while I was testing the watchdog driver :-)

-- 
Jean Delvare
SUSE L3 Support

      reply	other threads:[~2022-02-08 14:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-30 19:12 [PATCH v4 0/4] Watchdog: sp5100_tco: Replace cd6h/cd7h port I/O accesses with MMIO accesses Terry Bowman
2022-01-30 19:12 ` [PATCH v4 1/4] Watchdog: sp5100_tco: Move timer initialization into function Terry Bowman
2022-01-30 19:12 ` [PATCH v4 2/4] Watchdog: sp5100_tco: Refactor MMIO base address initialization Terry Bowman
2022-01-31  2:52   ` kernel test robot
2022-01-31  2:52     ` kernel test robot
2022-01-31  3:13   ` kernel test robot
2022-01-31  3:13     ` kernel test robot
2022-02-01 15:31   ` Guenter Roeck
2022-02-01 16:46     ` Terry Bowman
2022-02-01 20:32       ` Terry Bowman
2022-02-01 22:36         ` Guenter Roeck
2022-01-30 19:12 ` [PATCH v4 3/4] Watchdog: sp5100_tco: Add initialization using EFCH MMIO Terry Bowman
2022-01-31  5:37   ` kernel test robot
2022-01-31  5:37     ` kernel test robot
2022-01-31  5:58   ` kernel test robot
2022-01-31  5:58     ` kernel test robot
2022-01-30 19:12 ` [PATCH v4 4/4] Watchdog: sp5100_tco: Enable Family 17h+ CPUs Terry Bowman
2022-02-07 12:44 ` [PATCH v4 0/4] Watchdog: sp5100_tco: Replace cd6h/cd7h port I/O accesses with MMIO accesses Jean Delvare
2022-02-07 13:03   ` Wolfram Sang
2022-02-08  9:45     ` Jean Delvare
2022-02-08 10:00       ` Wolfram Sang
2022-02-08 14:20         ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220208152025.00d8e7ec@endymion.delvare \
    --to=jdelvare@suse.de \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Mario.Limonciello@amd.com \
    --cc=Nehal-bakulchandra.Shah@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rrichter@amd.com \
    --cc=sudheesh.mavila@amd.com \
    --cc=terry.bowman@amd.com \
    --cc=thomas.lendacky@amd.com \
    --cc=wim@linux-watchdog.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.