From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A04412C80 for ; Wed, 9 Feb 2022 06:23:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 87E2668AFE; Wed, 9 Feb 2022 07:23:45 +0100 (CET) Date: Wed, 9 Feb 2022 07:23:45 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , Andrew Morton , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209062345.GB7739@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Feb 08, 2022 at 07:30:11PM -0800, Dan Williams wrote: > Interesting. I had expected that to really fix the refcount problem > that fs/dax.c would need to start taking real page references as pages > were added to a mapping, just like page cache. I think we should do that eventually. But I think this series that just attacks the device private type and extends to the device coherent and p2p enhacements is a good first step to stop the proliferation of the one off refcount and to allow to deal with the fsdax pages in another more focuessed series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD56CC433F5 for ; Wed, 9 Feb 2022 06:23:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A87210E364; Wed, 9 Feb 2022 06:23:50 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CBAE10E364; Wed, 9 Feb 2022 06:23:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 87E2668AFE; Wed, 9 Feb 2022 07:23:45 +0100 (CET) Date: Wed, 9 Feb 2022 07:23:45 +0100 From: Christoph Hellwig To: Dan Williams Message-ID: <20220209062345.GB7739@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Nouveau] [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Christian =?iso-8859-1?Q?K=F6nig?= , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Christoph Hellwig Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Tue, Feb 08, 2022 at 07:30:11PM -0800, Dan Williams wrote: > Interesting. I had expected that to really fix the refcount problem > that fs/dax.c would need to start taking real page references as pages > were added to a mapping, just like page cache. I think we should do that eventually. But I think this series that just attacks the device private type and extends to the device coherent and p2p enhacements is a good first step to stop the proliferation of the one off refcount and to allow to deal with the fsdax pages in another more focuessed series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C95DC433EF for ; Wed, 9 Feb 2022 09:21:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D3C210E689; Wed, 9 Feb 2022 09:21:51 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CBAE10E364; Wed, 9 Feb 2022 06:23:48 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 87E2668AFE; Wed, 9 Feb 2022 07:23:45 +0100 (CET) Date: Wed, 9 Feb 2022 07:23:45 +0100 From: Christoph Hellwig To: Dan Williams Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209062345.GB7739@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Wed, 09 Feb 2022 09:21:49 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Karol Herbst , Linux MM , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Christian =?iso-8859-1?Q?K=F6nig?= , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Christoph Hellwig Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Feb 08, 2022 at 07:30:11PM -0800, Dan Williams wrote: > Interesting. I had expected that to really fix the refcount problem > that fs/dax.c would need to start taking real page references as pages > were added to a mapping, just like page cache. I think we should do that eventually. But I think this series that just attacks the device private type and extends to the device coherent and p2p enhacements is a good first step to stop the proliferation of the one off refcount and to allow to deal with the fsdax pages in another more focuessed series.