From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A980FC433EF for ; Wed, 9 Feb 2022 12:32:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 479E683D52; Wed, 9 Feb 2022 13:32:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ua7kfBFM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CA7F083E1D; Wed, 9 Feb 2022 13:32:26 +0100 (CET) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7CF2483D00 for ; Wed, 9 Feb 2022 13:32:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id j24so1386878qkk.10 for ; Wed, 09 Feb 2022 04:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zgiernIUPyMzP9ov2P9KUnYueHqYxFbvMCXG3N7FI8I=; b=Ua7kfBFM4Q2oEm588naJGwQCvO+YSJlufB5A8ej5E57e3Y2mG6HPA/0znwDUTrQv+5 0BV57iKG006XYNn7/AyhwSHsQhwVCqaNZqkDa6He8s3sFf/Ey6p6vaLFX2dQJVyMPudf rinQs/7QVYhvi2B9/zbbWZPH6AAoCeOgwmxa8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zgiernIUPyMzP9ov2P9KUnYueHqYxFbvMCXG3N7FI8I=; b=61tBr9nSlKuZKN+mcti7mCrUZApSF2TZHOt1fBNV1LBlzQL89KZesAO2kCHG3io3E7 XJzG+epBm7HF/BJ39jhEAOUsXbWAd5Auhz8ANow/wCJhig/oeIVBVQr49x1KG42gDatf Cw2DhrwQ4W5i+RUjrlOMQlKHOX5CaK7beLTZurrjoTpMTZrUWfWf9rXzLcpgSKSLeSeK CyXTKlBUL+nncCZdli6KebaeUfmi1XgOjkemEdzu+tofE0d3fakEfOdRFBQGPNy7iCHt p9ToI+xjLempJRkKMehuLgspJ1ARS8GcLRyGwiEsYsPAT5T0J2W5CR8qNGP+qiv18KLA mErA== X-Gm-Message-State: AOAM530inqoa+pJWaU9mQel4CrhvGrgfCTUqKT4+7TE+0EI7+adzEucI L1tJIZY2wDE0qBlXuG7m6HoiKA== X-Google-Smtp-Source: ABdhPJxkWtLDp2ViaulagzpbFUjWXDdUmf3i5/64ABh+JE7qO1ila8ZL6snMv/SmM0Q5XFtHANT40A== X-Received: by 2002:a37:a149:: with SMTP id k70mr874089qke.161.1644409942129; Wed, 09 Feb 2022 04:32:22 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id o3sm8989391qtw.3.2022.02.09.04.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 04:32:21 -0800 (PST) Date: Wed, 9 Feb 2022 07:32:19 -0500 From: Tom Rini To: Adam Ford Cc: Simon Glass , U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files Message-ID: <20220209123219.GZ7515@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zL7/4+3/7UwZUZ29" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --zL7/4+3/7UwZUZ29 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrote: > > > > Move the header file into the main include/ directory so we can use it > > from the bootmethod code. Move the C file into boot/ since it relates to > > booting. > > > +cc lokeshvutla@ti.com >=20 > Simon, >=20 > I can't explain why, but with git bisect, it appears this patch breaks > my omap3_logic board (DM3730) by making it wrongly think there is 4GB > of RAM, when in reality there is only 256MB. We have both 256MB and > 512MB parts, and the automatic memory detection has always 'just > worked' in the past. >=20 > With this patch now, I see: > U-Boot 2022.01-rc1-00185-g262cfb5b15 (Feb 09 2022 - 05:23:42 -0600) >=20 > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > DRAM: 4 GiB > >=20 > With the previous commit, 8018b9af57b5 ("pxe: Tidy up the is_pxe > global"), it properly detects the RAM and fully boots. >=20 > U-Boot 2022.01-rc1-00184-g8018b9af57 (Feb 09 2022 - 05:21:39 -0600) >=20 > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > DRAM: 256 MiB > NAND: 512 MiB > MMC: OMAP SD/MMC: 0 > Loading Environment from NAND... OK > OMAP die ID: 619e00029ff800000168300f1502501f > Net: eth0: ethernet@08000000 > Hit any key to stop autoboot: 0 > OMAP Logic # >=20 > I have CONFIG_CMD_BOOTM, CONFIG_CMD_PXE and CONFIG_CMD_SYSBOOT all > defined, so I am having a hard time understanding why this would > change behavior or stomp on the the structure that knows the memory > size. >=20 > If I jump ahead to the current 'master' 531c0089457:("Merge branch > '2022-02-08-TI-platform-updates') and revert this patch, my board > boots correctly again, but I am struggling to understand why. >=20 > Do you have any suggestions for me to try? I would suggest objdump disassemble U-Boot before/after and see what functions have changed. --=20 Tom --zL7/4+3/7UwZUZ29 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIDtFMACgkQFHw5/5Y0 tyzSLgv+KM3Zr+pRRs43PeLxswTDvavdhbOGgFWw+kvZkb01n1MFXSUyMvvRW5mg Z4HtjAyevh6Xy679nQtE2NM52qWOdd+w4ToZl2iU2PqJOp6VUmP6c16rKw1hlLZs iqNJ7TuutYQ13xFFABehZYYK/jACJLFIFUw63rNHJMG0JRSXBXJCaUbHnLNcHRoI jPeRrFJpyodPTXZJfkpOVVBDmVnIOng22EN9CZNXiaGFzhPgTWn4rPdzXfb/OShi fMxAuHaib6KSeOn0jqbs2yTytGztNut1btSytlpaVdEjUIhXayPxWAqYSAU/rQM1 PlcuSHq7otoTNCzEVJWNPPlAKEehzCjxHbQB5YXQY1fAieMShFj6mllT6woVtrLz e1kNBTMrY9CD3c70+scYogbv13vATEIw0+fLLJfEQI657Y5qyAYxVRIPSl2Bi8NA 4LwItdQ0kAIAMxtcG+DtW3VyW265o6rCZoqbadPPq+qwDILT16S0bjgvtCpEKKqW rqOO3E1k =vb93 -----END PGP SIGNATURE----- --zL7/4+3/7UwZUZ29--