From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D25B029CA for ; Wed, 9 Feb 2022 13:54:01 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D733867373; Wed, 9 Feb 2022 14:53:51 +0100 (CET) Date: Wed, 9 Feb 2022 14:53:51 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Dan Williams , Andrew Morton , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209135351.GA20631@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209122956.GI49147@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > It is nice, but the other series are still impacted by the fsdax mess > - they still stuff pages into ptes without proper refcounts and have > to carry nonsense to dance around this problem. > > I certainly would be unhappy if the amd driver, for instance, gained > the fsdax problem as well and started pushing 4k pages into PMDs. As said before: I think this all needs to be fixed. But I'd rather fix it gradually and I think this series is a nice step forward. After that we can look at the pte mappings. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDA7FC433EF for ; Wed, 9 Feb 2022 13:53:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0580310E478; Wed, 9 Feb 2022 13:53:57 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id D921210E478; Wed, 9 Feb 2022 13:53:55 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D733867373; Wed, 9 Feb 2022 14:53:51 +0100 (CET) Date: Wed, 9 Feb 2022 14:53:51 +0100 From: Christoph Hellwig To: Jason Gunthorpe Message-ID: <20220209135351.GA20631@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209122956.GI49147@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Nouveau] [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maling list - DRI developers , Linux NVDIMM , Ralph Campbell , Alistair Popple , Andrew Morton , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Christian =?iso-8859-1?Q?K=F6nig?= , Linux MM , Ben Skeggs , Alex Deucher , Dan Williams , Logan Gunthorpe , Christoph Hellwig Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > It is nice, but the other series are still impacted by the fsdax mess > - they still stuff pages into ptes without proper refcounts and have > to carry nonsense to dance around this problem. > > I certainly would be unhappy if the amd driver, for instance, gained > the fsdax problem as well and started pushing 4k pages into PMDs. As said before: I think this all needs to be fixed. But I'd rather fix it gradually and I think this series is a nice step forward. After that we can look at the pte mappings. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08982C43219 for ; Wed, 9 Feb 2022 14:07:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 873B910E590; Wed, 9 Feb 2022 14:07:13 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id D921210E478; Wed, 9 Feb 2022 13:53:55 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D733867373; Wed, 9 Feb 2022 14:53:51 +0100 (CET) Date: Wed, 9 Feb 2022 14:53:51 +0100 From: Christoph Hellwig To: Jason Gunthorpe Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209135351.GA20631@lst.de> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209122956.GI49147@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Wed, 09 Feb 2022 14:07:12 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maling list - DRI developers , Linux NVDIMM , Ralph Campbell , Alistair Popple , Andrew Morton , Karol Herbst , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Christian =?iso-8859-1?Q?K=F6nig?= , Linux MM , Ben Skeggs , Alex Deucher , Dan Williams , Logan Gunthorpe , Christoph Hellwig Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > It is nice, but the other series are still impacted by the fsdax mess > - they still stuff pages into ptes without proper refcounts and have > to carry nonsense to dance around this problem. > > I certainly would be unhappy if the amd driver, for instance, gained > the fsdax problem as well and started pushing 4k pages into PMDs. As said before: I think this all needs to be fixed. But I'd rather fix it gradually and I think this series is a nice step forward. After that we can look at the pte mappings.