From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DAF2F28 for ; Wed, 9 Feb 2022 14:14:29 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id g145so1673722qke.3 for ; Wed, 09 Feb 2022 06:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c8BMy3fH62yXJxfHY+j4P80h5ALqrjcvX+ObTuKf0iA=; b=V7onSa8ruWkEtkdB8irRTbQO5EhI5+EN5mjt3u01+vlKyYcQfcNp9aFh92tP1OzUTh ScFSSPOJZDc270JM0jq7Rhgv2t8FwpCHJ20+6gStJqzqZxWKPGAiZe6G30wozCGKb6G+ ZLQWTS1Ro4hAfH5OwcrYeqPEFEKYoHUMzawcDJx2RgUNBo1ohb8nkxONIHkbUDMBpr5o apeGjKCH5BBxtNM0aA8Q1I0DV6rlydLedHpS7mVvMx/qFqliS9UfDYoHrCMy5D2aCL3F 0jecgeDZDBF6tjcMyMnIYAGizQnperLp47omGbCJq3v5uCCpJ63E6XzU+sfOUF4jG60Y /F8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c8BMy3fH62yXJxfHY+j4P80h5ALqrjcvX+ObTuKf0iA=; b=aNcKL0Hm/BztV/Q7oo1A0Z3k+q4B7ht+f2BsGZPyZYfn1GAb3IQajd825DHcKCLG5F UrB42QK2IM8TXUmZPdhQetoDafwJZaT7pJ7dSE39buaOTO8DHWBV2RZYRRPwFLd/sBhd V5+e8o7w79AX6mSyTH9KYol6eCMNIQUEa5ug16psdrl5EPurBnjubQyw6oagX28hidig w0+oLU0KbKL5qeoPrgUTlGgkVa6r9wz3Z1MJmXSwruMghRK7wcOau/iKWANPWM9gJeRp KwogOCwuUCd1s7ae3NhzuZjdqu6Wk+H5baDaccEnE/JXeioxTcahZUa+dmMizKlT8YLj 9kyg== X-Gm-Message-State: AOAM531XJoIN+Tbqu2sglQfsS0Dxwn8LUK1ry3ZZd3FAxQeiB49JW3m1 Hy1IKBCAeuw+Vuqaod77yt8s2g== X-Google-Smtp-Source: ABdhPJzQ+iaZjCKRuCc0J8n0Ck+TXJ7O0pFZ7w0y3yYzv/vscWA+Im2JaGH4eENvWOVqnzWKMTNFCg== X-Received: by 2002:a05:620a:1351:: with SMTP id c17mr1137673qkl.460.1644416068212; Wed, 09 Feb 2022 06:14:28 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id a14sm9094374qtb.92.2022.02.09.06.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 06:14:27 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nHnjn-001FdR-1z; Wed, 09 Feb 2022 10:14:27 -0400 Date: Wed, 9 Feb 2022 10:14:27 -0400 From: Jason Gunthorpe To: Christoph Hellwig Cc: Dan Williams , Andrew Morton , Felix Kuehling , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Alistair Popple , Logan Gunthorpe , Ralph Campbell , Linux Kernel Mailing List , amd-gfx list , Maling list - DRI developers , nouveau@lists.freedesktop.org, Linux NVDIMM , Linux MM Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209141427.GJ49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> <20220209135351.GA20631@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209135351.GA20631@lst.de> On Wed, Feb 09, 2022 at 02:53:51PM +0100, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > > It is nice, but the other series are still impacted by the fsdax mess > > - they still stuff pages into ptes without proper refcounts and have > > to carry nonsense to dance around this problem. > > > > I certainly would be unhappy if the amd driver, for instance, gained > > the fsdax problem as well and started pushing 4k pages into PMDs. > > As said before: I think this all needs to be fixed. But I'd rather > fix it gradually and I think this series is a nice step forward. > After that we can look at the pte mappings. Right, I agree with this Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFC19C433FE for ; Wed, 9 Feb 2022 14:14:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4184A10E562; Wed, 9 Feb 2022 14:14:30 +0000 (UTC) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 438E110E562 for ; Wed, 9 Feb 2022 14:14:29 +0000 (UTC) Received: by mail-qk1-x72a.google.com with SMTP id j24so1640754qkk.10 for ; Wed, 09 Feb 2022 06:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c8BMy3fH62yXJxfHY+j4P80h5ALqrjcvX+ObTuKf0iA=; b=V7onSa8ruWkEtkdB8irRTbQO5EhI5+EN5mjt3u01+vlKyYcQfcNp9aFh92tP1OzUTh ScFSSPOJZDc270JM0jq7Rhgv2t8FwpCHJ20+6gStJqzqZxWKPGAiZe6G30wozCGKb6G+ ZLQWTS1Ro4hAfH5OwcrYeqPEFEKYoHUMzawcDJx2RgUNBo1ohb8nkxONIHkbUDMBpr5o apeGjKCH5BBxtNM0aA8Q1I0DV6rlydLedHpS7mVvMx/qFqliS9UfDYoHrCMy5D2aCL3F 0jecgeDZDBF6tjcMyMnIYAGizQnperLp47omGbCJq3v5uCCpJ63E6XzU+sfOUF4jG60Y /F8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c8BMy3fH62yXJxfHY+j4P80h5ALqrjcvX+ObTuKf0iA=; b=WezeJbDyOYs2HG4+ecSBkyEYIqwi8dE6ce/EQxfYWwtZGdpIv7Icb1CyniTNh12u0J e4HjPMoscATFQ+BkhdvFpvpM+1N3iGCeOPgGSRRWHyi8vodEW9JXUO1HTasgMZQJ8tt/ E+SD7huj4qbABEjeIcQ0sg8gc/Q54VveqlkCH19tPEdP7Ks0B8gEaSrcu7XvERQWayS/ i1oMYNcaEaIa/Rwwlu+wpS+Qrusfw1EnDL5ZkQ9DkzIGGNjplUZRqMbbg4D1zVAGnX/Q xJhJVvwz60nQZFrxjpm91gyQsVnDFxdveyFB/Go1Fu1F0c9H0/w7bhDUoj79W6QC97Rm xwHg== X-Gm-Message-State: AOAM532XNSAaJMYbMV9fE44eRJBJHuJS3iQnwTK/g+2XNVnej3lqFI9i rxMY8iocjtE5Neh8o8kxoZF4Tw== X-Google-Smtp-Source: ABdhPJzQ+iaZjCKRuCc0J8n0Ck+TXJ7O0pFZ7w0y3yYzv/vscWA+Im2JaGH4eENvWOVqnzWKMTNFCg== X-Received: by 2002:a05:620a:1351:: with SMTP id c17mr1137673qkl.460.1644416068212; Wed, 09 Feb 2022 06:14:28 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id a14sm9094374qtb.92.2022.02.09.06.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 06:14:27 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nHnjn-001FdR-1z; Wed, 09 Feb 2022 10:14:27 -0400 Date: Wed, 9 Feb 2022 10:14:27 -0400 From: Jason Gunthorpe To: Christoph Hellwig Message-ID: <20220209141427.GJ49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> <20220209135351.GA20631@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209135351.GA20631@lst.de> Subject: Re: [Nouveau] [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Christian =?utf-8?B?S8O2bmln?= , Linux MM , Ben Skeggs , Alex Deucher , Dan Williams , Logan Gunthorpe , Andrew Morton Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Feb 09, 2022 at 02:53:51PM +0100, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > > It is nice, but the other series are still impacted by the fsdax mess > > - they still stuff pages into ptes without proper refcounts and have > > to carry nonsense to dance around this problem. > > > > I certainly would be unhappy if the amd driver, for instance, gained > > the fsdax problem as well and started pushing 4k pages into PMDs. > > As said before: I think this all needs to be fixed. But I'd rather > fix it gradually and I think this series is a nice step forward. > After that we can look at the pte mappings. Right, I agree with this Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EB3FC433F5 for ; Wed, 9 Feb 2022 14:14:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 708F910E5AD; Wed, 9 Feb 2022 14:14:30 +0000 (UTC) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44D7C10E5AD for ; Wed, 9 Feb 2022 14:14:29 +0000 (UTC) Received: by mail-qk1-x733.google.com with SMTP id b35so1658074qkp.6 for ; Wed, 09 Feb 2022 06:14:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c8BMy3fH62yXJxfHY+j4P80h5ALqrjcvX+ObTuKf0iA=; b=V7onSa8ruWkEtkdB8irRTbQO5EhI5+EN5mjt3u01+vlKyYcQfcNp9aFh92tP1OzUTh ScFSSPOJZDc270JM0jq7Rhgv2t8FwpCHJ20+6gStJqzqZxWKPGAiZe6G30wozCGKb6G+ ZLQWTS1Ro4hAfH5OwcrYeqPEFEKYoHUMzawcDJx2RgUNBo1ohb8nkxONIHkbUDMBpr5o apeGjKCH5BBxtNM0aA8Q1I0DV6rlydLedHpS7mVvMx/qFqliS9UfDYoHrCMy5D2aCL3F 0jecgeDZDBF6tjcMyMnIYAGizQnperLp47omGbCJq3v5uCCpJ63E6XzU+sfOUF4jG60Y /F8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c8BMy3fH62yXJxfHY+j4P80h5ALqrjcvX+ObTuKf0iA=; b=beO1N1OpZ7wn7V5dF1paBZEBdQDaMOF9zk2uBbyAveejbDbJHN+e59uTgY4Iujsb5v cGQLEuWtaelY1IAXAKr8CPXi8GkbPzZ0gzjr1/EQmfG//vwBx4kViodfsfOExailDQ2N IR18OsVezuAYuUmFxIvfRcrSB6idWkpXILkpNHVjFwDkQ81CtK+UV8t7vlDt8Ey2IEfY fP3uTTBpmfJjd0jkH4brNZrHxBgs/W0TvusrU9LzIznC/j8oOsEUns2rw9r39ySWi3zD leOUyefj40RSDLZnBETen4GDLV+jN6EtL+xuoi/eYgCtSlIKtHSf0bFMCpU1LCgN8mw9 8dPg== X-Gm-Message-State: AOAM532SecXJL0xq1W0EchwlshXZcCU6SPV3f450aFKP06BGiqXS3La4 JarCkx1WWfVbiEIDasRVLjYMeg== X-Google-Smtp-Source: ABdhPJzQ+iaZjCKRuCc0J8n0Ck+TXJ7O0pFZ7w0y3yYzv/vscWA+Im2JaGH4eENvWOVqnzWKMTNFCg== X-Received: by 2002:a05:620a:1351:: with SMTP id c17mr1137673qkl.460.1644416068212; Wed, 09 Feb 2022 06:14:28 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id a14sm9094374qtb.92.2022.02.09.06.14.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 06:14:27 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1nHnjn-001FdR-1z; Wed, 09 Feb 2022 10:14:27 -0400 Date: Wed, 9 Feb 2022 10:14:27 -0400 From: Jason Gunthorpe To: Christoph Hellwig Subject: Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount Message-ID: <20220209141427.GJ49147@ziepe.ca> References: <20220207063249.1833066-1-hch@lst.de> <20220207063249.1833066-8-hch@lst.de> <20220209062345.GB7739@lst.de> <20220209122956.GI49147@ziepe.ca> <20220209135351.GA20631@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209135351.GA20631@lst.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , Ralph Campbell , Alistair Popple , Maling list - DRI developers , Karol Herbst , nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Linux Kernel Mailing List , amd-gfx list , Christian =?utf-8?B?S8O2bmln?= , Linux MM , Ben Skeggs , Alex Deucher , Dan Williams , Logan Gunthorpe , Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 09, 2022 at 02:53:51PM +0100, Christoph Hellwig wrote: > On Wed, Feb 09, 2022 at 08:29:56AM -0400, Jason Gunthorpe wrote: > > It is nice, but the other series are still impacted by the fsdax mess > > - they still stuff pages into ptes without proper refcounts and have > > to carry nonsense to dance around this problem. > > > > I certainly would be unhappy if the amd driver, for instance, gained > > the fsdax problem as well and started pushing 4k pages into PMDs. > > As said before: I think this all needs to be fixed. But I'd rather > fix it gradually and I think this series is a nice step forward. > After that we can look at the pte mappings. Right, I agree with this Jason