From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4276C433F5 for ; Wed, 9 Feb 2022 17:48:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238426AbiBIRsG (ORCPT ); Wed, 9 Feb 2022 12:48:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235315AbiBIRsE (ORCPT ); Wed, 9 Feb 2022 12:48:04 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C23CC05CB86 for ; Wed, 9 Feb 2022 09:48:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 111CAB8235A for ; Wed, 9 Feb 2022 17:48:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 253B8C340E7; Wed, 9 Feb 2022 17:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644428884; bh=bpT3sFMSFETjSP2Uvo1MS9Tcu2WoLqbpVCyvJuiqgrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b+O3331ajEY5sc8sm0FVWfEU16lYfcmYbeIsGY8+EZoR769V1RsSHbgK4UaIf6Jg0 L6Qky+61iosP/oVMkg3SA+j1qF2XRYrlZrCDyGG75N/HwSWqy0bBM5bLGbuMBLWHJn a3bosujBVq6qRiqBqF/8hxz5TWv6yFsNLGOcDoFdJuyRPGurD3NG7dcyw9rrSfXbar 4rEkCTWW5ZjbXNPMAp7ieUNr0VvkAbHmBecG5RFu/r0Tqd7CTNBGo/HrWIGogBvv9V oPv4u+vjyn9zv0hPYdSqcpyVMEjPCPRlBbMKnWXBlcQsvs/kr7PZGlpX8EHTNwYy4r 5g1KHjlfc33RA== Date: Wed, 9 Feb 2022 18:48:01 +0100 From: Frederic Weisbecker To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys Message-ID: <20220209174801.GA547263@lothringen> References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-6-mark.rutland@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209153535.818830-6-mark.rutland@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote: > +config HAVE_PREEMPT_DYNAMIC_KEY > + bool > + depends on JUMP_LABEL This should probably be: depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO select JUMP_LABEL Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 952E7C433EF for ; Wed, 9 Feb 2022 17:49:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8nBqVXAMg5dTvGrQE0Swhvmm8oco1I5BOEXGthsrzMs=; b=CyhVsOOSF0taIT j4HM0QhD8qjie3T1v6wkj7IvWgC45TXca9DaNV3pkzJqGRmxPQbpRs/Xf2MECttImP3ibVjjXL+q1 6MnAFukBLJ3yqcqQpftJqnjsr2hQVpiYD2X6qqxFgraXI8e6qmNWyylw9SfqQWN16qP8y258S1S0X 5L70CFx/nd4asBatF8OnfjnwpWyPLdDPzb6fuRA7ITPMAMn6zIrTO033/n3BJp3y56UfSADHGBm/t QpLUXZKygA69h0JZ0fI7SZqzE5vxtonIikQYELHYh961VUDH/bDVdeYCq4l5JQaU8+UVRvkgmnDzc WWndwTEyUY2y1PDbVzNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHr4b-000zwv-DW; Wed, 09 Feb 2022 17:48:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHr4Y-000zve-BF for linux-arm-kernel@lists.infradead.org; Wed, 09 Feb 2022 17:48:07 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3C44F61AFE; Wed, 9 Feb 2022 17:48:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 253B8C340E7; Wed, 9 Feb 2022 17:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644428884; bh=bpT3sFMSFETjSP2Uvo1MS9Tcu2WoLqbpVCyvJuiqgrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b+O3331ajEY5sc8sm0FVWfEU16lYfcmYbeIsGY8+EZoR769V1RsSHbgK4UaIf6Jg0 L6Qky+61iosP/oVMkg3SA+j1qF2XRYrlZrCDyGG75N/HwSWqy0bBM5bLGbuMBLWHJn a3bosujBVq6qRiqBqF/8hxz5TWv6yFsNLGOcDoFdJuyRPGurD3NG7dcyw9rrSfXbar 4rEkCTWW5ZjbXNPMAp7ieUNr0VvkAbHmBecG5RFu/r0Tqd7CTNBGo/HrWIGogBvv9V oPv4u+vjyn9zv0hPYdSqcpyVMEjPCPRlBbMKnWXBlcQsvs/kr7PZGlpX8EHTNwYy4r 5g1KHjlfc33RA== Date: Wed, 9 Feb 2022 18:48:01 +0100 From: Frederic Weisbecker To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys Message-ID: <20220209174801.GA547263@lothringen> References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-6-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220209153535.818830-6-mark.rutland@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220209_094806_473041_A5BB5310 X-CRM114-Status: UNSURE ( 9.67 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote: > +config HAVE_PREEMPT_DYNAMIC_KEY > + bool > + depends on JUMP_LABEL This should probably be: depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO select JUMP_LABEL Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n. Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel