From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A81C433F5 for ; Thu, 10 Feb 2022 03:13:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232214AbiBJDNQ (ORCPT ); Wed, 9 Feb 2022 22:13:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229710AbiBJDNO (ORCPT ); Wed, 9 Feb 2022 22:13:14 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25F191EAE1 for ; Wed, 9 Feb 2022 19:13:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644462797; x=1675998797; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZcyIvusHwZnfRVfKt2PwWs6i0TMwMkq3rmt+VlQRRGM=; b=h3zM5TecLiM1PKMjh/F6EWB2LAoFjoKcUEmnOm1VuuxkcDBTDwizmkVs zcdUnBS9d7xig1SXcJ+tVaGpxDY4ogBB3+TrMMwH2Izr98sya21seIxnS Sf5ZL8J8BZzh2ncKM2fm8u31Al5PoVXzRQqcOEuvh9lZw+2vZZ52dfW5h 6lWs8EHlFQms2eZ4nTYe9z+cfXDL3OvnQK/iRvdBdAHrLzZmKSCq9iJ9O AAghwDr1YjCAYO0McOpZJoT0d9AVyYGfXNsT9ytU9mirhAkRvw4dddpua iFE9AZoi+kGtbqggMZgVhKPlbAjNYTT3Muu9FL1zT7kxxnW76MjJK9t6Y A==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="335813000" X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="335813000" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 19:13:16 -0800 X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="485527252" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.198.157]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 19:13:16 -0800 Date: Wed, 9 Feb 2022 19:16:14 -0800 From: Jacob Pan To: Fenghua Yu Cc: "Thomas Gleixner" , "Dave Hansen" , "Ingo Molnar" , "Borislav Petkov" , "Peter Zijlstra" , "Andy Lutomirski" , "Tony Luck" , "Lu Baolu" , "Joerg Roedel" , Josh Poimboeuf , "Ashok Raj" , "Ravi V Shankar" , iommu@lists.linux-foundation.org, "x86" , "linux-kernel" , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit Message-ID: <20220209191614.5a3b42d4@jacob-builder> In-Reply-To: <20220207230254.3342514-6-fenghua.yu@intel.com> References: <20220207230254.3342514-1-fenghua.yu@intel.com> <20220207230254.3342514-6-fenghua.yu@intel.com> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fenghua, On Mon, 7 Feb 2022 15:02:48 -0800, Fenghua Yu wrote: > @@ -1047,8 +1040,6 @@ struct iommu_sva *intel_svm_bind(struct device > *dev, struct mm_struct *mm, void } > > sva = intel_svm_bind_mm(iommu, dev, mm, flags); > - if (IS_ERR_OR_NULL(sva)) > - intel_svm_free_pasid(mm); If bind fails, the PASID has no IOMMU nor CPU context. It should be safe to free here. Thanks, Jacob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2187EC433EF for ; Thu, 10 Feb 2022 03:13:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AF27782884; Thu, 10 Feb 2022 03:13:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AWEzl1jAculS; Thu, 10 Feb 2022 03:13:20 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id AEF1D8274E; Thu, 10 Feb 2022 03:13:19 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 7EB47C001A; Thu, 10 Feb 2022 03:13:19 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 44190C000B for ; Thu, 10 Feb 2022 03:13:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 23DFB40308 for ; Thu, 10 Feb 2022 03:13:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=intel.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2QUlEx6lJUuD for ; Thu, 10 Feb 2022 03:13:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp4.osuosl.org (Postfix) with ESMTPS id 825BE4027B for ; Thu, 10 Feb 2022 03:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644462797; x=1675998797; h=date:from:to:cc:subject:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZcyIvusHwZnfRVfKt2PwWs6i0TMwMkq3rmt+VlQRRGM=; b=h3zM5TecLiM1PKMjh/F6EWB2LAoFjoKcUEmnOm1VuuxkcDBTDwizmkVs zcdUnBS9d7xig1SXcJ+tVaGpxDY4ogBB3+TrMMwH2Izr98sya21seIxnS Sf5ZL8J8BZzh2ncKM2fm8u31Al5PoVXzRQqcOEuvh9lZw+2vZZ52dfW5h 6lWs8EHlFQms2eZ4nTYe9z+cfXDL3OvnQK/iRvdBdAHrLzZmKSCq9iJ9O AAghwDr1YjCAYO0McOpZJoT0d9AVyYGfXNsT9ytU9mirhAkRvw4dddpua iFE9AZoi+kGtbqggMZgVhKPlbAjNYTT3Muu9FL1zT7kxxnW76MjJK9t6Y A==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="229370299" X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="229370299" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 19:13:16 -0800 X-IronPort-AV: E=Sophos;i="5.88,357,1635231600"; d="scan'208";a="485527252" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.198.157]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 19:13:16 -0800 Date: Wed, 9 Feb 2022 19:16:14 -0800 From: Jacob Pan To: Fenghua Yu Subject: Re: [PATCH v4 05/11] iommu/sva: Assign a PASID to mm on PASID allocation and free it on mm exit Message-ID: <20220209191614.5a3b42d4@jacob-builder> In-Reply-To: <20220207230254.3342514-6-fenghua.yu@intel.com> References: <20220207230254.3342514-1-fenghua.yu@intel.com> <20220207230254.3342514-6-fenghua.yu@intel.com> Organization: OTC X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: Ravi V Shankar , Tony Luck , Ashok Raj , Peter Zijlstra , Dave Hansen , x86 , linux-kernel , iommu@lists.linux-foundation.org, Ingo Molnar , Borislav Petkov , Andy Lutomirski , Josh Poimboeuf , Thomas Gleixner X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Hi Fenghua, On Mon, 7 Feb 2022 15:02:48 -0800, Fenghua Yu wrote: > @@ -1047,8 +1040,6 @@ struct iommu_sva *intel_svm_bind(struct device > *dev, struct mm_struct *mm, void } > > sva = intel_svm_bind_mm(iommu, dev, mm, flags); > - if (IS_ERR_OR_NULL(sva)) > - intel_svm_free_pasid(mm); If bind fails, the PASID has no IOMMU nor CPU context. It should be safe to free here. Thanks, Jacob _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu