From: Matthieu Baerts <matthieu.baerts@tessares.net>
To: mptcp@lists.linux.dev
Cc: Matthieu Baerts <matthieu.baerts@tessares.net>
Subject: [PATCH mptcp-next 0/9] Refactor mptcp_join.sh
Date: Wed, 9 Feb 2022 22:25:11 +0100 [thread overview]
Message-ID: <20220209212520.2989291-1-matthieu.baerts@tessares.net> (raw)
I started this series to be able to launch a specific test without
having to modify the script to comment tests from the subgroup I didn't
want to validate when trying to reproduce a specific issue in a loop.
That's what we can find in patch 3/9.
While at it, I:
- fixed one issue with the options (patch 1/9)
- stop if an option doesn't exist (patch 2/9)
- removed unused vars (patch 4/9)
- delay some actions to the first test not to do them if no test is
launched (patches 5-6/9)
But after having seen all modified lines, why stopping there? So I:
- clarify local vs global variables to avoid Bash's classical pitfall
(patch 7/9)
- fixed all issues reported by ShellCheck except one (patch 8-9/9)
These last 3 patches (+ patch 3/9) will create a lot of conflicts. If
we are OK with them, probably best not to wait to long before applying
them to avoid big rebases.
For the patches that are already in review, I can fix the conflicts when
applying them.
Matthieu Baerts (9):
selftests: mptcp: join: allow running -cCi
selftests: mptcp: join: exit after printing usage
selftests: mptcp: join: option to execute specific tests
selftests: mptcp: join: remove unused vars
selftests: mptcp: join: create tmp files only if needed
selftests: mptcp: join: check for tools only if needed
selftests: mptcp: join: clarify local/global vars
selftests: mptcp: join: avoid backquotes
selftests: mptcp: join: make it shellcheck compliant
.../testing/selftests/net/mptcp/mptcp_join.sh | 2342 +++++++++--------
1 file changed, 1257 insertions(+), 1085 deletions(-)
--
2.34.1
next reply other threads:[~2022-02-09 21:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 21:25 Matthieu Baerts [this message]
2022-02-09 21:25 ` [PATCH mptcp-next 1/9] selftests: mptcp: join: allow running -cCi Matthieu Baerts
2022-02-10 14:53 ` Paolo Abeni
2022-02-11 17:30 ` Matthieu Baerts
2022-02-11 18:56 ` Paolo Abeni
2022-02-09 21:25 ` [PATCH mptcp-next 2/9] selftests: mptcp: join: exit after usage() Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 3/9] selftests: mptcp: join: option to execute specific tests Matthieu Baerts
2022-02-10 0:36 ` Mat Martineau
2022-02-10 10:04 ` Paolo Abeni
2022-02-10 10:42 ` Matthieu Baerts
2022-02-10 15:11 ` Paolo Abeni
2022-02-16 15:50 ` Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 4/9] selftests: mptcp: join: remove unused vars Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 5/9] selftests: mptcp: join: create tmp files only if needed Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 6/9] selftests: mptcp: join: check for tools " Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 7/9] selftests: mptcp: join: clarify local/global vars Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 8/9] selftests: mptcp: join: avoid backquotes Matthieu Baerts
2022-02-09 21:25 ` [PATCH mptcp-next 9/9] selftests: mptcp: join: make it shellcheck compliant Matthieu Baerts
2022-02-10 0:22 ` [PATCH mptcp-next 0/9] Refactor mptcp_join.sh Mat Martineau
2022-02-11 17:34 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209212520.2989291-1-matthieu.baerts@tessares.net \
--to=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.