From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 408F4C433F5 for ; Thu, 10 Feb 2022 03:45:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D914A82C6D; Thu, 10 Feb 2022 04:45:22 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="fVWE3ZcH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E93C982146; Thu, 10 Feb 2022 04:45:20 +0100 (CET) Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 627FD82DB7 for ; Thu, 10 Feb 2022 04:45:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62d.google.com with SMTP id y7so724185plp.2 for ; Wed, 09 Feb 2022 19:45:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=grVip+qAid58gzx78Fym9uG6tfb8wBnnYa1CcvIxHIk=; b=fVWE3ZcHjqu4Xr5+aq7GN99bNUzCycPNdIlFjQXZM2mHe6Z4CoUw2qBAI2MBjNQTF4 yMZFmvShAHr8ukJ+4OEGapiw4N1jaWKy51+EDHoGWaV4nI/Fr8MI9O+brwKUbrBS+Uv4 DCE6jsTh8KMhSg6UtXSxwuY7U4laHAeihIbBTSB86Nv9n9CkGix0+MpYlQF5+aKxUQ9T 8VCUxJrEpgqySM9K5GvF3gm83Axe8yObvPa7cxur7Mn3pUKx35SDgXiwnk5ht9Yy8I6A eRiRu94wm3/Jhg5yqwCnZYzpJvq5SFz3FXyuzEzknZlcme8n3lxOVYlFbIslMZwnYFH0 hH0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=grVip+qAid58gzx78Fym9uG6tfb8wBnnYa1CcvIxHIk=; b=zbjMGKSqHWCOLyDqhzD+ez/Vz+OKSHtNbjZF0CDhVzUHJTV6LJwH40N/+gvo0n2N0P QcC1GZQParijOlKCd8jp15QtujFNE9wt/Y6LHg5QpioaM6iRDs20g97vGK3AVZwPxrFR /eIpRCh5LQ7LQuhYHimKLBS1hdHLOJTxjkj/eSb3/mvZfruphJdpDVRU/XJetiNySF5l zvLMhq5CnkNgclXLlpZcNRpKfiBwA83AQKyitu6Xx6K3ECoUn4XzO2d3YQMJhClng0wr axlSXd+ARCpt6JFXHXWTiU3NIeGRke30cVPLRk+bS8JfabJYGB5708mWf2g466b4kHEM lj8A== X-Gm-Message-State: AOAM53188N87CtfRAZtP7YNDK9gUEsc+rB1kMbO87tJp0Sj/RSIsB5wE qRiVl8DKbKtJewxzHeK/Em0BtQ== X-Google-Smtp-Source: ABdhPJwCaPoefmXRobiElSHlxwcNODpFgs9SsgQA7d0dtNCTOx9oZX+TCQ2/ay0V7xo5AO2kqRrTSw== X-Received: by 2002:a17:90a:b906:: with SMTP id p6mr679184pjr.212.1644464714615; Wed, 09 Feb 2022 19:45:14 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:412e:384:fab9:f24]) by smtp.gmail.com with ESMTPSA id oj5sm265122pjb.29.2022.02.09.19.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 19:45:14 -0800 (PST) Date: Thu, 10 Feb 2022 12:45:09 +0900 From: AKASHI Takahiro To: Jaehoon Chung Cc: lukma@denx.de, peng.fan@nxp.com, bmeng.cn@gmail.com, peng.ma@nxp.com, sr@denx.de, xypron.glpk@gmx.de, sjg@chromium.org, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Subject: Re: [PATCH 03/19] mmc: call device_probe() after scanning Message-ID: <20220210034509.GC12412@laputa> Mail-Followup-To: AKASHI Takahiro , Jaehoon Chung , lukma@denx.de, peng.fan@nxp.com, bmeng.cn@gmail.com, peng.ma@nxp.com, sr@denx.de, xypron.glpk@gmx.de, sjg@chromium.org, ilias.apalodimas@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de References: <20220202010853.40405-1-takahiro.akashi@linaro.org> <20220202010853.40405-4-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Wed, Feb 09, 2022 at 08:46:18AM +0900, Jaehoon Chung wrote: > On 2/2/22 10:08, AKASHI Takahiro wrote: > > Every time a mmc bus/port is scanned and a new device is detected, > > we want to call device_probe() as it will give us a chance to run > > additional post-processings for some purposes. > > > > In particular, support for creating partitions on a device will be added. > > > > Signed-off-by: AKASHI Takahiro > > --- > > drivers/mmc/mmc-uclass.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/mmc/mmc-uclass.c b/drivers/mmc/mmc-uclass.c > > index b80e838066ca..e918f58a212e 100644 > > --- a/drivers/mmc/mmc-uclass.c > > +++ b/drivers/mmc/mmc-uclass.c > > @@ -467,6 +467,18 @@ static int mmc_blk_probe(struct udevice *dev) > > return ret; > > } > > > > + ret = device_probe(dev); > > + if (ret) { > > + debug("Can't probe\n"); > > how about displaying return value to debug? Sure. -Takahiro Akashi > Best Regards, > Jaehoon Chung > > > + > > + if (IS_ENABLED(CONFIG_MMC_UHS_SUPPORT) || > > + IS_ENABLED(CONFIG_MMC_HS200_SUPPORT) || > > + IS_ENABLED(CONFIG_MMC_HS400_SUPPORT)) > > + mmc_deinit(mmc); > > + > > + return ret; > > + } > > + > > return 0; > > } > > >