From: Dave Chinner <david@fromorbit.com>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Brian Foster <bfoster@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-xfs@vger.kernel.org, Ian Kent <raven@themaw.net>,
rcu@vger.kernel.org
Subject: Re: [PATCH] xfs: require an rcu grace period before inode recycle
Date: Thu, 10 Feb 2022 15:09:17 +1100 [thread overview]
Message-ID: <20220210040917.GN59729@dread.disaster.area> (raw)
In-Reply-To: <20220207163621.GC4285@paulmck-ThinkPad-P17-Gen-1>
On Mon, Feb 07, 2022 at 08:36:21AM -0800, Paul E. McKenney wrote:
> On Mon, Feb 07, 2022 at 08:30:03AM -0500, Brian Foster wrote:
> Another approach is to use SLAB_TYPESAFE_BY_RCU. This allows immediate
> reuse of freed memory, but also requires pointer traversals to the memory
> to do a revalidation operation. (Sorry, no free lunch here!)
Can't do that with inodes - newly allocated/reused inodes have to go
through inode_init_always() which is the very function that causes
the problems we have now with path-walk tripping over inodes in an
intermediate re-initialised state because we recycled it inside a
RCU grace period.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-02-10 4:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:24 [PATCH] xfs: require an rcu grace period before inode recycle Brian Foster
2022-01-21 17:26 ` Darrick J. Wong
2022-01-21 18:33 ` Brian Foster
2022-01-22 5:30 ` Paul E. McKenney
2022-01-22 16:55 ` Paul E. McKenney
2022-01-24 15:12 ` Brian Foster
2022-01-24 16:40 ` Paul E. McKenney
2022-01-23 22:43 ` Dave Chinner
2022-01-24 15:06 ` Brian Foster
2022-01-24 15:02 ` Brian Foster
2022-01-24 22:08 ` Dave Chinner
2022-01-24 23:29 ` Brian Foster
2022-01-25 0:31 ` Dave Chinner
2022-01-25 14:40 ` Paul E. McKenney
2022-01-25 22:36 ` Dave Chinner
2022-01-26 5:29 ` Paul E. McKenney
2022-01-26 13:21 ` Brian Foster
2022-01-25 18:30 ` Brian Foster
2022-01-25 20:07 ` Brian Foster
2022-01-25 22:45 ` Dave Chinner
2022-01-27 4:19 ` Al Viro
2022-01-27 5:26 ` Dave Chinner
2022-01-27 19:01 ` Brian Foster
2022-01-27 22:18 ` Dave Chinner
2022-01-28 14:11 ` Brian Foster
2022-01-28 23:53 ` Dave Chinner
2022-01-31 13:28 ` Brian Foster
2022-01-28 21:39 ` Paul E. McKenney
2022-01-31 13:22 ` Brian Foster
2022-02-01 22:00 ` Paul E. McKenney
2022-02-03 18:49 ` Paul E. McKenney
2022-02-07 13:30 ` Brian Foster
2022-02-07 16:36 ` Paul E. McKenney
2022-02-10 4:09 ` Dave Chinner [this message]
2022-02-10 5:45 ` Paul E. McKenney
2022-02-10 20:47 ` Brian Foster
2022-01-25 8:16 ` [xfs] a7f4e88080: aim7.jobs-per-min -62.2% regression kernel test robot
2022-01-25 8:16 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210040917.GN59729@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=raven@themaw.net \
--cc=rcu@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.