From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3599DC433F5 for ; Thu, 10 Feb 2022 06:29:12 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45D9F4013F; Thu, 10 Feb 2022 07:29:11 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7DF6A40041; Thu, 10 Feb 2022 07:29:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644474549; x=1676010549; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vgD91JXtC8lUqQpwX83u69sdjj4hGnY0M+8/WWJMNvk=; b=NoLsLx4hoyfKUSr5Yya/PjwA2NeUXHKy7KBDHXtanHq5YlYKjQaCExJX qlrNHB7TOig3L7SXuPTeihLMSSwPQS7OapmdN6LrXPpiilEnvfBVxEH0E ArQYI9V4aUIzaZEfUWJOMjTZVS+kvLT0EmU3FPB++WN3eDDZYeb7FKcEU EmOJsSX0XgJ5dllixOUARCw/4J+RO8aC+QKYojKV7Upsrnyv9W9+0VhZw l/7+osP1u/VD05LmfV65Fq0Y8kZ3vmIDQ3RB9cL0qPJJPs2wNFDYln2Mb rqwrdKEGfK9CihsZRDIBHFmwyCIVi48QvEj1QpurZKSOpGzWjIHeqd59v w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="248254751" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="248254751" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 22:29:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="485568475" Received: from dpdk-jf-ntb-v1.sh.intel.com ([10.67.119.116]) by orsmga006.jf.intel.com with ESMTP; 09 Feb 2022 22:29:07 -0800 From: Junfeng Guo To: jingjing.wu@intel.com Cc: dev@dpdk.org, stable@dpdk.org, junfeng.guo@intel.com Subject: [PATCH] raw/ntb: add check for DB intr handler registering Date: Thu, 10 Feb 2022 14:28:41 +0800 Message-Id: <20220210062841.646294-1-junfeng.guo@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The callback registering of doorbell interrupt handler should be finished before enabling the interrupt event fd. Thus add the return value check for this callback registering. Fixes: 62012a76811e ("raw/ntb: add handshake process") Cc: stable@dpdk.org Signed-off-by: Junfeng Guo --- drivers/raw/ntb/ntb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ntb/ntb.c b/drivers/raw/ntb/ntb.c index cc611dfbb9..0801e6d1ae 100644 --- a/drivers/raw/ntb/ntb.c +++ b/drivers/raw/ntb/ntb.c @@ -1403,8 +1403,12 @@ ntb_init_hw(struct rte_rawdev *dev, struct rte_pci_device *pci_dev) intr_handle = pci_dev->intr_handle; /* Register callback func to eal lib */ - rte_intr_callback_register(intr_handle, - ntb_dev_intr_handler, dev); + ret = rte_intr_callback_register(intr_handle, + ntb_dev_intr_handler, dev); + if (ret) { + NTB_LOG(ERR, "Unable to register doorbell intr handler."); + return ret; + } ret = rte_intr_efd_enable(intr_handle, hw->db_cnt); if (ret) -- 2.25.1