From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872EFC433EF for ; Thu, 10 Feb 2022 15:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243455AbiBJPH5 (ORCPT ); Thu, 10 Feb 2022 10:07:57 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243315AbiBJPH4 (ORCPT ); Thu, 10 Feb 2022 10:07:56 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF51DBF; Thu, 10 Feb 2022 07:07:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8B07961B66; Thu, 10 Feb 2022 15:07:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F04E4C004E1; Thu, 10 Feb 2022 15:07:54 +0000 (UTC) Date: Thu, 10 Feb 2022 10:07:53 -0500 From: Steven Rostedt To: Sebastian Andrzej Siewior Cc: Krzysztof Kozlowski , Ingo Molnar , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, joseph.salisbury@canonical.com, Shuah Khan Subject: Re: [PATCH v2] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT Message-ID: <20220210100753.27248bf6@gandalf.local.home> In-Reply-To: References: <20220210083356.11212-1-krzysztof.kozlowski@canonical.com> <546f147d-1682-fb92-42e5-7247dc19dcf1@canonical.com> <429dd2fd-3ceb-6780-f970-4ea9b115388c@canonical.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Feb 2022 15:48:41 +0100 Sebastian Andrzej Siewior wrote: > After looking into the test it appears that two random functions are > enough to be specified because the actual purpose is it to figure out if > the function is recorded and not the actual functionality behind the > function. Correct. And if I ever do get a chance to revisit this test, I plan on adding a bunch of comments to it. It's hard enough to add tests for one's code, but even harder to document what those tests actually do ;-) -- Steve