From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBB3C4332F for ; Thu, 10 Feb 2022 10:50:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240231AbiBJKub (ORCPT ); Thu, 10 Feb 2022 05:50:31 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240214AbiBJKu3 (ORCPT ); Thu, 10 Feb 2022 05:50:29 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE52FFE for ; Thu, 10 Feb 2022 02:50:31 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id d187so9487205pfa.10 for ; Thu, 10 Feb 2022 02:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pfPmHTNS3kNf2REIYVPxP0rI8dFehD3FUEuoa/nfhmQ=; b=LV+Wgp8y3d5XDi3wv3BsyrxVE/eJEg914rTG32ssP43QX2iCrRuh4WUb+6RwJP8n9A XKmpvwvmhZnw8XJ21kf3VZH2jlpzWbQqfvtmkYF/0MR3b+qZZv+o6iF3q6JAoarRHqGZ o9azkiYLnrXoaq1SASw1qMZ5pFQRTKiWtXzvUBbZBy31W8MslfIfFpoM9K+y9eSGBw+X 0R4NYYYnq/OSOh15JpFvO9i4lnYSx3CpHXeZgdERKYb2eprNuqRDbD4TYmvvFNbDRDDu 8gTdmCz3Tg9ewAdRsYcolPHOYiS2PvpRu3SooESMNWcbJGvogpPyZoSZV4/hKLei8tn1 N3oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pfPmHTNS3kNf2REIYVPxP0rI8dFehD3FUEuoa/nfhmQ=; b=tsgvyzXzanlYB8iFQ+xocwXZjMeupjZQb+alq35k+/tRfVBJaZuqYBAU9taNFoTDZz CPk6XUMpRod/IOuAGeRK/Km42LiAddUpv0sUzyjbX8m+UgRgTGZI8WHq+Q6CAvmkItzw dk0w4hFtFiIXIS6PnMy1TRk44GcldlWsmoXcG6GgTWzbYVo38SVM6STZD6pSwXZnrZpk Dxex+7o6x21jQUYQNnaDc6gMgu7zLwo+NSAH0REYNoxaFlNlQZU2rFED7iW4AGCZEWFt 4/72mNsRjDqtwP646vgpFJ1RptaXwAMVWfBj5t+/PehokhX9cX9h+yX7W0Be+RPTPZeQ TRBg== X-Gm-Message-State: AOAM532HNfD/zFT8qy/os//m0TKuxCdP0UcOFYi3c1yGAcrhkm6ev9XN P/VAzL/bRBQlT2Mpkw6xBdqI X-Google-Smtp-Source: ABdhPJwX5eFiJ34Kps0Uoal21jJAK99NMgslIAbYgaiigOPC9RkZIznR1OV86VyQA1xPKb9GDAqA6w== X-Received: by 2002:a63:dd0f:: with SMTP id t15mr5652799pgg.12.1644490230574; Thu, 10 Feb 2022 02:50:30 -0800 (PST) Received: from thinkpad ([27.111.75.88]) by smtp.gmail.com with ESMTPSA id t9sm1794782pjg.44.2022.02.10.02.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 02:50:30 -0800 (PST) Date: Thu, 10 Feb 2022 16:20:23 +0530 From: Manivannan Sadhasivam To: "Lad, Prabhakar" Cc: Lad Prabhakar , Kishon Vijay Abraham I , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Arnd Bergmann , Greg Kroah-Hartman , Marek Vasut , Yoshihiro Shimoda , Rob Herring , linux-pci , Linux-Renesas , LKML , Biju Das Subject: Re: [RFC PATCH 0/5] PCIe EPF support for internal DMAC handling and driver update for R-Car PCIe EP to support DMAC Message-ID: <20220210105023.GB69529@thinkpad> References: <20220126195043.28376-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220210084052.GA69529@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 09:24:19AM +0000, Lad, Prabhakar wrote: > Hi, > > On Thu, Feb 10, 2022 at 8:40 AM Manivannan Sadhasivam > wrote: > > > > Hi, > > > > On Wed, Jan 26, 2022 at 07:50:38PM +0000, Lad Prabhakar wrote: > > > Hi All, > > > > > > The current PCIe EPF framework supports DMA data transfers using external > > > DMA only, this patch series aims to add support for platforms supporting > > > internal DMAC on PCIe for data transfers. > > > > > > R-Car PCIe supports internal DMAC to transfer data between Internal Bus to > > > PCI Express and vice versa. Last patch fills up the required flags and ops > > > to support internal DMAC. > > > > > > Patches 1-3 are for PCIe EPF core to support internal DMAC handling, patch > > > 4/5 is to fix test cases based on the conversation [1]. > > > > > > > This looks similar to the Synopsys eDMA IP [1] that goes with the Synopsys PCIe > > endpoint IP. Why can't you represent it as a dmaengine driver and use the > > existing DMA support? > > > Let me have a look. Could you please share a link to the Synopsys PCIe > endpoint HW manual (the driver doesn't have a binding doc). > I don't think the PCIe reference manual is available publicly. And you are right that the driver is not tied to devicetree. The reason is, it gets probed using the PCI ID of the EP and all the resources are defined statically in the driver itself. Thanks, Mani > Cheers, > Prabhakar > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma/dw-edma > > > > > Patches are based on top of [1] next branch. > > > > > > [0] https://www.spinics.net/lists/linux-pci/msg92385.html > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git > > > > > > Cheers, > > > Prabhakar > > > > > > Lad Prabhakar (5): > > > PCI: endpoint: Add ops and flag to support internal DMAC > > > PCI: endpoint: Add support to data transfer using internal dmac > > > misc: pci_endpoint_test: Add driver data for Renesas RZ/G2{EHMN} > > > misc: pci_endpoint_test: Add support to pass flags for buffer > > > allocation > > > PCI: rcar-ep: Add support for DMAC > > > > > > drivers/misc/pci_endpoint_test.c | 56 ++++- > > > drivers/pci/controller/pcie-rcar-ep.c | 227 ++++++++++++++++++ > > > drivers/pci/controller/pcie-rcar.h | 23 ++ > > > drivers/pci/endpoint/functions/pci-epf-test.c | 184 ++++++++++---- > > > drivers/pci/endpoint/pci-epf-core.c | 32 +++ > > > include/linux/pci-epc.h | 8 + > > > include/linux/pci-epf.h | 7 + > > > 7 files changed, 483 insertions(+), 54 deletions(-) > > > > > > -- > > > 2.25.1 > > >