[PATCH] docs: add some clarification to xenstore-migration.md

[PATCH] docs: add some clarification to xenstore-migration.md

[Juergen Gross]

The Xenstore migration document is missing the specification that a
node record must be preceded by the record of its parent node in case
of live update.

Add that missing part.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 docs/designs/xenstore-migration.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
index 5f1155273e..39e31c984b 100644
--- a/docs/designs/xenstore-migration.md
+++ b/docs/designs/xenstore-migration.md
@@ -316,6 +316,10 @@ a _committed_ node (globally visible in xenstored) or a _pending_ node (created
 or modified by a transaction for which there is also a `TRANSACTION_DATA`
 record previously present).
 
+In the live update case the _committed_ nodes must be in a top-down sequence,
+i.e. the first node needs to be `/`, and each other node in the stream must
+come _after_ its parent node.
+
 
 ```
     0       1       2       3    octet
-- 
2.34.1

Re: [PATCH] docs: add some clarification to xenstore-migration.md

[Julien Grall]

Hi Juergen,

On 10/02/2022 11:26, Juergen Gross wrote:
> The Xenstore migration document is missing the specification that a
> node record must be preceded by the record of its parent node in case
> of live update.
> 
> Add that missing part.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>   docs/designs/xenstore-migration.md | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/docs/designs/xenstore-migration.md b/docs/designs/xenstore-migration.md
> index 5f1155273e..39e31c984b 100644
> --- a/docs/designs/xenstore-migration.md
> +++ b/docs/designs/xenstore-migration.md
> @@ -316,6 +316,10 @@ a _committed_ node (globally visible in xenstored) or a _pending_ node (created
>   or modified by a transaction for which there is also a `TRANSACTION_DATA`
>   record previously present).
>   
> +In the live update case the _committed_ nodes must be in a top-down sequence,
> +i.e. the first node needs to be `/`, and each other node in the stream must
> +come _after_ its parent node.

I would actually expect the same restriction to apply for the 
non-liveupdate case. I.e. we want the parent to either exist in the tree 
or the record for the parent to be before in the stream.

Cheers,

-- 
Julien Grall

Re: [PATCH] docs: add some clarification to xenstore-migration.md

[Juergen Gross]

[-- Attachment #1.1.1: Type: text/plain, Size: 1376 bytes --]

On 15.02.22 21:40, Julien Grall wrote:
> Hi Juergen,
> 
> On 10/02/2022 11:26, Juergen Gross wrote:
>> The Xenstore migration document is missing the specification that a
>> node record must be preceded by the record of its parent node in case
>> of live update.
>>
>> Add that missing part.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>>   docs/designs/xenstore-migration.md | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/docs/designs/xenstore-migration.md 
>> b/docs/designs/xenstore-migration.md
>> index 5f1155273e..39e31c984b 100644
>> --- a/docs/designs/xenstore-migration.md
>> +++ b/docs/designs/xenstore-migration.md
>> @@ -316,6 +316,10 @@ a _committed_ node (globally visible in 
>> xenstored) or a _pending_ node (created
>>   or modified by a transaction for which there is also a 
>> `TRANSACTION_DATA`
>>   record previously present).
>> +In the live update case the _committed_ nodes must be in a top-down 
>> sequence,
>> +i.e. the first node needs to be `/`, and each other node in the 
>> stream must
>> +come _after_ its parent node.
> 
> I would actually expect the same restriction to apply for the 
> non-liveupdate case. I.e. we want the parent to either exist in the tree 
> or the record for the parent to be before in the stream.

Hmm, true. I'll rephrase that.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]