From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD593C433EF for ; Thu, 10 Feb 2022 14:58:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C97DA810F3; Thu, 10 Feb 2022 15:57:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="grbDkbCH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3A23A81112; Thu, 10 Feb 2022 15:57:57 +0100 (CET) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DB09480F90 for ; Thu, 10 Feb 2022 15:57:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id g145so5062107qke.3 for ; Thu, 10 Feb 2022 06:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+S52Kwo6bJv2FInS3lMN1CBjzi5I0lbSUWtpemJWjTU=; b=grbDkbCH+EfM57Wx72KjzPjy1Tui/13+V14c44D1j6n72kKrEEU+HJtP7sFOTS+u2O TSwfMpKne7Qf3mBI7pL00jWoK9o44fgtNFmAkJGH1kQiDRlxRfhdET5hFMEsAXExNgA8 1xG6kTKcsY49TmJfQevCSMUSpXftNT7JCJU2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+S52Kwo6bJv2FInS3lMN1CBjzi5I0lbSUWtpemJWjTU=; b=tWxJ8DsBJseSMxDWWVzpsUuWciYUhzBe1h2yoewNRD1rhQbUaiPepNGwq9eqTv68zm hNIkolzQp5mmRzGfNsb9Id2Qs+AUEtOKCIQ3BSzPn5ZDfKE6lUE2LOCadJ3MepRUbI+Z BfOFK7G2gVZnKqBA70LeqFpHHSZ8NX7j4hpG1fwgzJZ1dP2Z0ihD/hiK8SNYY9hV4gk/ 5SRULt265y6m97H7LE23AcivOkIv2rZn69ndpM58mxeWxxrWBPUlhuSDGJd4REu+E8ec OPhMSXX6d3P3QTEbZZqr8Nr2eYrCZJD0JI6kBh0AaKZRR/8hZ7xUrmAwmYXLkgWpihfX VFoQ== X-Gm-Message-State: AOAM5339lXQHmTnv1jnRTnOSWcyYr/fbkmLn8DO8ojpk6bTtYep2BldA x0wi5MxXxVzHpEgIqX3CVmlBmA== X-Google-Smtp-Source: ABdhPJwob4j5AEuc3/dj1r0KnQwvYkrb9OVmBpYjacvQ2TR32X7iJbvfepJ4w3MhsV6lq+T1vdO9ag== X-Received: by 2002:a05:620a:d84:: with SMTP id q4mr3975913qkl.200.1644505072669; Thu, 10 Feb 2022 06:57:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id w13sm9584765qkb.106.2022.02.10.06.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 06:57:51 -0800 (PST) Date: Thu, 10 Feb 2022 09:57:50 -0500 From: Tom Rini To: Adam Ford Cc: Simon Glass , U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 07/18] pxe: Move pxe_utils files Message-ID: <20220210145750.GH2697206@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.7.Id5595981cd99201c6a2d8b714254d775436a3483@changeid> <20220209123219.GZ7515@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="S5HS5MvDw4DmbRmb" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --S5HS5MvDw4DmbRmb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 10, 2022 at 07:56:52AM -0600, Adam Ford wrote: > On Wed, Feb 9, 2022 at 11:16 AM Simon Glass wrote: > > > > Hi, > > > > On Wed, 9 Feb 2022 at 05:32, Tom Rini wrote: > > > > > > On Wed, Feb 09, 2022 at 05:40:03AM -0600, Adam Ford wrote: > > > > On Thu, Oct 14, 2021 at 1:50 PM Simon Glass wrot= e: > > > > > > > > > > Move the header file into the main include/ directory so we can u= se it > > > > > from the bootmethod code. Move the C file into boot/ since it rel= ates to > > > > > booting. > > > > > > > > > +cc lokeshvutla@ti.com > > > > > > > > Simon, > > > > > > > > I can't explain why, but with git bisect, it appears this patch bre= aks > > > > my omap3_logic board (DM3730) by making it wrongly think there is 4= GB > > > > of RAM, when in reality there is only 256MB. We have both 256MB and > > > > 512MB parts, and the automatic memory detection has always 'just > > > > worked' in the past. > > > > > > > > With this patch now, I see: > > > > U-Boot 2022.01-rc1-00185-g262cfb5b15 (Feb 09 2022 - 05:23:42 -0600) > > > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > > DRAM: 4 GiB > > > > > > > > > > > > With the previous commit, 8018b9af57b5 ("pxe: Tidy up the is_pxe > > > > global"), it properly detects the RAM and fully boots. > > > > > > > > U-Boot 2022.01-rc1-00184-g8018b9af57 (Feb 09 2022 - 05:21:39 -0600) > > > > > > > > OMAP3630/3730-GP ES1.2, CPU-OPP2, L3-200MHz, Max CPU Clock 1 GHz > > > > Model: LogicPD Zoom DM3730 Torpedo + Wireless Development Kit > > > > DRAM: 256 MiB > > > > NAND: 512 MiB > > > > MMC: OMAP SD/MMC: 0 > > > > Loading Environment from NAND... OK > > > > OMAP die ID: 619e00029ff800000168300f1502501f > > > > Net: eth0: ethernet@08000000 > > > > Hit any key to stop autoboot: 0 > > > > OMAP Logic # > > > > > > > > I have CONFIG_CMD_BOOTM, CONFIG_CMD_PXE and CONFIG_CMD_SYSBOOT all > > > > defined, so I am having a hard time understanding why this would > > > > change behavior or stomp on the the structure that knows the memory > > > > size. > > > > > > > > If I jump ahead to the current 'master' 531c0089457:("Merge branch > > > > '2022-02-08-TI-platform-updates') and revert this patch, my board > > > > boots correctly again, but I am struggling to understand why. > + Marek Beh=FAn >=20 > > > > > > > > Do you have any suggestions for me to try? > > > > > > I would suggest objdump disassemble U-Boot before/after and see what > > > functions have changed. > > > > Keep an eye out for a BSS variable that is used before relocation, perh= aps? >=20 > I am still investigating, but disabling LTO appears to fix the issue > for me. I'd like to keep LTO, so I'm going to attempt to focus on the > differences in the affected functions and how this patch makes LTO > behave differently. >=20 > The disassembly of U-Boot is large, so it's going to take me a bit of > time to investigate. If someone has any LTO-related suggestions that > I could try, I'd be open to try them too. Wait, the disassembly is large, or the differences between the disassembly, before/after this change alone, are large? It's feeling like just how we remove the LTO flags from arch/arm/mach-omap2/omap3/board.o something else might also need that, OR digging more to find out issue LTO is exposing in terms of variables being in the data and not BSS section and needing initialization or similar. --=20 Tom --S5HS5MvDw4DmbRmb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIFJ+oACgkQFHw5/5Y0 tyzhbwv/bvCvQIlmVBa+QsIZ7NHB1zAlyGZhr8NVEpF97wApDJLANKnCYG/HVwg3 rVRGCi358MRF+XHeTJdOk1yIMTR4j9T4yNdm39S3J9bjzL0jUOroCtQOxsg+avfU HqwzS8C2xTeEXm5mOE7AbmfWAd/Xzc451iqqpukIFunM1U9f1SLYOQm31LmHlzcz eILFrbtqbw1MhuOyZdJRQEjpkVF6htiFA78aGdmBloUx1QS4GPOmGfichLpmTOsJ gZymW60fuj+H8TWvNSH/v/UVxLXmqunJl+XbfWD9iTcvooI36uk/w5ftoZKqyy1D VWpTqeBo3RMp3q7FYXTYjA5uxlHroor932Z4PeFaLgcPWGPz+WXbbFj7v0fwwhR4 FRpN0JI4ijZEyRTufRcOWxBQMYu/JvPZalENmbaNU8y89BplF90nIP+zBZY6MqRG DsS0HUCqG3s6svie81pm4nyUvsso6kCqgW0lpzghcIyYuDt61e5pUm0QG/n7ZQTy fqghUo/e =cAqr -----END PGP SIGNATURE----- --S5HS5MvDw4DmbRmb--