All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Holger Brunck <holger.brunck@hitachienergy.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [v6] dsa: mv88e6xxx: make serdes SGMII/Fiber tx amplitude configurable
Date: Thu, 10 Feb 2022 15:16:35 +0100	[thread overview]
Message-ID: <20220210151635.4b170f5c@dellmb> (raw)
In-Reply-To: <20220210084322.15467-1-holger.brunck@hitachienergy.com>

On Thu, 10 Feb 2022 09:43:22 +0100
Holger Brunck <holger.brunck@hitachienergy.com> wrote:

> The mv88e6352, mv88e6240 and mv88e6176  have a serdes interface. This patch
> allows to configure the output swing to a desired value in the
> phy-handle of the port. The value which is peak to peak has to be
> specified in microvolts. As the chips only supports eight dedicated
> values we return EINVAL if the value in the DTS does not match one of
> these values.
> 
> CC: Andrew Lunn <andrew@lunn.ch>
> CC: Jakub Kicinski <kuba@kernel.org>
> CC: Marek Behún <kabel@kernel.org>
> Signed-off-by: Holger Brunck <holger.brunck@hitachienergy.com>

Reviewed-by: Marek Behún <kabel@kernel.org>

Keep in mind that the tx-p2p-amplitude DT property is not merged in DT
yet. I suggest you resend this patch as a series of 2 patches, the
first being the DT patch:
  https://lore.kernel.org/linux-devicetree/20220119131117.30245-1-kabel@kernel.org/
where you should also add Rob's reviewed-by tag, which he sent in
  https://lore.kernel.org/linux-devicetree/YgGBe0BS%2Fd0lOVtU@robh.at.kernel.org/

Marek

  parent reply	other threads:[~2022-02-10 14:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10  8:43 [v6] dsa: mv88e6xxx: make serdes SGMII/Fiber tx amplitude configurable Holger Brunck
2022-02-10 13:45 ` Andrew Lunn
2022-02-10 14:16 ` Marek Behún [this message]
2022-02-10 16:26   ` Holger Brunck
2022-02-10 16:36     ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210151635.4b170f5c@dellmb \
    --to=kabel@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=holger.brunck@hitachienergy.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.