From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 681E92F20 for ; Thu, 10 Feb 2022 15:23:19 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4F79068AFE; Thu, 10 Feb 2022 16:23:08 +0100 (CET) Date: Thu, 10 Feb 2022 16:23:08 +0100 From: Christoph Hellwig To: Alistair Popple Cc: Andrew Morton , Dan Williams , Christoph Hellwig , Felix Kuehling , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , "Pan, Xinhui" , Ben Skeggs , Karol Herbst , Lyude Paul , Jason Gunthorpe , Logan Gunthorpe , Ralph Campbell , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, nvdimm@lists.linux.dev, linux-mm@kvack.org Subject: Re: [PATCH 13/27] mm: move the migrate_vma_* device migration code into it's own file Message-ID: <20220210152308.GA13344@lst.de> References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-14-hch@lst.de> <2160837.zdNQNePZV9@nvdebian> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2160837.zdNQNePZV9@nvdebian> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Feb 10, 2022 at 09:35:10PM +1100, Alistair Popple wrote: > I got the following build error: > > /data/source/linux/mm/migrate_device.c: In function ‘migrate_vma_collect_pmd’: > /data/source/linux/mm/migrate_device.c:242:3: error: implicit declaration of function ‘flush_tlb_range’; did you mean ‘flush_pmd_tlb_range’? [-Werror=implicit-function-declaration] > 242 | flush_tlb_range(walk->vma, start, end); > | ^~~~~~~~~~~~~~~ > | flush_pmd_tlb_range > > Including asm/tlbflush.h in migrate_device.c fixed it for me. Yes, the buildbot also complained about this, but somehow in my test configfs it got pulled in implicitly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 914D8C433F5 for ; Thu, 10 Feb 2022 15:23:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2AEF410E895; Thu, 10 Feb 2022 15:23:14 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B2F210E895; Thu, 10 Feb 2022 15:23:12 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4F79068AFE; Thu, 10 Feb 2022 16:23:08 +0100 (CET) Date: Thu, 10 Feb 2022 16:23:08 +0100 From: Christoph Hellwig To: Alistair Popple Message-ID: <20220210152308.GA13344@lst.de> References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-14-hch@lst.de> <2160837.zdNQNePZV9@nvdebian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2160837.zdNQNePZV9@nvdebian> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Nouveau] [PATCH 13/27] mm: move the migrate_vma_* device migration code into it's own file X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Dan Williams , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Thu, Feb 10, 2022 at 09:35:10PM +1100, Alistair Popple wrote: > I got the following build error: > > /data/source/linux/mm/migrate_device.c: In function ‘migrate_vma_collect_pmd’: > /data/source/linux/mm/migrate_device.c:242:3: error: implicit declaration of function ‘flush_tlb_range’; did you mean ‘flush_pmd_tlb_range’? [-Werror=implicit-function-declaration] > 242 | flush_tlb_range(walk->vma, start, end); > | ^~~~~~~~~~~~~~~ > | flush_pmd_tlb_range > > Including asm/tlbflush.h in migrate_device.c fixed it for me. Yes, the buildbot also complained about this, but somehow in my test configfs it got pulled in implicitly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C886EC433F5 for ; Thu, 10 Feb 2022 15:34:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 850BE10E88F; Thu, 10 Feb 2022 15:34:07 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6B2F210E895; Thu, 10 Feb 2022 15:23:12 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4F79068AFE; Thu, 10 Feb 2022 16:23:08 +0100 (CET) Date: Thu, 10 Feb 2022 16:23:08 +0100 From: Christoph Hellwig To: Alistair Popple Subject: Re: [PATCH 13/27] mm: move the migrate_vma_* device migration code into it's own file Message-ID: <20220210152308.GA13344@lst.de> References: <20220210072828.2930359-1-hch@lst.de> <20220210072828.2930359-14-hch@lst.de> <2160837.zdNQNePZV9@nvdebian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2160837.zdNQNePZV9@nvdebian> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mailman-Approved-At: Thu, 10 Feb 2022 15:34:06 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, Ralph Campbell , dri-devel@lists.freedesktop.org, Karol Herbst , linux-mm@kvack.org, nouveau@lists.freedesktop.org, Felix Kuehling , "Pan, Xinhui" , Dan Williams , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Ben Skeggs , Alex Deucher , Andrew Morton , Logan Gunthorpe , Christian =?iso-8859-1?Q?K=F6nig?= Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Thu, Feb 10, 2022 at 09:35:10PM +1100, Alistair Popple wrote: > I got the following build error: > > /data/source/linux/mm/migrate_device.c: In function ‘migrate_vma_collect_pmd’: > /data/source/linux/mm/migrate_device.c:242:3: error: implicit declaration of function ‘flush_tlb_range’; did you mean ‘flush_pmd_tlb_range’? [-Werror=implicit-function-declaration] > 242 | flush_tlb_range(walk->vma, start, end); > | ^~~~~~~~~~~~~~~ > | flush_pmd_tlb_range > > Including asm/tlbflush.h in migrate_device.c fixed it for me. Yes, the buildbot also complained about this, but somehow in my test configfs it got pulled in implicitly.