From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DC1C433FE for ; Thu, 10 Feb 2022 15:59:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243935AbiBJP7h (ORCPT ); Thu, 10 Feb 2022 10:59:37 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243920AbiBJP7c (ORCPT ); Thu, 10 Feb 2022 10:59:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48A30E87 for ; Thu, 10 Feb 2022 07:59:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8C8361CC8 for ; Thu, 10 Feb 2022 15:59:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6D98C340EE; Thu, 10 Feb 2022 15:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644508772; bh=dIgio40C1V0AUEVczldmp/PFz0TwGbd4uOrumI1TjKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W6srJBqUF2/+KCo/h3Ta6qgvtRrsGezTiaT6oiKgyQGPmShZwnJw7oUVcDAhcxrir 6QHI3ua4NPlJ0SXsj4khnhcRW0ZKFl2lSOQ5qe/CI6ynJrkNteWkQy9b1xX6MTGeVM 4M0/Or6M1G1c3ZIl4UoKrhxzX2VNB/hO6VE6aSIIdm5BOCpLheaJhpVdKtoYCYsxBl 6spqOuH/JUcbnu7mHMpNut+NYroWnwFpRRhF5lz/NqhJII87ELV0CqSD3E0+R0G5C6 h/T2AI6m4WBFRa1IB1j24wZeSwm+qfFvjz18w7HMcu5ue+lcyjyRMdquI9ngsha2h3 AC8plMVkcvZSw== Date: Thu, 10 Feb 2022 16:59:29 +0100 From: Frederic Weisbecker To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys Message-ID: <20220210155929.GB567552@lothringen> References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-6-mark.rutland@arm.com> <20220209174801.GA547263@lothringen> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 10:27:39AM +0000, Mark Rutland wrote: > On Wed, Feb 09, 2022 at 06:48:01PM +0100, Frederic Weisbecker wrote: > > On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote: > > > +config HAVE_PREEMPT_DYNAMIC_KEY > > > + bool > > > + depends on JUMP_LABEL > > > > This should probably be: > > > > depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO > > select JUMP_LABEL > > > > Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n. > > I'll make that: > > config HAVE_PREEMPT_DYNAMIC_KEY > bool > depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO > ... > > ... and > > config PREEMPT_DYNAMIC > bool "Preemption behaviour defined on boot" > depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT > select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY > ... > > So that we don't force JUMP_LABEL on even when people aren't using it. Much better! Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A58BC433EF for ; Thu, 10 Feb 2022 16:00:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZxIq57fEMW6cWCap20WJ6rcf0lMecH1M0KGb7iyZgrc=; b=LkENcxwBhh47yO sh9jPqH+f8WBdAvS2uldxQw7YjLnckiUMuodnWDgBSyb6E7/A89fn3r8MkiPFXZXtHuBeGYjIWGFL U74WaEbXJ18kXK7+k50mp+jcfFx1OLQu/2FagxjgHJwMR91X2/XXJCxFuuGitCLsfI6xyY7CsTdhg /YMIDNKXr7brJDUpVngARD1BwXBj8sjeHmZQAffhDQjCaEEfUV3mPbIHzgSbhoukZKMeML4N3IRq8 bm5cTwYgjkWIWMEeRV1c9KWX9nhpsitLNYT8mj22RcYOXuejCoPe9yjeyMTF/YhcrGVVQu3xllt87 zfqmn4M6B33CO/YbrDQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIBr8-004IFG-Ln; Thu, 10 Feb 2022 15:59:38 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIBr3-004IDV-F2 for linux-arm-kernel@lists.infradead.org; Thu, 10 Feb 2022 15:59:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8E3361CA4; Thu, 10 Feb 2022 15:59:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6D98C340EE; Thu, 10 Feb 2022 15:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644508772; bh=dIgio40C1V0AUEVczldmp/PFz0TwGbd4uOrumI1TjKs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W6srJBqUF2/+KCo/h3Ta6qgvtRrsGezTiaT6oiKgyQGPmShZwnJw7oUVcDAhcxrir 6QHI3ua4NPlJ0SXsj4khnhcRW0ZKFl2lSOQ5qe/CI6ynJrkNteWkQy9b1xX6MTGeVM 4M0/Or6M1G1c3ZIl4UoKrhxzX2VNB/hO6VE6aSIIdm5BOCpLheaJhpVdKtoYCYsxBl 6spqOuH/JUcbnu7mHMpNut+NYroWnwFpRRhF5lz/NqhJII87ELV0CqSD3E0+R0G5C6 h/T2AI6m4WBFRa1IB1j24wZeSwm+qfFvjz18w7HMcu5ue+lcyjyRMdquI9ngsha2h3 AC8plMVkcvZSw== Date: Thu, 10 Feb 2022 16:59:29 +0100 From: Frederic Weisbecker To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, james.morse@arm.com, joey.gouly@arm.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, valentin.schneider@arm.com, will@kernel.org Subject: Re: [PATCH v3 5/7] sched/preempt: add PREEMPT_DYNAMIC using static keys Message-ID: <20220210155929.GB567552@lothringen> References: <20220209153535.818830-1-mark.rutland@arm.com> <20220209153535.818830-6-mark.rutland@arm.com> <20220209174801.GA547263@lothringen> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220210_075933_550332_43CAFB72 X-CRM114-Status: GOOD ( 15.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 10:27:39AM +0000, Mark Rutland wrote: > On Wed, Feb 09, 2022 at 06:48:01PM +0100, Frederic Weisbecker wrote: > > On Wed, Feb 09, 2022 at 03:35:33PM +0000, Mark Rutland wrote: > > > +config HAVE_PREEMPT_DYNAMIC_KEY > > > + bool > > > + depends on JUMP_LABEL > > > > This should probably be: > > > > depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO > > select JUMP_LABEL > > > > Otherwise you may run into trouble if CONFIG_JUMP_LABEL is initially n. > > I'll make that: > > config HAVE_PREEMPT_DYNAMIC_KEY > bool > depends on HAVE_ARCH_JUMP_LABEL && CC_HAS_ASM_GOTO > ... > > ... and > > config PREEMPT_DYNAMIC > bool "Preemption behaviour defined on boot" > depends on HAVE_PREEMPT_DYNAMIC && !PREEMPT_RT > select JUMP_LABEL if HAVE_PREEMPT_DYNAMIC_KEY > ... > > So that we don't force JUMP_LABEL on even when people aren't using it. Much better! Thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel