From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0F97C433EF for ; Thu, 10 Feb 2022 17:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244999AbiBJRKZ (ORCPT ); Thu, 10 Feb 2022 12:10:25 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244993AbiBJRKW (ORCPT ); Thu, 10 Feb 2022 12:10:22 -0500 Received: from relay12.mail.gandi.net (relay12.mail.gandi.net [IPv6:2001:4b98:dc4:8::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC444E6A for ; Thu, 10 Feb 2022 09:10:21 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id 19133200003; Thu, 10 Feb 2022 17:10:16 +0000 (UTC) Date: Thu, 10 Feb 2022 18:11:23 +0100 From: Jacopo Mondi To: Tomi Valkeinen Cc: Steve Longerbeam , laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi, hverkuil-cisco@xs4all.nl, mirela.rabulea@nxp.com, xavier.roumegue@oss.nxp.com, hugues.fruchet@st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, aford173@gmail.com, festevam@gmail.com, Eugen.Hristev@microchip.com, jbrunet@baylibre.com, Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH v2 00/23] media: ov5640: Rework the clock tree programming for MIPI Message-ID: <20220210171123.oi54lq47eyjucwpk@uno.localdomain> References: <20220210110458.152494-1-jacopo@jmondi.org> <5db6f493-ca45-311a-1f44-9138e01722a1@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5db6f493-ca45-311a-1f44-9138e01722a1@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Tomi On Thu, Feb 10, 2022 at 03:00:21PM +0200, Tomi Valkeinen wrote: > On 10/02/2022 13:04, Jacopo Mondi wrote: > > v1: > > https://patchwork.linuxtv.org/project/linux-media/list/?series=7249 > > You could rather point to lore.kernel.org, so that the intro letter and the > discussions are also visible. Sure, here you go! https://lore.kernel.org/linux-media/20220131143245.128089-1-jacopo@jmondi.org/ > > > A branch for testing based on the most recent media-master is available at > > https://git.sr.ht/~jmondi_/linux #jmondi/media-master/ov5640-v2 > > > > If anyone with a DVP setup could verify I have not broken their use case > > I would very much appreciate that :) > > > > v1 -> v2: > > - rework the modes definition to process the full pixel array > > - rework get_selection to report the correct BOUND and DEFAULT targets > > - implement init_cfg > > - minor style changes as suggested by Laurent > > - test with 1 data lane > > Very nice! I tested this on TI's DRA76 EVM (CSI-2). UYVY and RGB565, with > the following resolutions: 160 120, 176 144, 320 240, 640 480, 720 480, 720 > 576, 1024 768, 1280 720, 1920 1080. Great! A 2 data lanes setup I assume ? Have you been able to test the framerate as well ? > > All work. The only issue I saw was that with 1024x768 and 1280x720 there's a > thin vertical pueple column on the right edge. Argh, you're right. I'll see if I can fix them! Thanks j > > Tomi