From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A48D5C433F5 for ; Thu, 10 Feb 2022 21:20:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFE90835EA; Thu, 10 Feb 2022 22:20:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="eAHXjKLh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9B6983559; Thu, 10 Feb 2022 22:20:27 +0100 (CET) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E846E83559 for ; Thu, 10 Feb 2022 22:20:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id t1so6830209qtq.13 for ; Thu, 10 Feb 2022 13:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LJhNhz/W9ZLWcq7sHVYwDlAO9u3vkWc3+mDSVzooyHE=; b=eAHXjKLhybri+v1Dl4DaDcc+qF5TxsdDagd/sBI589VhgKYNPt+CZORb3z6rTZNPAD LpqDQAatWCdfdU3XuidtHyiTXMOx08TVcQV0D77bD5sx7SohtXTmBmyNzjZ3zPOOUdqN f3/hRl8RuiIaTiKo331tZZtclA36D9/XUJZSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LJhNhz/W9ZLWcq7sHVYwDlAO9u3vkWc3+mDSVzooyHE=; b=1Vnsbq0O+L6CjEasIKXCQdWdA+8Ndg3M/Zw+TotD2YKo7ZDVTF0r6a5AQcLNV15G94 R9JT0X817DOn0rcwxiiU69NBz4mo+yrhakpcfPyqXIke3hs9gxaiItPyv2FQCUO+QDfE ddvXP9Ntg41ubdWGJWgf+u36Hn8dbmdcYCAWu4h+HMwYHWi2oohnUJESwy3IdXJSYaPw xLyozEOa+YId//iZ5q/2JGiObpTY51UyycOSR4yVbyECTsChmtYfgi11H2LwBkpq/6bc HQHROMEkaOmLBWdkTczA1ss0z+FIJxwS9HBFW0w34ZvGm0o/rMtgSbaGNpURZKJLrwK2 xBQA== X-Gm-Message-State: AOAM530F7rKcuLIko8wUyMeqizimakIdFnJBleFNauiFghAYDwc34Afm GYva73QvMsaVZzwVGqNrCxYxlA== X-Google-Smtp-Source: ABdhPJzUZdVQq24gNhPbcJfCWPl8ADJQo0uzB294qqYPf/aNHgKYZtn99aWASFYI9eq+WLP0VfT6Fg== X-Received: by 2002:ac8:78b:: with SMTP id l11mr6392128qth.498.1644528022626; Thu, 10 Feb 2022 13:20:22 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id z19sm11971957qtj.77.2022.02.10.13.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Feb 2022 13:20:22 -0800 (PST) Date: Thu, 10 Feb 2022 16:20:20 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List Subject: Re: Please pull u-boot-dm (take 3) Message-ID: <20220210212020.GL2697206@bill-the-cat> References: <20220210200824.GI2697206@bill-the-cat> <20220210204051.GJ2697206@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5me2qT3T17SWzdxI" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --5me2qT3T17SWzdxI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 10, 2022 at 02:01:21PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Thu, 10 Feb 2022 at 13:40, Tom Rini wrote: > > > > On Thu, Feb 10, 2022 at 01:23:36PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Thu, 10 Feb 2022 at 13:08, Tom Rini wrote: > > > > > > > > On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote: > > > > > > > > > Hi Tom, > > > > > > > > > > This just drops off the final patch of 'take 2' since that is bei= ng reworked. > > > > > > > > > > > > > > > running here: > > > > > > > > > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10= 936 > > > > > > > > > > > > > > > The following changes since commit 859703251251d9567f29ab10c0a29f= 98eb0aff5c: > > > > > > > > > > Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 = -0500) > > > > > > > > > > are available in the Git repository at: > > > > > > > > > > git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3 > > > > > > > > > > for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215= b413d5: > > > > > > > > > > binman: Convert FIT entry type to a subclass of Section entry t= ype > > > > > (2022-02-09 12:30:13 -0700) > > > > > > > > > > > > > So first, applied to u-boot/master. But I still had to re-generate > > > > scripts/pylint.base, and some numbers went down, but the code is > > > > cleaner. Can we just make pylint fail when there's serious errors = with > > > > the code perhaps? > > > > > > Do you mean fail when the numbers go down? > > > > No, it fails today when the numbers go down, like this PR did. Or would > > have if I didn't just ignore it and accept the lower number because the > > code was cleaned up. I mean is there some way to get pylint to say > > "this code has serious violations" and non-zero exit rather than just > > assign the code a numeric grade? >=20 > pylint is one of the world's slowest programs. We run in parallel on > each file to keep the run time bearable. >=20 > The return code for individual pylint processes is generally non-zero, > unless we happen to get a score of 10. We could use --fail-under but > that seems to fail often enough even if the score is exactly equal to > the value provided (i.e. we need to subtract 0.01). >=20 > We could add pylint checking to gitlab and 'make check' since it does > at least provide a list of files which have got worse. >=20 > As to 'serious violations', there are already a lot. There is a flag > to only consider certain classes of violations, but for now we cannot > turn that on. Perhaps that should be a first step? Yeah, OK. I'd like to focus on fixing the serious violations, make that a CI check and let any other cleanups be up to the script authors as time permits, rather than within CI. Maybe we keep pylint.base, but update it per release and it's more informative than basis for pass/fail on changes. >=20 > Regards, > Simon --=20 Tom --5me2qT3T17SWzdxI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIFgZAACgkQFHw5/5Y0 tyyQzAwAhhYC17F2XzHiVpxTRvnjLCWe/7maVVrTrCoZgupYTxOLg6u1hzvjp6bS ZDcIar7oPcKqtuHE6ZgOePwMEfkCbIJYN/XI8hMkZULYDmdOGaPLHBsUjeSrLrf4 vT68iu/Q+411p3X6vjwYWyCy1KBTBOt8VHpFyUJ66QKzD68tb6tocw/ma2gDlW2h sxEdkfvaqEiAixWcuegy+6zeyoYqZzhLFKfjaXvHrvK5JYqgH+74fUj06rzim3uz hNLdIqmpFaQ8Q7VMZ7Bj2djXDr99YKXKyXe8N5Q1yrRfiZrkwoYrLZNRBfy4S8Eo R9CJUGqrmNgY8Y5oI04I4bIuMFRmxuiiV8IW5f4toq4UlLP9Qg4wGeCKEN7P/o3M WRmjE53z0ZCYunw/70Dtri0v0Kjri+xKtV8Ou/ulX2BdAw0SnU/Q0YtWoM4t9wbK KOniCOtxAtRFl8gD8zk30S26tV1xPmgmbSVytWiTB6Al04uxL70x288eVvAEHhhi M5xyTwD3 =C9Hj -----END PGP SIGNATURE----- --5me2qT3T17SWzdxI--