All of
 help / color / mirror / Atom feed
From: Jeremy Kerr <>
Cc: Matt Johnston <>,
	"David S. Miller" <>,
	Jakub Kicinski <>
Subject: [PATCH net] mctp: serial: Cancel pending work from ndo_uninit handler
Date: Fri, 11 Feb 2022 09:15:52 +0800	[thread overview]
Message-ID: <> (raw)

We cannot do the cancel_work_sync from after the unregister_netdev, as
the dev pointer is no longer valid, causing a uaf on ldisc unregister
(or device close).

Instead, do the cancel_work_sync from the ndo_uninit op, where the dev
still exists, but the queue has stopped.

Fixes: 7bd9890f3d74 ("mctp: serial: cancel tx work on ldisc close")

Reported-by: Luo Likang <>
Tested-by: Luo Likang <>
Signed-off-by: Jeremy Kerr <>
 drivers/net/mctp/mctp-serial.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mctp/mctp-serial.c b/drivers/net/mctp/mctp-serial.c
index eaa6fb3224bc..62723a7faa2d 100644
--- a/drivers/net/mctp/mctp-serial.c
+++ b/drivers/net/mctp/mctp-serial.c
@@ -403,8 +403,16 @@ static void mctp_serial_tty_receive_buf(struct tty_struct *tty,
 		mctp_serial_push(dev, c[i]);
+static void mctp_serial_uninit(struct net_device *ndev)
+	struct mctp_serial *dev = netdev_priv(ndev);
+	cancel_work_sync(&dev->tx_work);
 static const struct net_device_ops mctp_serial_netdev_ops = {
 	.ndo_start_xmit = mctp_serial_tx,
+	.ndo_uninit = mctp_serial_uninit,
 static void mctp_serial_setup(struct net_device *ndev)
@@ -483,7 +491,6 @@ static void mctp_serial_close(struct tty_struct *tty)
 	int idx = dev->idx;
-	cancel_work_sync(&dev->tx_work);
 	ida_free(&mctp_serial_ida, idx);

             reply	other threads:[~2022-02-11  1:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11  1:15 Jeremy Kerr [this message]
2022-02-11 22:50 ` [PATCH net] mctp: serial: Cancel pending work from ndo_uninit handler patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.