From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E327FC433EF for ; Fri, 11 Feb 2022 09:46:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348682AbiBKJqV (ORCPT ); Fri, 11 Feb 2022 04:46:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:32796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343993AbiBKJqT (ORCPT ); Fri, 11 Feb 2022 04:46:19 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3D81D10A1 for ; Fri, 11 Feb 2022 01:46:19 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB012D6E; Fri, 11 Feb 2022 01:46:18 -0800 (PST) Received: from bogus (unknown [10.57.3.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 343323F73B; Fri, 11 Feb 2022 01:46:15 -0800 (PST) Date: Fri, 11 Feb 2022 09:45:27 +0000 From: Sudeep Holla To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Sudeep Holla , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 40/49] firmware: pcsi: replace cpumask_weight with cpumask_weight_eq Message-ID: <20220211094527.kmcnvz7iyiwkxtbc@bogus> References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-41-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210224933.379149-41-yury.norov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 02:49:24PM -0800, Yury Norov wrote: > down_and_up_cpus() calls cpumask_weight() to compare the weight of > cpumask with a given number. We can do it more efficiently with > cpumask_weight_{eq, ...} because conditional cpumask_weight may stop > traversing the cpumask earlier, as soon as condition is (or can't be) met. > Nit: s/pcsi/psci/ in $subject. With that fixed, Reviewed-by: Sudeep Holla -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 659C6C433EF for ; Fri, 11 Feb 2022 09:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7hQVcjphZ+yaEr5gf/jZRB0ChpDWPS2Cn7hG7Ldk7nA=; b=kXWi/CV2R4LZ2I GOtMYBKGNAz3Rl4+NnvZttI7uN4xROAIkf8Zx3rhbfHhHoP5/O5hi6Odt1QlbSrqcU4xlsJJ6SGl1 DOE1cSHiHVoIVGGV4CbRlPerHBRJpueS0Ik7nXdWt5DkEj6GPkKedwZ740DipgKDwJRqQeDxeJ8km 0xPUj7gGOeppj9Th/8HgIRK6UF6Grbh3P1LMGTjLda6kxAtbHxYDOeh+xONCSMR+KPO3v+bqcAdnq JwBvXE9GN/ACUbIALTDD9vHVZTJaE5XD3Fh3tfaTx1InorJXdWYcSrB255og1miKg12y0lpPzcjQo ewEYJyfAZvYXOIva1Ykw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nISVd-006T9x-1K; Fri, 11 Feb 2022 09:46:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nISVT-006T6W-CJ for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 09:46:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB012D6E; Fri, 11 Feb 2022 01:46:18 -0800 (PST) Received: from bogus (unknown [10.57.3.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 343323F73B; Fri, 11 Feb 2022 01:46:15 -0800 (PST) Date: Fri, 11 Feb 2022 09:45:27 +0000 From: Sudeep Holla To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Greg Kroah-Hartman , Peter Zijlstra , David Laight , Sudeep Holla , Joe Perches , Dennis Zhou , Emil Renner Berthing , Nicholas Piggin , Matti Vaittinen , Alexey Klimov , linux-kernel@vger.kernel.org, Mark Rutland , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 40/49] firmware: pcsi: replace cpumask_weight with cpumask_weight_eq Message-ID: <20220211094527.kmcnvz7iyiwkxtbc@bogus> References: <20220210224933.379149-1-yury.norov@gmail.com> <20220210224933.379149-41-yury.norov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220210224933.379149-41-yury.norov@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_014623_494395_398FEB16 X-CRM114-Status: UNSURE ( 7.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 02:49:24PM -0800, Yury Norov wrote: > down_and_up_cpus() calls cpumask_weight() to compare the weight of > cpumask with a given number. We can do it more efficiently with > cpumask_weight_{eq, ...} because conditional cpumask_weight may stop > traversing the cpumask earlier, as soon as condition is (or can't be) met. > Nit: s/pcsi/psci/ in $subject. With that fixed, Reviewed-by: Sudeep Holla -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel