From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A631C433F5 for ; Sat, 12 Feb 2022 00:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354452AbiBLAiW (ORCPT ); Fri, 11 Feb 2022 19:38:22 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354444AbiBLAiV (ORCPT ); Fri, 11 Feb 2022 19:38:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D603B35 for ; Fri, 11 Feb 2022 16:38:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B62AB61C55 for ; Sat, 12 Feb 2022 00:38:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E44E0C340E9; Sat, 12 Feb 2022 00:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644626298; bh=PbkglsZ5pGHenN7Xz98qpvWgdypqSv0PgSwaprK6RHI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Of7VgPuN1IHnchwRypXWc8IfZ3zPn8Lg439Zf4UFSWnKdnQXshYJz8dPSWZGnqeUz 7Rj8BBc2h7aXs207DM3t2NfUomC4+V36m5euawDfvdSCbmTTbyd2ZoyzvbpQu+25N2 o9ZAFuevHrEPocVtd9+jFOEpezj1KFaaOQ66cjrSgvQVHGqvh9uY8XM35CsFutYJss TBtRAMAzta4utPGNMQsJpwH9QgTyJFRUwalnGwRRna36tasiu+wwRaPAw8GCsiL+ou kn3vm2tIdXt+KRFWIWo1U3gAjKFWFlgPPmIRjW+r3oek46oxjqUo0rmu6daguX0QIT P7n9Siv0xzuSw== Date: Fri, 11 Feb 2022 16:38:17 -0800 From: Jakub Kicinski To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, Imre Kaloz , Krzysztof Halasa , "David S . Miller" , netdev@vger.kernel.org Subject: Re: [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon Message-ID: <20220211163817.682df7c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220211223238.648934-10-linus.walleij@linaro.org> References: <20220211223238.648934-1-linus.walleij@linaro.org> <20220211223238.648934-10-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 11 Feb 2022 23:32:34 +0100 Linus Walleij wrote: > If we access the syscon (expansion bus config registers) using the > syscon regmap instead of relying on direct accessor functions, > we do not need to call this static code in the machine > (arch/arm/mach-ixp4xx/common.c) which makes things less dependent > on custom machine-dependent code. > > Look up the syscon regmap and handle the error: this will make > deferred probe work with relation to the syscon. > > Select the syscon in Kconfig and depend on OF so we know that > all we need will be available. > > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - No changes. > > Network maintainers: I'm looking for an ACK to take this > change through ARM SoC along with other changes removing > these accessor functions. Acked-by: Jakub Kicinski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C52CEC433F5 for ; Sat, 12 Feb 2022 00:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=92gFXkJJFpLmc9j+EHvyz/OTSMaKI56tl918vsHnL2U=; b=NOmIBRQl9iHDZI 3LKq5TyZ6GcnZsh5mSx1uFALR6Oot9J3w9uztKCbSmmR9s5MT8hqdzMgrh8EY6AyIOvN0XPuwqTLA TjKTbCUSX8DJeo0tenH7Gumep26eWJZAf16HwhsZSDB4PbVFeHm62teR4RJxpOJWd+I1+ctZoctW0 YqSMvDpciAt7pZnC4cTAdmPUcTc3HiDBx8JNrNJchqrgaRTbxiXIqYEqTVs1WPMCX7DvdLdZB/Jof 0TQ95oXHYd2bpK+zyx5nbsOIXGyobPSgKzpoL2HBPnDPGFnLEbI1YJJ+5VhxwPzImJHk6ufEE3m3w 52Fo4ZBb2oNiFwU0mG2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIgQj-009CAi-Tr; Sat, 12 Feb 2022 00:38:26 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIgQf-009C90-BZ for linux-arm-kernel@lists.infradead.org; Sat, 12 Feb 2022 00:38:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C81FB82DF8; Sat, 12 Feb 2022 00:38:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E44E0C340E9; Sat, 12 Feb 2022 00:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644626298; bh=PbkglsZ5pGHenN7Xz98qpvWgdypqSv0PgSwaprK6RHI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Of7VgPuN1IHnchwRypXWc8IfZ3zPn8Lg439Zf4UFSWnKdnQXshYJz8dPSWZGnqeUz 7Rj8BBc2h7aXs207DM3t2NfUomC4+V36m5euawDfvdSCbmTTbyd2ZoyzvbpQu+25N2 o9ZAFuevHrEPocVtd9+jFOEpezj1KFaaOQ66cjrSgvQVHGqvh9uY8XM35CsFutYJss TBtRAMAzta4utPGNMQsJpwH9QgTyJFRUwalnGwRRna36tasiu+wwRaPAw8GCsiL+ou kn3vm2tIdXt+KRFWIWo1U3gAjKFWFlgPPmIRjW+r3oek46oxjqUo0rmu6daguX0QIT P7n9Siv0xzuSw== Date: Fri, 11 Feb 2022 16:38:17 -0800 From: Jakub Kicinski To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, Imre Kaloz , Krzysztof Halasa , "David S . Miller" , netdev@vger.kernel.org Subject: Re: [PATCH 09/13 v2] net: ixp4xx_hss: Check features using syscon Message-ID: <20220211163817.682df7c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220211223238.648934-10-linus.walleij@linaro.org> References: <20220211223238.648934-1-linus.walleij@linaro.org> <20220211223238.648934-10-linus.walleij@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_163821_605022_9AF3F2E1 X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 11 Feb 2022 23:32:34 +0100 Linus Walleij wrote: > If we access the syscon (expansion bus config registers) using the > syscon regmap instead of relying on direct accessor functions, > we do not need to call this static code in the machine > (arch/arm/mach-ixp4xx/common.c) which makes things less dependent > on custom machine-dependent code. > > Look up the syscon regmap and handle the error: this will make > deferred probe work with relation to the syscon. > > Select the syscon in Kconfig and depend on OF so we know that > all we need will be available. > > Cc: David S. Miller > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - No changes. > > Network maintainers: I'm looking for an ACK to take this > change through ARM SoC along with other changes removing > these accessor functions. Acked-by: Jakub Kicinski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel