From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84627C433F5 for ; Fri, 11 Feb 2022 17:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352337AbiBKRvB (ORCPT ); Fri, 11 Feb 2022 12:51:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352330AbiBKRvA (ORCPT ); Fri, 11 Feb 2022 12:51:00 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A452FCEC; Fri, 11 Feb 2022 09:50:57 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59F281042; Fri, 11 Feb 2022 09:50:57 -0800 (PST) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B0AC3F70D; Fri, 11 Feb 2022 09:50:56 -0800 (PST) Date: Fri, 11 Feb 2022 17:50:45 +0000 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Bjorn Helgaas , Rob Herring , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/11] PCI: mvebu: subsystem ids, AER and INTx Message-ID: <20220211175029.GA2300@lpieralisi> References: <20220105150239.9628-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220105150239.9628-1-pali@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 05, 2022 at 04:02:28PM +0100, Pali Rohár wrote: > This patch series extends pci-bridge-emul.c driver to emulate PCI Subsystem > Vendor ID capability and PCIe extended capabilities. And then implement > in pci-mvebu.c driver support for PCI Subsystem Vendor IDs, PCIe AER > registers, support for legacy INTx interrupts, configuration for X1/X4 > mode and usage of new PCI child_ops API. > > This patch series depends on other pci-mvebu and pci-bridge-emul patches from: > https://lore.kernel.org/linux-pci/20220104153529.31647-1-pali@kernel.org/ Hi Pali, I went through the series quickly and I don't think there is anything controversial, posted some minor comments. Do not repost yet, I will be back at v5.17-rc5 and work towards merging it for v5.18. Lorenzo > > Pali Rohár (9): > PCI: pci-bridge-emul: Add support for PCI Bridge Subsystem Vendor ID > capability > dt-bindings: PCI: mvebu: Add num-lanes property > PCI: mvebu: Correctly configure x1/x4 mode > PCI: mvebu: Add support for PCI Bridge Subsystem Vendor ID on emulated > bridge > PCI: mvebu: Add support for Advanced Error Reporting registers on > emulated bridge > PCI: mvebu: Use child_ops API > dt-bindings: PCI: mvebu: Update information about intx interrupts > PCI: mvebu: Implement support for legacy INTx interrupts > ARM: dts: armada-385.dtsi: Add definitions for PCIe legacy INTx > interrupts > > Russell King (2): > PCI: pci-bridge-emul: Re-arrange register tests > PCI: pci-bridge-emul: Add support for PCIe extended capabilities > > .../devicetree/bindings/pci/mvebu-pci.txt | 16 + > arch/arm/boot/dts/armada-385.dtsi | 52 ++- > drivers/pci/controller/pci-mvebu.c | 352 +++++++++++++++--- > drivers/pci/pci-bridge-emul.c | 167 ++++++--- > drivers/pci/pci-bridge-emul.h | 17 + > 5 files changed, 494 insertions(+), 110 deletions(-) > > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12FDAC433EF for ; Fri, 11 Feb 2022 17:52:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pwgq5rsELqc5N+/4L3zZso+iLeSRkF4A1HuZMFD/Wl4=; b=BJ+jNlQpqjRwwL Pf1apiFauixV6iPWkxnrUf3iCOiimzzmqmaoIESwii13S8fZ9WggJURaSDIdcdbNjT2sq0roywYyW bRrSPKmRmSiWHilABhGDTOgfmOg4Cqu46+oupco5MCLSrAOpfhFpw9czDlEhLqU+s+kvaGDhb1uF+ O9NslKr1aa+i6tYFbLymVvGpErYH6JhXv1pngIElgU/IGVa/qeGoe2ETzVvzRXGJzsV43qwIAT+Cn lAij7leQfAfucjmIy5FxESYiN/yP1Zf1woyOZ+bDp7gp2CFZ6F4Q44JhXOBYkqUc/PMM74eEj2lb8 tgbo1E28p3JDOkHHBYhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIa4T-008HBp-OH; Fri, 11 Feb 2022 17:51:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nIa4Q-008HBJ-RM for linux-arm-kernel@lists.infradead.org; Fri, 11 Feb 2022 17:51:00 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59F281042; Fri, 11 Feb 2022 09:50:57 -0800 (PST) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1B0AC3F70D; Fri, 11 Feb 2022 09:50:56 -0800 (PST) Date: Fri, 11 Feb 2022 17:50:45 +0000 From: Lorenzo Pieralisi To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Bjorn Helgaas , Rob Herring , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?iso-8859-1?Q?Beh=FAn?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/11] PCI: mvebu: subsystem ids, AER and INTx Message-ID: <20220211175029.GA2300@lpieralisi> References: <20220105150239.9628-1-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220105150239.9628-1-pali@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220211_095058_972594_B30764FE X-CRM114-Status: GOOD ( 15.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 05, 2022 at 04:02:28PM +0100, Pali Roh=E1r wrote: > This patch series extends pci-bridge-emul.c driver to emulate PCI Subsyst= em > Vendor ID capability and PCIe extended capabilities. And then implement > in pci-mvebu.c driver support for PCI Subsystem Vendor IDs, PCIe AER > registers, support for legacy INTx interrupts, configuration for X1/X4 > mode and usage of new PCI child_ops API. > = > This patch series depends on other pci-mvebu and pci-bridge-emul patches = from: > https://lore.kernel.org/linux-pci/20220104153529.31647-1-pali@kernel.org/ Hi Pali, I went through the series quickly and I don't think there is anything controversial, posted some minor comments. Do not repost yet, I will be back at v5.17-rc5 and work towards merging it for v5.18. Lorenzo > = > Pali Roh=E1r (9): > PCI: pci-bridge-emul: Add support for PCI Bridge Subsystem Vendor ID > capability > dt-bindings: PCI: mvebu: Add num-lanes property > PCI: mvebu: Correctly configure x1/x4 mode > PCI: mvebu: Add support for PCI Bridge Subsystem Vendor ID on emulated > bridge > PCI: mvebu: Add support for Advanced Error Reporting registers on > emulated bridge > PCI: mvebu: Use child_ops API > dt-bindings: PCI: mvebu: Update information about intx interrupts > PCI: mvebu: Implement support for legacy INTx interrupts > ARM: dts: armada-385.dtsi: Add definitions for PCIe legacy INTx > interrupts > = > Russell King (2): > PCI: pci-bridge-emul: Re-arrange register tests > PCI: pci-bridge-emul: Add support for PCIe extended capabilities > = > .../devicetree/bindings/pci/mvebu-pci.txt | 16 + > arch/arm/boot/dts/armada-385.dtsi | 52 ++- > drivers/pci/controller/pci-mvebu.c | 352 +++++++++++++++--- > drivers/pci/pci-bridge-emul.c | 167 ++++++--- > drivers/pci/pci-bridge-emul.h | 17 + > 5 files changed, 494 insertions(+), 110 deletions(-) > = > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel