From: Pavel Machek <pavel@ucw.cz>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Florian Eckert <fe@dev.tdt.de>, Rob Herring <robh+dt@kernel.org>,
Eckert.Florian@googlemail.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] leds: ktd20xx: Extension of the KTD20xx family of LED drivers from Kinetic
Date: Sat, 12 Feb 2022 13:08:57 +0100 [thread overview]
Message-ID: <20220212120857.GJ20866@duo.ucw.cz> (raw)
In-Reply-To: <CAHp75Vd4pwFXoF=xS5cskM2GDNb6c6RXTYo3j3FLP+nuQVoRyg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
Hi!
> > + struct device *dev = &chip->client->dev;
> > + int ret;
> > + unsigned int value;
>
> Here and everywhere can you use reverse xmas tree ordering?
>
> struct device *dev = &chip->client->dev;
> unsigned int value;
> int ret;
Lets not ask people to do that.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-02-12 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:01 [PATCH v4 0/2] leds: add ktd20xx LED driver support Florian Eckert
2022-01-21 14:01 ` [PATCH v4 1/2] leds: ktd20xx: Extension of the KTD20xx family of LED drivers from Kinetic Florian Eckert
2022-01-21 15:46 ` Andy Shevchenko
2022-02-12 12:08 ` Pavel Machek [this message]
2022-03-18 7:26 ` Florian Eckert
2022-01-25 3:48 ` kernel test robot
2022-01-25 3:48 ` kernel test robot
2022-01-21 14:01 ` [PATCH v4 2/2] dt: bindings: KTD20xx: Introduce the ktd20xx family of RGB drivers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220212120857.GJ20866@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=Eckert.Florian@googlemail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fe@dev.tdt.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.