From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3906CC433EF for ; Sat, 12 Feb 2022 12:36:33 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A98940395; Sat, 12 Feb 2022 13:36:32 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 5650840140 for ; Sat, 12 Feb 2022 13:36:30 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21CCGl4O009781; Sat, 12 Feb 2022 04:36:29 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=/G4YjRLUqxBc9sZtoHh8SqYap2fGMrQZkvp9hwSdlDM=; b=QxQ2ySDhvcdYsF7suXhB5v2b4u5Yhks/OYtG0oNk4Zn/BaI5xyLY5kQ4MHZnzrfnpmee xLL95/yZ5xptSN1/Sr4EyLd7sFyX2+oCXiRQz1lk55NamqMN/lTNZuWN07nOTPGzE1qb DPkDunOpb1Fl9ineQEtu4jXZoUYc6cwsBCwf96laNIhWiJGLEO5xlJ4dPHHhk4g9I5m6 XdLT2GWx9+P0qVc9Qap+kTa9W2nVpvtDO/O7cVKEoHaxnRsOhdb2ILBB9BYyJTjIQ9kD +aYtchSVTnGYeXYGFORIiHaUubEKJjPQGRyRHmN3nY7OO0YcFsxTEhFbzf3QyDOZXE/3 Tg== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e5y70j8qn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 12 Feb 2022 04:36:29 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 12 Feb 2022 04:36:27 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Sat, 12 Feb 2022 04:36:27 -0800 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id 697D25B6940; Sat, 12 Feb 2022 04:36:25 -0800 (PST) From: Gowrishankar Muthukrishnan To: CC: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , , Gowrishankar Muthukrishnan Subject: [PATCH] ethdev: remove dead code in telemetry handler Date: Sat, 12 Feb 2022 18:06:21 +0530 Message-ID: <20220212123621.3394272-1-gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: OM1tU781Cvp_JpE4MzL0SD_M-ci9_a41 X-Proofpoint-GUID: OM1tU781Cvp_JpE4MzL0SD_M-ci9_a41 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-12_04,2022-02-11_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In telemetry handler for port info, there is no need to check if eth_dev object of a port id is not null, as it had already been evaluated once in rte_eth_dev_is_valid_port function. Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") Coverity issue: 373635 Signed-off-by: Gowrishankar Muthukrishnan --- lib/ethdev/rte_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index e03e669c31..3484aa2b32 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -6465,8 +6465,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused, return -EINVAL; eth_dev = &rte_eth_devices[port_id]; - if (!eth_dev) - return -EINVAL; rxq_state = rte_tel_data_alloc(); if (!rxq_state) -- 2.25.1