From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1601C433EF for ; Sat, 12 Feb 2022 12:38:37 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DD9941172; Sat, 12 Feb 2022 13:38:37 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C8B3C40140 for ; Sat, 12 Feb 2022 13:38:35 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 21CCaZpQ011982 for ; Sat, 12 Feb 2022 04:38:35 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=WCNN/9EpoJMepo5lcvq4Gdrp6tGWKS3eREHguUXwoos=; b=CzvlaNr6KyHuiM8lQEqR2d7ik6fpb6jXSTOax2Yd7EC+pA532+SyIzaxn8p0Emtt27hj 2IJkvHxbddj0qWhCDzOnSbwG7Ksn08R0CkAF+Z48ySBuG9lBfV31BGhrA5jlkT90FxEv 5lunN0o4dWlt/ZdOn72ynfyDIrPYNsp3XyZG+e/7RukDzKFqU5ASOeYXMofj+nNF/g65 pHFGA89ABw9YIXtS1coRwvOXzY6/IztlyKOEw31q5ktnWZ46HnTvb+CPkWN2pRgeE2PE DapSni2GMzuHY8CnaO9E2LLtpnVikxuK1ieFn0NcCEurI7KAph+8aXA/BlveosHNiOTw Qw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3e5y70j8uv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sat, 12 Feb 2022 04:38:35 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sat, 12 Feb 2022 04:38:33 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 12 Feb 2022 04:38:32 -0800 Received: from localhost.localdomain (unknown [10.28.34.38]) by maili.marvell.com (Postfix) with ESMTP id D171B5B6940; Sat, 12 Feb 2022 04:38:30 -0800 (PST) From: Gowrishankar Muthukrishnan To: CC: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , , Gowrishankar Muthukrishnan Subject: [PATCH 2/3] common/cnx: fix unintended sign extension Date: Sat, 12 Feb 2022 18:08:19 +0530 Message-ID: <20220212123820.3394341-2-gmuthukrishn@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220212123820.3394341-1-gmuthukrishn@marvell.com> References: <20220212123820.3394341-1-gmuthukrishn@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: rz3Ti9t4W04IeUf6vY1Jz7YjT1e8UR1V X-Proofpoint-GUID: rz3Ti9t4W04IeUf6vY1Jz7YjT1e8UR1V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-02-12_04,2022-02-11_01,2021-12-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch fixes unintended sign extensions reported in coverity scan. Fixes: 8ca851cdc59 ("common/cnxk: support dual VLAN insert and strip actions") Coverity issue: 373258 Signed-off-by: Gowrishankar Muthukrishnan --- drivers/common/cnxk/roc_npc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_npc.c b/drivers/common/cnxk/roc_npc.c index e3961bfbc6..453fd5d3e0 100644 --- a/drivers/common/cnxk/roc_npc.c +++ b/drivers/common/cnxk/roc_npc.c @@ -969,14 +969,14 @@ npc_vtag_insert_action_configure(struct mbox *mbox, struct roc_npc_flow *flow, vtag_cfg->cfg_type = VTAG_TX; vtag_cfg->vtag_size = NIX_VTAGSIZE_T4; vtag_cfg->tx.vtag0 = - ((vlan_info[0].vlan_ethtype << 16) | + (((uint32_t)vlan_info[0].vlan_ethtype << 16) | (vlan_info[0].vlan_pcp << 13) | vlan_info[0].vlan_id); vtag_cfg->tx.cfg_vtag0 = 1; if (flow->vtag_insert_count == 2) { vtag_cfg->tx.vtag1 = - ((vlan_info[1].vlan_ethtype << 16) | + (((uint32_t)vlan_info[1].vlan_ethtype << 16) | (vlan_info[1].vlan_pcp << 13) | vlan_info[1].vlan_id); vtag_cfg->tx.cfg_vtag1 = 1; -- 2.25.1